diff mbox series

[1/2] ksmbd: downgrade addition info error msg to debug in smb2_get_info_sec()

Message ID 20211121114333.6179-1-linkinjeon@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] ksmbd: downgrade addition info error msg to debug in smb2_get_info_sec() | expand

Commit Message

Namjae Jeon Nov. 21, 2021, 11:43 a.m. UTC
While file transfer through windows client, This error flood message
happen. This flood message will cause performance degradation and
misunderstand server has problem.

Fixes: e294f78d3478 ("ksmbd: allow PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO addition information in smb2 set info security")
Cc: stable@vger.kernel.org # v5.15
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---
 fs/ksmbd/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hyunchul Lee Nov. 23, 2021, 12:18 a.m. UTC | #1
Acked-by: Hyunchul Lee <hyc.lee@gmail.com>

2021년 11월 21일 (일) 오후 9:33, Namjae Jeon <linkinjeon@kernel.org>님이 작성:
>
> While file transfer through windows client, This error flood message
> happen. This flood message will cause performance degradation and
> misunderstand server has problem.
>
> Fixes: e294f78d3478 ("ksmbd: allow PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO addition information in smb2 set info security")
> Cc: stable@vger.kernel.org # v5.15
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
>  fs/ksmbd/smb2pdu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index 121f8e8c70ac..82954b2b8d31 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -5068,7 +5068,7 @@ static int smb2_get_info_sec(struct ksmbd_work *work,
>         if (addition_info & ~(OWNER_SECINFO | GROUP_SECINFO | DACL_SECINFO |
>                               PROTECTED_DACL_SECINFO |
>                               UNPROTECTED_DACL_SECINFO)) {
> -               pr_err("Unsupported addition info: 0x%x)\n",
> +               ksmbd_debug(SMB, "Unsupported addition info: 0x%x)\n",
>                        addition_info);
>
>                 pntsd->revision = cpu_to_le16(1);
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index 121f8e8c70ac..82954b2b8d31 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -5068,7 +5068,7 @@  static int smb2_get_info_sec(struct ksmbd_work *work,
 	if (addition_info & ~(OWNER_SECINFO | GROUP_SECINFO | DACL_SECINFO |
 			      PROTECTED_DACL_SECINFO |
 			      UNPROTECTED_DACL_SECINFO)) {
-		pr_err("Unsupported addition info: 0x%x)\n",
+		ksmbd_debug(SMB, "Unsupported addition info: 0x%x)\n",
 		       addition_info);
 
 		pntsd->revision = cpu_to_le16(1);