diff mbox series

[v3] fs: add the tuncate check of exfat

Message ID 20230328131334.5572-1-congmingyi@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v3] fs: add the tuncate check of exfat | expand

Commit Message

Mingyi Cong March 28, 2023, 1:13 p.m. UTC 
From: MIngyi Cong <congmingyi@gmail.com>

EXFAT will fill zero data in truncated range.
Fix this by adding EXFAT_SUPER_MAGIC check.

Signed-off-by: MIngyi Cong <congmingyi@gmail.com>
---
 fs/ksmbd/smb2pdu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Christoph Hellwig March 28, 2023, 11:54 p.m. UTC | #1 
NAK again.  You must not hardcode file syste magic numbers in
consumers of vfs API.  Not the existing one, and absolutelt not
a new one.  I told you a few times what to do but you keep ignoring it.
diff mbox series

Patch

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index 0685c1c77b9f..3f2e34936b8d 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -5746,7 +5746,8 @@  static int set_end_of_file_info(struct ksmbd_work *work, struct ksmbd_file *fp,
 	 * truncate of some filesystem like FAT32 fill zero data in
 	 * truncated range.
 	 */
-	if (inode->i_sb->s_magic != MSDOS_SUPER_MAGIC) {
+	if (inode->i_sb->s_magic != MSDOS_SUPER_MAGIC ||
+		inode->i_sb->s_magic != EXFAT_SUPER_MAGIC) {
 		ksmbd_debug(SMB, "truncated to newsize %lld\n", newsize);
 		rc = ksmbd_vfs_truncate(work, fp, newsize);
 		if (rc) {