diff mbox series

cifs: fix the incorrect assertion in cifs_swap_rw()

Message ID 20240617221813.58244-1-21cnbao@gmail.com (mailing list archive)
State New, archived
Headers show
Series cifs: fix the incorrect assertion in cifs_swap_rw() | expand

Commit Message

Barry Song June 17, 2024, 10:18 p.m. UTC
From: Barry Song <v-songbaohua@oppo.com>

Since commit 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS
swap-space"), we can plug multiple pages then unplug them all together.
That means iov_iter_count(iter) could be way bigger than PAGE_SIZE, it
actually equals the size of iov_iter_npages(iter, INT_MAX).

Note this issue has nothing to do with large folios as we don't support
THP_SWPOUT to non-block devices.

Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-space")
Reported-by: Christoph Hellwig <hch@lst.de>
Closes: https://lore.kernel.org/linux-mm/20240614100329.1203579-1-hch@lst.de/
Cc: NeilBrown <neilb@suse.de>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Steve French <sfrench@samba.org>
Cc: Trond Myklebust <trondmy@kernel.org>
Cc: Chuanhua Han <hanchuanhua@oppo.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Chris Li <chrisl@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
 fs/smb/client/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
index 9d5c2440abfc..2f11f138c57d 100644
--- a/fs/smb/client/file.c
+++ b/fs/smb/client/file.c
@@ -3200,7 +3200,7 @@  static int cifs_swap_rw(struct kiocb *iocb, struct iov_iter *iter)
 	ssize_t ret;
-	WARN_ON_ONCE(iov_iter_count(iter) != PAGE_SIZE);
+	WARN_ON_ONCE(iov_iter_count(iter) != iov_iter_npages(iter, INT_MAX) * PAGE_SIZE);
 	if (iov_iter_rw(iter) == READ)
 		ret = netfs_unbuffered_read_iter_locked(iocb, iter);