diff mbox series

[3/8] smb/server: remove useless variable assignment in smb2_open()

Message ID 20240820143319.274033-4-chenxiaosong@chenxiaosong.com (mailing list archive)
State New, archived
Headers show
Series smb: fix some bugs, move duplicate definitions to common header file, and some small cleanups | expand

Commit Message

ChenXiaoSong Aug. 20, 2024, 2:33 p.m. UTC 
From: ChenXiaoSong <chenxiaosong@kylinos.cn>

The variable is already true here.

Signed-off-by: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
---
 fs/smb/server/smb2pdu.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Namjae Jeon Aug. 22, 2024, 12:47 a.m. UTC | #1 
On Tue, Aug 20, 2024 at 11:35 PM <chenxiaosong@chenxiaosong.com> wrote:
>
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
>
> The variable is already true here.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Looks good.
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks.
diff mbox series

Patch

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 119c1ba5f255..4e87bbac2662 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -3100,7 +3100,6 @@  int smb2_open(struct ksmbd_work *work)
 			goto err_out;
 		}
 
-		file_present = true;
 		idmap = mnt_idmap(path.mnt);
 	} else {
 		if (rc != -ENOENT)