diff mbox series

[v2,12/12] smb: add comment to STATUS_MCA_OCCURED

Message ID 20240822082101.391272-13-chenxiaosong@chenxiaosong.com (mailing list archive)
State New, archived
Headers show
Series smb: fix some bugs, move duplicate definitions to common header file, and some small cleanups | expand

Commit Message

ChenXiaoSong Aug. 22, 2024, 8:21 a.m. UTC
From: ChenXiaoSong <chenxiaosong@kylinos.cn>

Explained why the typo was not corrected.

Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
 fs/smb/common/smb2status.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Namjae Jeon Aug. 22, 2024, 11:54 a.m. UTC | #1
On Thu, Aug 22, 2024 at 5:24 PM <chenxiaosong@chenxiaosong.com> wrote:
>
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
>
> Explained why the typo was not corrected.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Looks ok.
Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks.
> ---
>  fs/smb/common/smb2status.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/fs/smb/common/smb2status.h b/fs/smb/common/smb2status.h
> index 841d4c688411..14b4a5f04564 100644
> --- a/fs/smb/common/smb2status.h
> +++ b/fs/smb/common/smb2status.h
> @@ -901,6 +901,10 @@ struct ntstatus {
>  #define STATUS_DEVICE_ENUMERATION_ERROR cpu_to_le32(0xC0000366)
>  #define STATUS_MOUNT_POINT_NOT_RESOLVED cpu_to_le32(0xC0000368)
>  #define STATUS_INVALID_DEVICE_OBJECT_PARAMETER cpu_to_le32(0xC0000369)
> +/*
> + * 'OCCURED' is typo in MS-ERREF, it should be 'OCCURRED',
> + * but we'll keep it consistent with MS-ERREF.
> + */
>  #define STATUS_MCA_OCCURED cpu_to_le32(0xC000036A)
>  #define STATUS_DRIVER_BLOCKED_CRITICAL cpu_to_le32(0xC000036B)
>  #define STATUS_DRIVER_BLOCKED cpu_to_le32(0xC000036C)
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/fs/smb/common/smb2status.h b/fs/smb/common/smb2status.h
index 841d4c688411..14b4a5f04564 100644
--- a/fs/smb/common/smb2status.h
+++ b/fs/smb/common/smb2status.h
@@ -901,6 +901,10 @@  struct ntstatus {
 #define STATUS_DEVICE_ENUMERATION_ERROR cpu_to_le32(0xC0000366)
 #define STATUS_MOUNT_POINT_NOT_RESOLVED cpu_to_le32(0xC0000368)
 #define STATUS_INVALID_DEVICE_OBJECT_PARAMETER cpu_to_le32(0xC0000369)
+/*
+ * 'OCCURED' is typo in MS-ERREF, it should be 'OCCURRED',
+ * but we'll keep it consistent with MS-ERREF.
+ */
 #define STATUS_MCA_OCCURED cpu_to_le32(0xC000036A)
 #define STATUS_DRIVER_BLOCKED_CRITICAL cpu_to_le32(0xC000036B)
 #define STATUS_DRIVER_BLOCKED cpu_to_le32(0xC000036C)