From patchwork Mon Nov 15 14:54:41 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suresh Jayaraman X-Patchwork-Id: 325292 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oAFEsqt9008585 for ; Mon, 15 Nov 2010 14:54:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757593Ab0KOOyw (ORCPT ); Mon, 15 Nov 2010 09:54:52 -0500 Received: from victor.provo.novell.com ([137.65.250.26]:37597 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757475Ab0KOOyw (ORCPT ); Mon, 15 Nov 2010 09:54:52 -0500 Received: from jay-t60p.blr.novell.com (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP (TLS encrypted); Mon, 15 Nov 2010 07:54:46 -0700 Message-ID: <4CE149B1.5090901@suse.de> Date: Mon, 15 Nov 2010 20:24:41 +0530 From: Suresh Jayaraman User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Thunderbird/3.0.6 MIME-Version: 1.0 To: Jeff Layton CC: Steve French , linux-cifs@vger.kernel.org Subject: Re: [PATCH] cifs: handle cifs_get_tcon() errors properly References: <1289825123-13716-1-git-send-email-sjayaraman@suse.de> <20101115082535.0d7200a5@tlielax.poochiereds.net> In-Reply-To: <20101115082535.0d7200a5@tlielax.poochiereds.net> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 15 Nov 2010 14:54:53 +0000 (UTC) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 251a17c..6dbc145 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2780,7 +2780,10 @@ try_mount_again: if (IS_ERR(tcon)) { rc = PTR_ERR(tcon); tcon = NULL; - goto remote_path_check; + if (rc == -EREMOTE) + goto remote_path_check; + else + goto mount_fail_check; } /* do not care if following two calls succeed - informational */