From patchwork Fri Jan 9 16:18:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 1586 Received: from lists.samba.org (mail.samba.org [66.70.73.150]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n09GF7QY030652 for ; Fri, 9 Jan 2009 08:15:07 -0800 Received: from dp.samba.org (localhost [127.0.0.1]) by lists.samba.org (Postfix) with ESMTP id D62FB163C84 for ; Fri, 9 Jan 2009 16:18:38 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on dp.samba.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.8 tests=AWL,BAYES_00, DNS_FROM_RFC_POST,SPF_PASS autolearn=no version=3.1.7 X-Original-To: linux-cifs-client@lists.samba.org Delivered-To: linux-cifs-client@lists.samba.org Received: from mail-ew0-f18.google.com (mail-ew0-f18.google.com [209.85.219.18]) by lists.samba.org (Postfix) with ESMTP id B75B8163AE1 for ; Fri, 9 Jan 2009 16:18:19 +0000 (GMT) Received: by ewy11 with SMTP id 11so9620522ewy.20 for ; Fri, 09 Jan 2009 08:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=3AKo57lPFsTvdGEG5y2EXYdgOe9btSoVTz+Ul8q3P0E=; b=F0M0NcpjkYywP2hG/TOl4hJ1a0nvv2fWLobaWsLsy2+z0E5Oa2MGkT6F8f6wRY8ar9 BjLHxcrgP0Y7oGBcrxzsDuuZ/AEqB8oLxWL/mZTQIcVS+7TBcElzjIkSqMNpM28/fS/1 7oxxkWNwck3Q6PjiuI3Yd8YVNhZmpJ8I7f450= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=WrPonASdr4edNsqzeMc69n1zRPXQ7MKYIRjq1puVj/XQbahfhxaVXFJeYyGFzXIVAR V6SrpdWuyL8oI6DZZgGuCUfqT8Asnv8R+T86gdIdQBr3Xags5hsXWY3mS+8alRlmYtgb N4JRmJ5cceV8XCWfzXaax0qvKbd1AzEQ7lfos= Received: by 10.210.125.13 with SMTP id x13mr17220436ebc.48.1231517908995; Fri, 09 Jan 2009 08:18:28 -0800 (PST) Received: by 10.210.57.8 with HTTP; Fri, 9 Jan 2009 08:18:28 -0800 (PST) Message-ID: <524f69650901090818w7f367832vb9d0979714c3c609@mail.gmail.com> Date: Fri, 9 Jan 2009 10:18:28 -0600 From: "Steve French" To: "Jeff Layton" In-Reply-To: <20090109063318.04f260d1@tleilax.poochiereds.net> MIME-Version: 1.0 Content-Disposition: inline References: <1231424128-5598-1-git-send-email-jlayton@redhat.com> <524f69650901080623s228c343eka791c089c878167@mail.gmail.com> <20090109000708.GC12848@shareable.org> <524f69650901081932m2912ab73x147221f721194f8@mail.gmail.com> <20090109063318.04f260d1@tleilax.poochiereds.net> Cc: linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org, Jamie Lokier Subject: [linux-cifs-client] Re: [PATCH] cifs: remove dnotify thread code X-BeenThere: linux-cifs-client@lists.samba.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: The Linux CIFS VFS client List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+patchwork-cifs-client=patchwork.kernel.org@lists.samba.org Errors-To: linux-cifs-client-bounces+patchwork-cifs-client=patchwork.kernel.org@lists.samba.org On Fri, Jan 9, 2009 at 5:33 AM, Jeff Layton wrote: > On Thu, 8 Jan 2009 21:32:09 -0600 > "Steve French" wrote: > This patch doesn't remove any capability of the current code. It just > gets rid of this kthread that doesn't do anything useful. There's > nothing stopping us from putting it back later once we have working dir > notification, but until then it's just doing unnecessary wakeups. Al's patch removes the ability for a network or cluster file system to handle directory change notification in the future ... (AFAIK KDE, GNOME still use this fcntl) so we won't be able to fix the fcntl to work where it matters most (network or cluster environments) in the future without reverting the patch. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6badd79bd002788aaec27b50a74ab69ef65ab8ee --- a/fs/dnotify.c +++ b/fs/dnotify.c @@ -115,9 +115,6 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg) dn->dn_next = inode->i_dnotify; inode->i_dnotify = dn; spin_unlock(&inode->i_lock); - - if (filp->f_op && filp->f_op->dir_notify) - return filp->f_op->dir_notify(filp, arg); return 0;