| Message ID | 6745f869-e249-a891-8d76-79f2830dd57f@csail.mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that it >> also fixes it for him. The two attached patches for 4.9 should work. >> > > Indeed, those two patches fix the problem for me on 4.9. Thanks a lot > Steve, Pavel and Aurelien for all your efforts in fixing this! > > I was also interested in getting this fixed on 4.4, so I modified the > patches to apply on 4.4.88 and verified that they fix the mount I meant to say 4.4.122 there (the latest stable 4.4 version at the moment). Regards, Srivatsa VMware Photon OS -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 21, 2018 at 10:15:51PM -0700, Srivatsa S. Bhat wrote: > On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > > On 3/21/18 7:02 PM, Steve French wrote: > >> Found a patch which solves the dependency issue. In my testing (on > >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this > >> appears to fix the problem, but I will let Srivatsa confirm that it > >> also fixes it for him. The two attached patches for 4.9 should work. > >> > > > > Indeed, those two patches fix the problem for me on 4.9. Thanks a lot > > Steve, Pavel and Aurelien for all your efforts in fixing this! > > > > I was also interested in getting this fixed on 4.4, so I modified the > > patches to apply on 4.4.88 and verified that they fix the mount > > I meant to say 4.4.122 there (the latest stable 4.4 version at the moment). Thanks for these, all now queued up. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat <srivatsa@csail.mit.edu>: > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that it >> also fixes it for him. The two attached patches for 4.9 should work. >> > > Indeed, those two patches fix the problem for me on 4.9. Thanks a lot > Steve, Pavel and Aurelien for all your efforts in fixing this! > > I was also interested in getting this fixed on 4.4, so I modified the > patches to apply on 4.4.88 and verified that they fix the mount > failure. I have attached my patches for 4.4 with this mail. > > Steve, Pavel, could you kindly double-check the second patch for 4.4, > especially around the keygen_exit error path? The patch looks good. Thanks for the backport. -- Best regards, Pavel Shilovsky -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 84614a5..6dae5b8 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1558,6 +1558,9 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, } else iov[0].iov_len = get_rfc1002_length(req) + 4; + /* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */ + if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO) + req->hdr.Flags |= SMB2_FLAGS_SIGNED; rc = SendReceive2(xid, ses, iov, num_iovecs, &resp_buftype, 0); rsp = (struct smb2_ioctl_rsp *)iov[0].iov_base;