[net-next,4/5] net: integrate QUIC build configuration into Kconfig and Makefile

Commit Message

Xin Long Sept. 10, 2024, 2:30 a.m. UTC

This commit introduces build configurations for QUIC within the networking
subsystem. The Kconfig and Makefile files in the net directory are updated
to include options and rules necessary for building QUIC protocol support.

To enable building the QUIC module, include the following configurations
in your .config file:

  CONFIG_IP_QUIC=m
  CONFIG_IP_QUIC_TEST=m

Signed-off-by: Xin Long <[e-mail]>
Signed-off-by: Moritz Buhl <[e-mail]>
Signed-off-by: Tyler Fanelli <[e-mail]>
Signed-off-by: Pengtao He <[e-mail]>
---
 net/Kconfig  | 1 +
 net/Makefile | 1 +
 2 files changed, 2 insertions(+)

Comments

Jakub Kicinski Sept. 12, 2024, midnight UTC | #1

On Mon,  9 Sep 2024 22:30:19 -0400 Xin Long wrote:
> This commit introduces build configurations for QUIC within the networking
> subsystem. The Kconfig and Makefile files in the net directory are updated
> to include options and rules necessary for building QUIC protocol support.

Don't split out trivial config changes like this, what's the point.
It just make build testing harder.

Speaking of which, it doesn't build on 32bit:

ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined!
ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined!
ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined!

If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf
we won't have enough time to review for 6.12 even if Linus cuts -rc8.

Xin Long Sept. 12, 2024, 2:57 p.m. UTC | #2

On Wed, Sep 11, 2024 at 8:01 PM Jakub Kicinski <[e-mail]> wrote:
>
> On Mon,  9 Sep 2024 22:30:19 -0400 Xin Long wrote:
> > This commit introduces build configurations for QUIC within the networking
> > subsystem. The Kconfig and Makefile files in the net directory are updated
> > to include options and rules necessary for building QUIC protocol support.
>
> Don't split out trivial config changes like this, what's the point.
> It just make build testing harder.
I will move this to the Patch 3/5.

>
> Speaking of which, it doesn't build on 32bit:
>
> ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined!
> ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined!
> ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined!
The tests were done on x86_64, aarch64, s390x and ppc64le.
Sorry for missing 32bit machines.

>
> If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf
> we won't have enough time to review for 6.12 even if Linus cuts -rc8.
Copy that.

Thanks.

Patch

diff --git a/net/Kconfig b/net/Kconfig
index d27d0deac0bf..3bbea4138c58 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -238,6 +238,7 @@  endif
 
 source "net/dccp/Kconfig"
 source "net/sctp/Kconfig"
+source "net/quic/Kconfig"
 source "net/rds/Kconfig"
 source "net/tipc/Kconfig"
 source "net/atm/Kconfig"
diff --git a/net/Makefile b/net/Makefile
index 65bb8c72a35e..0562e72482b9 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -44,6 +44,7 @@  obj-y				+= 8021q/
 endif
 obj-$(CONFIG_IP_DCCP)		+= dccp/
 obj-$(CONFIG_IP_SCTP)		+= sctp/
+obj-$(CONFIG_IP_QUIC)		+= quic/
 obj-$(CONFIG_RDS)		+= rds/
 obj-$(CONFIG_WIRELESS)		+= wireless/
 obj-$(CONFIG_MAC80211)		+= mac80211/