diff mbox series

ksmbd: Unlock on in ksmbd_tcp_set_interfaces()

Message ID 89c440a9-27bd-45d9-9d5b-5b4bf51ec950@stanley.mountain (mailing list archive)
State New, archived
Headers show
Series ksmbd: Unlock on in ksmbd_tcp_set_interfaces() | expand

Commit Message

Dan Carpenter Aug. 29, 2024, 7:22 p.m. UTC 
Unlock before returning an error code if this allocation fails.

Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/smb/server/transport_tcp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Namjae Jeon Aug. 30, 2024, 12:23 a.m. UTC | #1 
On Fri, Aug 30, 2024 at 4:22 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Unlock before returning an error code if this allocation fails.
>
> Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Looks good to me.
Applied it to #ksmbd-for-next-next.
Thanks!
diff mbox series

Patch

diff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c
index a84788396daa..aaed9e293b2e 100644
--- a/fs/smb/server/transport_tcp.c
+++ b/fs/smb/server/transport_tcp.c
@@ -624,8 +624,10 @@  int ksmbd_tcp_set_interfaces(char *ifc_list, int ifc_list_sz)
 		for_each_netdev(&init_net, netdev) {
 			if (netif_is_bridge_port(netdev))
 				continue;
-			if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL)))
+			if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) {
+				rtnl_unlock();
 				return -ENOMEM;
+			}
 		}
 		rtnl_unlock();
 		bind_additional_ifaces = 1;