From patchwork Tue Oct 8 05:17:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 13825644 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 226F63A1CD for ; Tue, 8 Oct 2024 05:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728364643; cv=none; b=R/VjYInbyIA/Op31OiIUb0YH/7pS0PeIpWf0q0eMNbVElX0qSx1CJ/BGC46YPn2SwfLhIUZid1Ew0CzYLV+cjXjgZ/aJI+UeeWLbaSEusVRTCr4/IQYt1Jthw2omLX6Tc/SFnavI8jlJL5WFZ9ycGt7n6BU812NAMDFzDFnmG3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728364643; c=relaxed/simple; bh=V9ZruTGDai+Q3raXR/L20RKutrDpnH/wumYfIg4DLgQ=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=nFVeDTX9bJGsKhF+LtwkpCpXP3Lq5ZaYgyRU7sf+r21zQkR5Euy2Et5CH0R12DtKB6JFI8WN4nRAGxJdos0vgBteWYe+wGFZBhbpWAsG8z62H75z1SwTN2IRHRpEy3/8GMiVySK46/JxF2FbnBHUG9/GSItCOOKUqAIf2tbkxxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SHu+J4eC; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SHu+J4eC" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-53959a88668so6482077e87.2 for ; Mon, 07 Oct 2024 22:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728364640; x=1728969440; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ve1jSOXcYOj/U44yTu0kvkF8BmrgUqGzWcqMl9ze9uk=; b=SHu+J4eCNiUucmFoe+C57WOzsSPpGdd19NXqN/7qrKqgJXU3X2Hveusm9BtrZ1pygL p9x95W/z85X+yxKmOk37geqBchVXYWgBuQeWibm08ssZOFGuaxocGtW4Z4f4oMGXrU68 Kaafy65ZPjTYSidB18SkcnYuQwP6u0K6e4k8EwjTzkDFV5RHGQLYRO2BNxnxeuhMK9gp F/cVWXsWmkHTR+B0jdJrB+d6WM1aYdP4rm1DWunTEVIb4FXGPmle9DyWd6Q0Pe7lmmQ7 LSan+xPkKILbfcdIzFgZINokLzgG0KDAJ8BSIcIOGPW7FquF29M9V9ZtSawJfCp+XFeO GrtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728364640; x=1728969440; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ve1jSOXcYOj/U44yTu0kvkF8BmrgUqGzWcqMl9ze9uk=; b=OJx/h4/jj/wgjVNoMlNaIcjaKd3lHCzf3Oks8GY4yCoI9DGt0cf0seH5pNd9YKo1FW 5oCb7RkEhTX/vrmviBaiOghIM+cayBFym3v+8pGcDfzTvibB5DgousNDhTkSuLlE5LE/ H+qOlbXnyss/sCgQfg3+pGDosJ9nUTx+2MOqGVxQGuLgyE0ve4JQMEIkLTRj2xwXzL3U 0StHa0ZZUv0aSQWTGfufsi3HQy9QEYSNjPixhNj8NR0p2ufdSvInYR6iuCm+XoZOWGJ/ +VxMZ850B2uzHoECNF/6if2qmKgYZY/kOCqlmEFeqHCLZAln8aP1nfo89ZbvlfK5MJbh Qgkw== X-Gm-Message-State: AOJu0YwWp0dIM5ZvNOkjxGymWc19rbOzMi+sjP0GxNvpGe0sbp6oJK4+ x8lF2nwBLe3OqT6xX7jZA1w/7UB6w4mkfLFb+KMVH+G1fFhaMj2ACYIwi+wqFWSPqtIBvVIdggr bZDiEgBJriik0htXtyyqGUoWVtpQrkdzKw7I= X-Google-Smtp-Source: AGHT+IGSBOckqd3Hudn5DQw8zoPbtYmKTt4zSnQxq1/JPbesE+Sgch4g7Ohuhk6f/H929PFw8oY6IswTK78l3T2TlH4= X-Received: by 2002:a05:6512:3da3:b0:539:8f4d:a7dc with SMTP id 2adb3069b0e04-539ab9e2e92mr6710025e87.48.1728364639917; Mon, 07 Oct 2024 22:17:19 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Steve French Date: Tue, 8 Oct 2024 00:17:07 -0500 Message-ID: Subject: [PATCH][SMB3 client] minor updates to "stop flooding dmesg" patch To: Paulo Alcantara Cc: CIFS I was not as comfortable with taking out where the error is logged on session setup, but the other parts of the two patches below were fine. So have added them back into for-next after the one small change to " smb: client: stop flooding dmesg on failed session setups" commit e25f5175ef11a56bba4fbfc66832817d59e887c6 (HEAD -> for-next, origin/for-next) Author: Paulo Alcantara Date: Wed Sep 18 02:04:18 2024 -0300 smb: client: stop flooding dmesg with automounts Avoid logging info and expected errors when automounting DFS links and reparse mount points as a share might contain hundreds of them and the client would end up flooding dmesg. Signed-off-by: Paulo Alcantara (Red Hat) Signed-off-by: Steve French commit 2f34f5e966f7d99418b42b8c67cffbbbde94704b Author: Paulo Alcantara Date: Wed Sep 18 02:04:12 2024 -0300 smb: client: stop flooding dmesg on failed session setups Stop flooding dmesg over failed session setups as kerberos tickets getting expired or passwords being rotated is a very common scenario. Signed-off-by: Paulo Alcantara (Red Hat) Signed-off-by: Steve French From 2f34f5e966f7d99418b42b8c67cffbbbde94704b Mon Sep 17 00:00:00 2001 From: Paulo Alcantara Date: Wed, 18 Sep 2024 02:04:12 -0300 Subject: [PATCH 1/2] smb: client: stop flooding dmesg on failed session setups Stop flooding dmesg over failed session setups as kerberos tickets getting expired or passwords being rotated is a very common scenario. Signed-off-by: Paulo Alcantara (Red Hat) Signed-off-by: Steve French --- fs/smb/client/connect.c | 2 ++ fs/smb/client/smb2pdu.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c index 15d94ac4095e..48e87f3a7b24 100644 --- a/fs/smb/client/connect.c +++ b/fs/smb/client/connect.c @@ -3374,6 +3374,8 @@ int cifs_mount_get_session(struct cifs_mount_ctx *mnt_ctx) ses = cifs_get_smb_ses(server, ctx); if (IS_ERR(ses)) { rc = PTR_ERR(ses); + if (rc == -ENOKEY && ctx->sectype == Kerberos) + cifs_dbg(VFS, "Verify user has a krb5 ticket and keyutils is installed\n"); ses = NULL; goto out; } diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index b2f16a7b696d..6f7f9a1f0a1f 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -1636,8 +1636,8 @@ SMB2_auth_kerberos(struct SMB2_sess_data *sess_data) spnego_key = cifs_get_spnego_key(ses, server); if (IS_ERR(spnego_key)) { rc = PTR_ERR(spnego_key); - if (rc == -ENOKEY) - cifs_dbg(VFS, "Verify user has a krb5 ticket and keyutils is installed\n"); + cifs_dbg(FYI, "%s: couldn't auth with kerberos: %d\n", + __func__, rc); spnego_key = NULL; goto out; } -- 2.43.0