backport of missing fs/smb patches not in 6.6.30 stable

Pull-request

git://git.samba.org/ksmbd.git tags/6.6.30-rc1-full-fs-smb-backport

Message

Steve French May 3, 2024, 4:28 a.m. UTC

6.6.30-rc1 has a large set of fs/smb (cifs.ko and ksmbd.ko) patches
backported but was missing more than 30 fixes so I put together a safe
backport of the remaining, leaving out patches that had dependencies
on things outside of fs/smb

The following changes since commit 488f7008e62890fae8c7a2d3583913c8074f1fc6:

  smb3: fix lock ordering potential deadlock in cifs_sync_mid_result
(2024-04-30 12:30:53 -0500)

are available in the Git repository at:

  git://git.samba.org/ksmbd.git tags/6.6.30-rc1-full-fs-smb-backport

for you to fetch changes up to 411b6f385ac2427ee9d70fae277a4ed6b9d3983f:

  smb: smb2pdu.h: Avoid -Wflex-array-member-not-at-end warnings
(2024-05-01 02:18:25 -0500)

----------------------------------------------------------------
full backport for 6.6.30, includes all 80 (of the relevant) missing
fs/smb changesets

Test results look good (and better than without the patches).  Here
are the functional test results (they passed exhaustive set of tests
to various server types):
http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/3/builds/99
http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/5/builds/117
http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/9/builds/51
http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/10/builds/63

Note that 22 patches had dependencies and were not appropriate to
backport and are not included, but here is the list of the additional
80 fs/smb patches included, many of which fix bugs (the others reduce
risk of backport, and help avoid merge conflicts):
411b6f385ac2 (HEAD -> fs-smb-backport-linux-6.6.30-rc1, tag:
6.6.30-rc1-full-fs-smb-backport,
origin/fs-smb-backport-linux-6.6.30-rc1) smb: smb2pdu.h: Avoid
-Wflex-array-member-not-at-end warnings
e97b85914501 ksmbd: add continuous availability share parameter
c52ce70edb58 cifs: Add tracing for the cifs_tcon struct refcounting
6fa6d5ed6a06 smb3: fix broken reconnect when password changing on the
server by allowing password rotation
d8833245b0f3 smb: client: instantiate when creating SFU files
4c8cf606bdb9 smb: client: fix NULL ptr deref in
cifs_mark_open_handles_for_deleted_file()
e0727528f3be smb3: add trace event for mknod
b71e6511fa98 smb311: additional compression flag defined in updated
protocol spec
0725c800685e smb311: correct incorrect offset field in compression header
e25e2f027599 cifs: Move some extern decls from .c files to .h
0d422616d36e ksmbd: fix potencial out-of-bounds when buffer offset is invalid
3967f3e18d66 ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
aec926736509 ksmbd: Fix spelling mistake "connction" -> "connection"
43f609cc80a5 ksmbd: fix possible null-deref in smb_lazy_parent_lease_break_close
3f1a838bc984 cifs: remove redundant variable assignment
05415df6229c cifs: fixes for get_inode_info
025b6f60cccc cifs: defer close file handles having RH lease
f1907205b6d3 ksmbd: add support for durable handles v1/v2
38b6f9391d64 ksmbd: mark SMB2_SESSION_EXPIRED to session when
destroying previous session
5ab62e6d22d1 cifs: update internal module version number for cifs.ko
4dcd0fe0c185 smb: common: simplify compression headers
0409ad4bad2b smb: common: fix fields sizes in compression_pattern_payload_v1
25fc3d85adc6 smb: client: negotiate compression algorithms
f3351838c269 smb3: add dynamic trace point for ioctls
7716c6db1c3b smb: client: return reparse type in /proc/mounts
1c3fbd8f92e9 smb: client: set correct d_type for reparse DFS/DFSR and
mount point
555e4ef34991 smb: client: parse uid, gid, mode and dev from WSL reparse points
5232c56b469f smb: client: introduce SMB2_OP_QUERY_WSL_EA
2bcfc0b089f7 smb: client: Fix a NULL vs IS_ERR() check in wsl_set_xattrs()
7ef14e642141 smb: client: add support for WSL reparse points
324c9dc5ab0b smb: client: reduce number of parameters in smb2_compound_op()
8b52dc432b0a smb: client: fix potential broken compound request
8f22fd9f0396 smb: client: move most of reparse point handling code to
common file
0ddb5bfd6f20 smb: client: introduce reparse mount option
370c2c605121 smb: client: retry compound request without reusing lease
6051d1b018ea smb: client: do not defer close open handles to deleted files
6a9d47b768c4 smb: client: reuse file lease key in compound operations
87eec3c54337 smb: client: get rid of smb311_posix_query_path_info()
32fab0e3e9b9 smb: client: parse owner/group when creating reparse points
df9a4c3f5db4 smb3: update allocation size more accurately on write completion
4d7263b3bf67 smb: client: handle path separator of created SMB symlinks
bd15b21c46c1 cifs: update the same create_guid on replay
6feda182ccf0 ksmbd: Add kernel-doc for ksmbd_extract_sharename() function
a12c76c3f311 cifs: set replay flag for retries of write command
e0a86c86ec5f cifs: commands that are retried should have replay flag set
207e9813ad88 smb: client: delete "true", "false" defines
6eb8a67757c6 smb: Fix some kernel-doc comments
3c21bffee62f cifs: new mount option called retrans
005892f2a944 smb: client: don't clobber ->i_rdev from cached reparse points
222edc9359a6 cifs: new nt status codes from MS-SMB2
80e719af52b9 cifs: pick channel for tcon and tdis
56c978ef1555 cifs: minor comment cleanup
6008da8e76ac cifs: remove redundant variable tcon_exist
95d9120fd9b0 cifs: update internal module version number for cifs.ko
2bbd03ad1d98 ksmbd: vfs: fix all kernel-doc warnings
0988e25500d0 ksmbd: auth: fix most kernel-doc warnings
9198cebadcef cifs: remove unneeded return statement
2b8222b46d92 cifs: get rid of dup length check in parse_reparse_point()
a1975468bc0d cifs: Pass unbyteswapped eof value into SMB2_set_eof()
b312f2d94a42 smb3: Improve exception handling in allocate_mr_list()
b6a02523d103 cifs: fix in logging in cifs_chan_update_iface
f7e60be64713 smb: client: handle special files and symlinks in SMB3 POSIX
2f68be9f5e9d smb: client: cleanup smb2_query_reparse_point()
eed182ebb134 smb: client: allow creating symlinks via reparse points
95c6eac76fa5 smb: client: optimise reparse point querying
8dbc76e94b4b smb: client: allow creating special files via reparse points
a5a4a5bc172b smb: client: extend smb2_compound_op() to accept more commands
778c2e03cbf4 smb: client: Fix minor whitespace errors and warnings
757f636f8fb0 smb: client: introduce cifs_sfu_make_node()
52740954fa81 cifs: fix use after free for iface while disabling
secondary channels
789f47984ddf cifs: update internal module version number for cifs.ko
120608af2863 Missing field not being returned in ioctl CIFS_IOC_GET_MNT_INFO
d1e9469bb4de smb3: minor cleanup of session handling code
09f7cf2bba1b smb3: more minor cleanups for session handling routines
6e19e4e86f02 smb3: minor RDMA cleanup
d73d7f8d1faa cifs: print server capabilities in DebugData
a88a5c2bf942 smb: use crypto_shash_digest() in symlink_hash()
56ad4435b30b Add definition for new smb3.1.1 command type
5900e9b37aa2 SMB3: clarify some of the unused CreateOption flags
fdf07b15f7d7 cifs: Add client version details to NTLM authenticate message

Comments

Sasha Levin May 6, 2024, 11:11 p.m. UTC | #1

On Thu, May 02, 2024 at 11:28:38PM -0500, Steve French wrote:
>6.6.30-rc1 has a large set of fs/smb (cifs.ko and ksmbd.ko) patches
>backported but was missing more than 30 fixes so I put together a safe
>backport of the remaining, leaving out patches that had dependencies
>on things outside of fs/smb
>
>The following changes since commit 488f7008e62890fae8c7a2d3583913c8074f1fc6:
>
>  smb3: fix lock ordering potential deadlock in cifs_sync_mid_result
>(2024-04-30 12:30:53 -0500)
>
>are available in the Git repository at:
>
>  git://git.samba.org/ksmbd.git tags/6.6.30-rc1-full-fs-smb-backport
>
>for you to fetch changes up to 411b6f385ac2427ee9d70fae277a4ed6b9d3983f:
>
>  smb: smb2pdu.h: Avoid -Wflex-array-member-not-at-end warnings
>(2024-05-01 02:18:25 -0500)
>
>----------------------------------------------------------------
>full backport for 6.6.30, includes all 80 (of the relevant) missing
>fs/smb changesets
>
>Test results look good (and better than without the patches).  Here
>are the functional test results (they passed exhaustive set of tests
>to various server types):
>http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/3/builds/99
>http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/5/builds/117
>http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/9/builds/51
>http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/10/builds/63
>
>Note that 22 patches had dependencies and were not appropriate to
>backport and are not included, but here is the list of the additional
>80 fs/smb patches included, many of which fix bugs (the others reduce
>risk of backport, and help avoid merge conflicts):
>411b6f385ac2 (HEAD -> fs-smb-backport-linux-6.6.30-rc1, tag:
>6.6.30-rc1-full-fs-smb-backport,
>origin/fs-smb-backport-linux-6.6.30-rc1) smb: smb2pdu.h: Avoid
>-Wflex-array-member-not-at-end warnings

Thanks Steve, I'll pick these up.

In the future, if the patches don't need massaging, just a list of the
upstream commit ids would be great :)