diff mbox

CIFS: session servername can't be null

Message ID CAH2r5mvEfJLo_zM0bYfxoHo=MLoUZUvVce-4ShiqXKr9qWOf0g@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve French March 31, 2015, 12:07 a.m. UTC 
(updated incorporating a suggestion of Jeff's)

remove impossible check

Pointed out by Coverity (CID 115422)

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
---
 fs/cifs/cifsencrypt.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

         server = kmalloc(2 + (len * 2), GFP_KERNEL);
diff mbox

Patch

diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index 4ac7445..aa0dc25 100644
--- a/fs/cifs/cifsencrypt.c
+++ b/fs/cifs/cifsencrypt.c
@@ -1,6 +1,9 @@ 
 /*
  *   fs/cifs/cifsencrypt.c
  *
+ *   Encryption and hashing operations relating to NTLM, NTLMv2.  See MS-NLMP
+ *   for more detailed information
+ *
  *   Copyright (C) International Business Machines  Corp., 2005,2013
  *   Author(s): Steve French (sfrench@us.ibm.com)
  *
@@ -515,7 +518,8 @@  static int calc_ntlmv2_hash(struct cifs_ses *ses,
char *ntlmv2_hash,
                  __func__);
             return rc;
         }
-    } else if (ses->serverName) {
+    } else {
+        /* We use ses->serverName if no domain name available */
         len = strlen(ses->serverName);