diff mbox series

[SMB,client] fix typo in description of enable_gcm_256 module load parameter

Message ID CAH2r5mviMs7VW5ofa0hZiVkx6RdH-LcnpYYDhyGOxnXxtB=t=A@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series [SMB,client] fix typo in description of enable_gcm_256 module load parameter | expand

Commit Message

Steve French June 19, 2024, 8:02 p.m. UTC
enable_gcm_256 (which allows the server to require the strongest
encryption) is enabled by default (in the 5.13 kernel and later), but
the modinfo description
incorrectly showed it disabled by default. Fix the typo.

Cc: stable@vger.kernel.org
Fixes: fee742b50289 ("smb3.1.1: enable negotiating stronger encryption
by default")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/smb/client/cifsfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 module_param(require_gcm_256, bool, 0644);
 MODULE_PARM_DESC(require_gcm_256, "Require strongest (256 bit) GCM
encryption. Default: n/N/0");

Comments

Paul Aurich June 20, 2024, 4:43 a.m. UTC | #1
'0' is probably also a typo.

On 2024-06-19 15:02:16 -0500, Steve French wrote:
>enable_gcm_256 (which allows the server to require the strongest
>encryption) is enabled by default (in the 5.13 kernel and later), but
>the modinfo description
>incorrectly showed it disabled by default. Fix the typo.
>
>Cc: stable@vger.kernel.org
>Fixes: fee742b50289 ("smb3.1.1: enable negotiating stronger encryption
>by default")
>Signed-off-by: Steve French <stfrench@microsoft.com>
>---
> fs/smb/client/cifsfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
>index bb86fc0641d8..6397fdefd876 100644
>--- a/fs/smb/client/cifsfs.c
>+++ b/fs/smb/client/cifsfs.c
>@@ -134,7 +134,7 @@ module_param(enable_oplocks, bool, 0644);
> MODULE_PARM_DESC(enable_oplocks, "Enable or disable oplocks. Default: y/Y/1");
>
> module_param(enable_gcm_256, bool, 0644);
>-MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256
>bit) GCM encryption. Default: n/N/0");
>+MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256
>bit) GCM encryption. Default: y/Y/0");

"y/Y/1"

> module_param(require_gcm_256, bool, 0644);
> MODULE_PARM_DESC(require_gcm_256, "Require strongest (256 bit) GCM
>encryption. Default: n/N/0");
>
>-- 
>Thanks,
>
>Steve

>From c37640c69574b424e687c4e3fac15c8c2a9343d5 Mon Sep 17 00:00:00 2001
>From: Steve French <stfrench@microsoft.com>
>Date: Wed, 19 Jun 2024 14:46:48 -0500
>Subject: [PATCH] cifs: fix typos in module parameter enable_gcm_256
>
>enable_gcm_256 (which allows the server to require the strongest
>encryption) is enabled by default, but the modinfo description
>incorrectly showed it disabled by default. Fix the typo.
>
>Cc: stable@vger.kernel.org
>Fixes: fee742b50289 ("smb3.1.1: enable negotiating stronger encryption by default")
>Signed-off-by: Steve French <stfrench@microsoft.com>
>---
> fs/smb/client/cifsfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
>index bb86fc0641d8..6397fdefd876 100644
>--- a/fs/smb/client/cifsfs.c
>+++ b/fs/smb/client/cifsfs.c
>@@ -134,7 +134,7 @@ module_param(enable_oplocks, bool, 0644);
> MODULE_PARM_DESC(enable_oplocks, "Enable or disable oplocks. Default: y/Y/1");
> 
> module_param(enable_gcm_256, bool, 0644);
>-MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256 bit) GCM encryption. Default: n/N/0");
>+MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256 bit) GCM encryption. Default: y/Y/0");
> 
> module_param(require_gcm_256, bool, 0644);
> MODULE_PARM_DESC(require_gcm_256, "Require strongest (256 bit) GCM encryption. Default: n/N/0");
>-- 
>2.43.0
>
diff mbox series

Patch

From c37640c69574b424e687c4e3fac15c8c2a9343d5 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Wed, 19 Jun 2024 14:46:48 -0500
Subject: [PATCH] cifs: fix typos in module parameter enable_gcm_256

enable_gcm_256 (which allows the server to require the strongest
encryption) is enabled by default, but the modinfo description
incorrectly showed it disabled by default. Fix the typo.

Cc: stable@vger.kernel.org
Fixes: fee742b50289 ("smb3.1.1: enable negotiating stronger encryption by default")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/smb/client/cifsfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index bb86fc0641d8..6397fdefd876 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -134,7 +134,7 @@  module_param(enable_oplocks, bool, 0644);
 MODULE_PARM_DESC(enable_oplocks, "Enable or disable oplocks. Default: y/Y/1");
 
 module_param(enable_gcm_256, bool, 0644);
-MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256 bit) GCM encryption. Default: n/N/0");
+MODULE_PARM_DESC(enable_gcm_256, "Enable requesting strongest (256 bit) GCM encryption. Default: y/Y/0");
 
 module_param(require_gcm_256, bool, 0644);
 MODULE_PARM_DESC(require_gcm_256, "Require strongest (256 bit) GCM encryption. Default: n/N/0");
-- 
2.43.0