diff mbox series

[SMB3] fix noisy error message logged on cross share copy_file_range

Message ID CAH2r5mvmbQDendkfH+kZuzx_xzqBqwHf1=fZR_vsY7PA4=sOhg@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series [SMB3] fix noisy error message logged on cross share copy_file_range | expand

Commit Message

Steve French July 17, 2024, 5:50 a.m. UTC
There are common cases where copy_file_range can noisily
    log "source and target of copy not on same server"
    e.g. the mv command across mounts to two different server's shares.
    Change this to informational rather than logging as an error.

    A followon patch will add dynamic trace points e.g. for
    cifs_file_copychunk_range
diff mbox series

Patch

From bb367fbd3f01935bb7c754c411424d1dc49772fd Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Wed, 17 Jul 2024 00:42:22 -0500
Subject: [PATCH] cifs: fix noisy message on copy_file_range

There are common cases where copy_file_range can noisily
log "source and target of copy not on same server"
e.g. the mv command across mounts to two different server's shares.
Change this to informational rather than logging as an error.

A followon patch will add dynamic trace points e.g. for
cifs_file_copychunk_range

Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/smb/client/cifsfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index 6397fdefd876..c92937bed133 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -1359,7 +1359,7 @@  ssize_t cifs_file_copychunk_range(unsigned int xid,
 	target_tcon = tlink_tcon(smb_file_target->tlink);
 
 	if (src_tcon->ses != target_tcon->ses) {
-		cifs_dbg(VFS, "source and target of copy not on same server\n");
+		cifs_dbg(FYI, "source and target of copy not on same server\n");
 		goto out;
 	}
 
-- 
2.43.0