Message ID | 20200819163634.5430-1-biju.das.jz@bp.renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | Support RZ/G2[MN] rev4 board | expand |
Hi! > This patch series for supporting RZ/G2[MN] rev4 board to cip-4.19.y > kernel. > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 11 ----------- > 1 file changed, 11 deletions(-) I'm pretty sure this is not the real diffstat. Let me go through the changes. One concern: you are renaming dts files. New names make a lot of sense, but that will likely break the users, including our test infrastructure, no? Best regards, Pavel
Hello Pavel, > From: Pavel Machek <pavel@denx.de> > Sent: 19 August 2020 18:39 > > *** gpg4o | The signature of this email could not be verified because the > following public key is missing. Click here to search and import the key > 30E7F06A95DBFAF2 *** > > Hi! > > > This patch series for supporting RZ/G2[MN] rev4 board to cip-4.19.y > > kernel. > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 11 ----------- > > 1 file changed, 11 deletions(-) > > I'm pretty sure this is not the real diffstat. > > Let me go through the changes. One concern: you are renaming dts > files. New names make a lot of sense, but that will likely break the > users, including our test infrastructure, no? Technically yes, it would cause problems. However this seems to be the way of doing things upstream. I guess upstream is a bit different though as users would expect such things when upgrading Kernel versions. For SLTS perhaps users wouldn't expect to see such changes? It may be easier to keep things in sync with upstream though. FYI the "rev4" dts does actually boot on "rev2" boards. It's just that some functionality like WiFi/BT and audio won't work. (and the rev2 dts will boot on rev4 boards) lab-cip-renesas uses rev4 boards, so from a CIP testing point of view there will be no issues. Kind regards, Chris > > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5162): https://lists.cip-project.org/g/cip-dev/message/5162 Mute This Topic: https://lists.cip-project.org/mt/76290780/4520428 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy [patchwork-cip-dev@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi! > > *** gpg4o | The signature of this email could not be verified because the > > following public key is missing. Click here to search and import the key > > 30E7F06A95DBFAF2 *** > > > > Hi! > > > > > This patch series for supporting RZ/G2[MN] rev4 board to cip-4.19.y > > > kernel. > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 11 ----------- > > > 1 file changed, 11 deletions(-) > > > > I'm pretty sure this is not the real diffstat. > > > > Let me go through the changes. One concern: you are renaming dts > > files. New names make a lot of sense, but that will likely break the > > users, including our test infrastructure, no? > Technically yes, it would cause problems. However this seems to be > the way of doing things upstream. I guess upstream is a bit > different though as users would expect such things when upgrading > Kernel versions. Yes, it is upstream problem, and should be fixed upstream. And no, not even upgrading kernel versions should break anything. > lab-cip-renesas uses rev4 boards, so from a CIP testing point of > view there will be no issues. Ok, good to know, it seems -rev2 boards are kind of rare? I guess we could create "README.cip" explaining such non-standard issues, and mention it in release changelog. Best regards, Pavel
Hi, > -----Original Message----- > From: Pavel Machek [mailto:pavel@denx.de] > Sent: Monday, August 24, 2020 4:38 AM > To: cip-dev@lists.cip-project.org > Cc: Pavel Machek <pavel@denx.de>; Biju Das <biju.das.jz@bp.renesas.com>; iwamatsu nobuhiro(岩松 信洋 □SWC◯A > CT) <nobuhiro1.iwamatsu@toshiba.co.jp>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Subject: Re: [cip-dev] [PATCH 4.19.y-cip 00/12] Support RZ/G2[MN] rev4 board > > Hi! > > > > *** gpg4o | The signature of this email could not be verified because the > > > following public key is missing. Click here to search and import the key > > > 30E7F06A95DBFAF2 *** > > > > > > Hi! > > > > > > > This patch series for supporting RZ/G2[MN] rev4 board to cip-4.19.y > > > > kernel. > > > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 11 ----------- > > > > 1 file changed, 11 deletions(-) > > > > > > I'm pretty sure this is not the real diffstat. > > > > > > Let me go through the changes. One concern: you are renaming dts > > > files. New names make a lot of sense, but that will likely break the > > > users, including our test infrastructure, no? > > > Technically yes, it would cause problems. However this seems to be > > the way of doing things upstream. I guess upstream is a bit > > different though as users would expect such things when upgrading > > Kernel versions. > > Yes, it is upstream problem, and should be fixed upstream. > > And no, not even upgrading kernel versions should break anything. > > > lab-cip-renesas uses rev4 boards, so from a CIP testing point of > > view there will be no issues. > > Ok, good to know, it seems -rev2 boards are kind of rare? > > I guess we could create "README.cip" explaining such non-standard > issues, and mention it in release changelog. Or I think we can do this by including more information on the reference hardware and test information on CIP wiki. > > Best regards, > Pavel Best regards, Nobuhiro > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5234): https://lists.cip-project.org/g/cip-dev/message/5234 Mute This Topic: https://lists.cip-project.org/mt/76290780/4520428 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy [patchwork-cip-dev@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-