[v3,4.19.y-cip,00/17] Add Renesas RPC-IF driver

Message

Lad Prabhakar Jan. 5, 2021, 1:57 p.m. UTC

Hi Nobuhiro, Pavel,

This patch series adds SPI driver for the Renesas RPC-IF.
Alongside relevant changes for spi-mem have been also backported.
This enables accessing SPI flash chip connected to RPC-IF.

The series includes just the driver changes as the DTS/i changes are
currently being upstreamed [1]. The driver has been tested on RZ/G2{EM}
with all the required dts/i changes [2].

All the patches have been cherry picked from Linux 5.11-rc2.

[1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=408139
[2] https://github.com/prabhakarlad/cip/commits/master

Cheers,
Prabhakar

Boris Brezillon (5):
  spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
  spi: spi-mem: Split spi_mem_exec_op() code
  spi: spi-mem: Add a new API to support direct mapping
  spi: spi-mem: Fix spi_mem_dirmap_destroy() kerneldoc
  spi: spi-mem: Fix a memory leak in spi_mem_dirmap_destroy()

Lad Prabhakar (4):
  memory: renesas-rpc-if: Return correct value to the caller of
    rpcif_manual_xfer()
  memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
    rpcif_{enable,disable}_rpm
  memory: renesas-rpc-if: Fix a node reference leak in rpcif_probe()
  memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
    inline

Lukas Wunner (1):
  spi: rpc-if: Fix use-after-free on unbind

Naga Sureshkumar Relli (1):
  spi: spi-mem: export spi_mem_default_supports_op()

Sergei Shtylyov (3):
  dt-bindings: memory: document Renesas RPC-IF bindings
  memory: add Renesas RPC-IF driver
  spi: add Renesas RPC-IF driver

Tudor Ambarus (1):
  spi: spi-mem: Compute length only when needed

YueHaibing (1):
  spi: spi-mem: Fix passing zero to 'PTR_ERR' warning

Zhang Qilong (1):
  spi: spi-mem: fix reference leak in spi_mem_access_start

 .../memory-controllers/renesas,rpc-if.yaml    |  88 +++
 drivers/memory/Kconfig                        |   9 +
 drivers/memory/Makefile                       |   1 +
 drivers/memory/renesas-rpc-if.c               | 593 ++++++++++++++++++
 drivers/spi/Kconfig                           |   6 +
 drivers/spi/Makefile                          |   1 +
 drivers/spi/spi-mem.c                         | 282 ++++++++-
 drivers/spi/spi-rpc-if.c                      | 211 +++++++
 include/linux/spi/spi-mem.h                   |  93 +++
 include/memory/renesas-rpc-if.h               |  96 +++
 10 files changed, 1353 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
 create mode 100644 drivers/memory/renesas-rpc-if.c
 create mode 100644 drivers/spi/spi-rpc-if.c
 create mode 100644 include/memory/renesas-rpc-if.h

Comments

Pavel Machek Jan. 5, 2021, 5:04 p.m. UTC | #1

Hi!

> This patch series adds SPI driver for the Renesas RPC-IF.
> Alongside relevant changes for spi-mem have been also backported.
> This enables accessing SPI flash chip connected to RPC-IF.
> 
> The series includes just the driver changes as the DTS/i changes are
> currently being upstreamed [1]. The driver has been tested on RZ/G2{EM}
> with all the required dts/i changes [2].
> 
> All the patches have been cherry picked from Linux 5.11-rc2.

Thanks, series looks good. I commented on the individual patches, but
all but one are cleanup suggestions, not bugs spotted.

Tests do not show anything bad:

https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/237669839

(but we don't have the driver enabled in our configs..)

I believe this can go in. I can apply it if there are no other
comments.

Best regards,
								Pavel