Message ID | 20210309163656.20944-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support | expand |
Hi! I had some minor comments, but the series looks good; I guess we don't need to delay applying. Some of the patches are not in 5.10, so we'll need them in cip 5.10 branch, too? Let me do some testing. Best regards, Pavel
Hi! > This patch series does the following: > * Drops unneeded regulator setup for OV5645 sensor > * Adds driver for IMX219 sensor > * Updates v4l2-async to accept endpoints for fwnode matching > * Various fixes for R-Car VIN driver > * Support to capture RAW format to VIN driver > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > enable VIN, CSI2 modules and OV5645, IMX219 sensors. Well... test are okay, except that Renesas lab is offline so it was not really tested on Renesas targets. Anyway, I guess I'm okay with applying these if there are no other comments. Best regards, Pavel
Hi, > -----Original Message----- > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > Sent: Wednesday, March 10, 2021 1:36 AM > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > Cc: Biju Das <biju.das.jz@bp.renesas.com> > Subject: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support > > Hi All, > > This patch series does the following: > * Drops unneeded regulator setup for OV5645 sensor > * Adds driver for IMX219 sensor > * Updates v4l2-async to accept endpoints for fwnode matching > * Various fixes for R-Car VIN driver > * Support to capture RAW format to VIN driver > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > enable VIN, CSI2 modules and OV5645, IMX219 sensors. > I reviewed this series, I didn't see any major problems. As Paval points out, the Renesas lab is now stopped. If this recovers and the target hardware test is okay, I would apply this. > Cheers, > Prabhakar Best regards, Nobuhiro > > Andrey Konovalov (1): > media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > Biju Das (10): > media: dt-bindings: media: rcar_vin: Add r8a774a1 support > media: rcar-vin: Enable support for r8a774a1 > media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > media: rcar-csi2: Enable support for r8a774a1 > arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes > media: dt-bindings: rcar-vin: Add R8A774B1 support > media: rcar-vin: Enable support for R8A774B1 > media: dt-bindings: rcar-csi2: Add R8A774B1 support > media: rcar-csi2: Enable support for R8A774B1 > arm64: dts: renesas: r8a774b1: Add VIN and CSI-2 support > > Dafna Hirschfeld (1): > media: i2c: imx219: Fix a bug in imx219_enum_frame_size > > Dave Stevenson (1): > media: i2c: Add driver for Sony IMX219 sensor > > Fabio Estevam (1): > media: ov5645: Remove unneeded regulator_set_voltage() > > Hans Verkuil (2): > media: i2c: imx219: Selection compliance fixes > media: i2c: imx219: take lock in imx219_enum_mbus_code/frame_size > > Jacopo Mondi (1): > media: i2c: imx219: Implement get_selection > > Lad Prabhakar (16): > media: rcar-vin: Invalidate pipeline if conversion is not possible on > input formats > media: rcar-vin: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > media: rcar-csi2: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > media: i2c: imx219: Fix power sequence > media: i2c: imx219: Add support for RAW8 bit bayer format > media: i2c: imx219: Add support for cropped 640x480 resolution > arm64: dts: renesas: r8a774c0-cat874: Add support for AISTARVISION > MIPI Adapter V2.1 > media: dt-bindings: media: renesas,vin: Add R8A774E1 support > media: rcar-vin: Enable support for R8A774E1 > media: dt-bindings: media: renesas,csi2: Add R8A774E1 support > media: rcar-csi2: Enable support for R8A774E1 > arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro > for each sensor > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > HiHope RZ/G2H > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > HiHope RZ/G2M > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > HiHope RZ/G2N > > Laurent Pinchart (4): > media: device property: Add a function to test is a fwnode is a graph > endpoint > media: v4l2-async: Accept endpoints and devices for fwnode matching > media: v4l2-async: Pass notifier pointer to match functions > media: v4l2-async: Log message in case of heterogeneous fwnode match > > Niklas Söderlund (2): > media: rcar-vin: fix wrong return value in rvin_set_channel_routing() > media: rcar-csi2: Update V3M and E3 start procedure > > Sakari Ailus (1): > media: v4l: ctrl: Provide unlocked variant of v4l2_ctrl_grab > > .../devicetree/bindings/media/i2c/imx219.yaml | 114 ++ > .../devicetree/bindings/media/rcar_vin.txt | 3 + > .../bindings/media/renesas,rcar-csi2.txt | 3 + > MAINTAINERS | 8 + > arch/arm64/boot/dts/renesas/Makefile | 10 +- > .../aistarvision-mipi-adapter-2.1.dtsi | 96 + > ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ > .../r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts | 29 + > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++ > .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts | 16 + > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 366 ++++ > .../dts/renesas/r8a774c0-ek874-mipi-2.1.dts | 73 + > .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 + > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 334 ++++ > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx219.c | 1582 +++++++++++++++++ > drivers/media/i2c/ov5645.c | 28 - > drivers/media/platform/rcar-vin/rcar-core.c | 49 + > drivers/media/platform/rcar-vin/rcar-csi2.c | 23 +- > drivers/media/platform/rcar-vin/rcar-dma.c | 17 +- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 + > drivers/media/v4l2-core/v4l2-async.c | 83 +- > drivers/media/v4l2-core/v4l2-ctrls.c | 8 +- > include/linux/property.h | 5 + > include/media/v4l2-ctrls.h | 26 +- > 26 files changed, 3330 insertions(+), 51 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx219.yaml > create mode 100644 arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > create mode 100644 arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts > create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts > create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts > create mode 100644 drivers/media/i2c/imx219.c > > -- > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6263): https://lists.cip-project.org/g/cip-dev/message/6263 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Pavel, Nobuhiro, > -----Original Message----- > From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp> > Sent: 10 March 2021 08:08 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; cip-dev@lists.cip-project.org; > pavel@denx.de > Cc: Biju Das <biju.das.jz@bp.renesas.com> > Subject: RE: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support > > Hi, > > > -----Original Message----- > > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > > Sent: Wednesday, March 10, 2021 1:36 AM > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > > Cc: Biju Das <biju.das.jz@bp.renesas.com> > > Subject: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support > > > > Hi All, > > > > This patch series does the following: > > * Drops unneeded regulator setup for OV5645 sensor > > * Adds driver for IMX219 sensor > > * Updates v4l2-async to accept endpoints for fwnode matching > > * Various fixes for R-Car VIN driver > > * Support to capture RAW format to VIN driver > > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > > enable VIN, CSI2 modules and OV5645, IMX219 sensors. > > > > I reviewed this series, I didn't see any major problems. Thank you for the review. > As Paval points out, the Renesas lab is now stopped. > If this recovers and the target hardware test is okay, I would apply this. I have informed Chris about this. Cheers, Prabhakar > > Cheers, > > Prabhakar > > Best regards, > Nobuhiro > > > > > > Andrey Konovalov (1): > > media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > > > Biju Das (10): > > media: dt-bindings: media: rcar_vin: Add r8a774a1 support > > media: rcar-vin: Enable support for r8a774a1 > > media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > media: rcar-csi2: Enable support for r8a774a1 > > arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes > > media: dt-bindings: rcar-vin: Add R8A774B1 support > > media: rcar-vin: Enable support for R8A774B1 > > media: dt-bindings: rcar-csi2: Add R8A774B1 support > > media: rcar-csi2: Enable support for R8A774B1 > > arm64: dts: renesas: r8a774b1: Add VIN and CSI-2 support > > > > Dafna Hirschfeld (1): > > media: i2c: imx219: Fix a bug in imx219_enum_frame_size > > > > Dave Stevenson (1): > > media: i2c: Add driver for Sony IMX219 sensor > > > > Fabio Estevam (1): > > media: ov5645: Remove unneeded regulator_set_voltage() > > > > Hans Verkuil (2): > > media: i2c: imx219: Selection compliance fixes > > media: i2c: imx219: take lock in imx219_enum_mbus_code/frame_size > > > > Jacopo Mondi (1): > > media: i2c: imx219: Implement get_selection > > > > Lad Prabhakar (16): > > media: rcar-vin: Invalidate pipeline if conversion is not possible on > > input formats > > media: rcar-vin: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > media: rcar-csi2: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > media: i2c: imx219: Fix power sequence > > media: i2c: imx219: Add support for RAW8 bit bayer format > > media: i2c: imx219: Add support for cropped 640x480 resolution > > arm64: dts: renesas: r8a774c0-cat874: Add support for AISTARVISION > > MIPI Adapter V2.1 > > media: dt-bindings: media: renesas,vin: Add R8A774E1 support > > media: rcar-vin: Enable support for R8A774E1 > > media: dt-bindings: media: renesas,csi2: Add R8A774E1 support > > media: rcar-csi2: Enable support for R8A774E1 > > arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro > > for each sensor > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2H > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2M > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2N > > > > Laurent Pinchart (4): > > media: device property: Add a function to test is a fwnode is a graph > > endpoint > > media: v4l2-async: Accept endpoints and devices for fwnode matching > > media: v4l2-async: Pass notifier pointer to match functions > > media: v4l2-async: Log message in case of heterogeneous fwnode match > > > > Niklas Söderlund (2): > > media: rcar-vin: fix wrong return value in rvin_set_channel_routing() > > media: rcar-csi2: Update V3M and E3 start procedure > > > > Sakari Ailus (1): > > media: v4l: ctrl: Provide unlocked variant of v4l2_ctrl_grab > > > > .../devicetree/bindings/media/i2c/imx219.yaml | 114 ++ > > .../devicetree/bindings/media/rcar_vin.txt | 3 + > > .../bindings/media/renesas,rcar-csi2.txt | 3 + > > MAINTAINERS | 8 + > > arch/arm64/boot/dts/renesas/Makefile | 10 +- > > .../aistarvision-mipi-adapter-2.1.dtsi | 96 + > > ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ > > .../r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts | 29 + > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++ > > .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts | 16 + > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 366 ++++ > > .../dts/renesas/r8a774c0-ek874-mipi-2.1.dts | 73 + > > .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 + > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 334 ++++ > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx219.c | 1582 +++++++++++++++++ > > drivers/media/i2c/ov5645.c | 28 - > > drivers/media/platform/rcar-vin/rcar-core.c | 49 + > > drivers/media/platform/rcar-vin/rcar-csi2.c | 23 +- > > drivers/media/platform/rcar-vin/rcar-dma.c | 17 +- > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 + > > drivers/media/v4l2-core/v4l2-async.c | 83 +- > > drivers/media/v4l2-core/v4l2-ctrls.c | 8 +- > > include/linux/property.h | 5 + > > include/media/v4l2-ctrls.h | 26 +- > > 26 files changed, 3330 insertions(+), 51 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx219.yaml > > create mode 100644 arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > > create mode 100644 arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts > > create mode 100644 drivers/media/i2c/imx219.c > > > > -- > > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6269): https://lists.cip-project.org/g/cip-dev/message/6269 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hello Pavel, Iwamatsu-san, > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On > Behalf Of Nobuhiro Iwamatsu via lists.cip-project.org > Sent: 10 March 2021 08:08 > > Hi, > > > -----Original Message----- > > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > > Sent: Wednesday, March 10, 2021 1:36 AM > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 > □SWC◯ACT) > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > > Cc: Biju Das <biju.das.jz@bp.renesas.com> > > Subject: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 > support > > > > Hi All, > > > > This patch series does the following: > > * Drops unneeded regulator setup for OV5645 sensor > > * Adds driver for IMX219 sensor > > * Updates v4l2-async to accept endpoints for fwnode matching > > * Various fixes for R-Car VIN driver > > * Support to capture RAW format to VIN driver > > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > > enable VIN, CSI2 modules and OV5645, IMX219 sensors. > > > > I reviewed this series, I didn't see any major problems. > As Paval points out, the Renesas lab is now stopped. > If this recovers and the target hardware test is okay, I would apply this. Sorry about the lab-cip-renesas issues. The lab will probably be offline until next week. I'm happy for this series to be delayed until it's tested if that's what you'd prefer. Kind regards, Chris > > Cheers, > > Prabhakar > > Best regards, > Nobuhiro > > > > > > Andrey Konovalov (1): > > media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > > > Biju Das (10): > > media: dt-bindings: media: rcar_vin: Add r8a774a1 support > > media: rcar-vin: Enable support for r8a774a1 > > media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > media: rcar-csi2: Enable support for r8a774a1 > > arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes > > media: dt-bindings: rcar-vin: Add R8A774B1 support > > media: rcar-vin: Enable support for R8A774B1 > > media: dt-bindings: rcar-csi2: Add R8A774B1 support > > media: rcar-csi2: Enable support for R8A774B1 > > arm64: dts: renesas: r8a774b1: Add VIN and CSI-2 support > > > > Dafna Hirschfeld (1): > > media: i2c: imx219: Fix a bug in imx219_enum_frame_size > > > > Dave Stevenson (1): > > media: i2c: Add driver for Sony IMX219 sensor > > > > Fabio Estevam (1): > > media: ov5645: Remove unneeded regulator_set_voltage() > > > > Hans Verkuil (2): > > media: i2c: imx219: Selection compliance fixes > > media: i2c: imx219: take lock in imx219_enum_mbus_code/frame_size > > > > Jacopo Mondi (1): > > media: i2c: imx219: Implement get_selection > > > > Lad Prabhakar (16): > > media: rcar-vin: Invalidate pipeline if conversion is not possible on > > input formats > > media: rcar-vin: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > media: rcar-csi2: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > media: i2c: imx219: Fix power sequence > > media: i2c: imx219: Add support for RAW8 bit bayer format > > media: i2c: imx219: Add support for cropped 640x480 resolution > > arm64: dts: renesas: r8a774c0-cat874: Add support for AISTARVISION > > MIPI Adapter V2.1 > > media: dt-bindings: media: renesas,vin: Add R8A774E1 support > > media: rcar-vin: Enable support for R8A774E1 > > media: dt-bindings: media: renesas,csi2: Add R8A774E1 support > > media: rcar-csi2: Enable support for R8A774E1 > > arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro > > for each sensor > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2H > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2M > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > HiHope RZ/G2N > > > > Laurent Pinchart (4): > > media: device property: Add a function to test is a fwnode is a graph > > endpoint > > media: v4l2-async: Accept endpoints and devices for fwnode matching > > media: v4l2-async: Pass notifier pointer to match functions > > media: v4l2-async: Log message in case of heterogeneous fwnode match > > > > Niklas Söderlund (2): > > media: rcar-vin: fix wrong return value in rvin_set_channel_routing() > > media: rcar-csi2: Update V3M and E3 start procedure > > > > Sakari Ailus (1): > > media: v4l: ctrl: Provide unlocked variant of v4l2_ctrl_grab > > > > .../devicetree/bindings/media/i2c/imx219.yaml | 114 ++ > > .../devicetree/bindings/media/rcar_vin.txt | 3 + > > .../bindings/media/renesas,rcar-csi2.txt | 3 + > > MAINTAINERS | 8 + > > arch/arm64/boot/dts/renesas/Makefile | 10 +- > > .../aistarvision-mipi-adapter-2.1.dtsi | 96 + > > ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ > > .../r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts | 29 + > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++ > > .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts | 16 + > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 366 ++++ > > .../dts/renesas/r8a774c0-ek874-mipi-2.1.dts | 73 + > > .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 + > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 334 ++++ > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx219.c | 1582 +++++++++++++++++ > > drivers/media/i2c/ov5645.c | 28 - > > drivers/media/platform/rcar-vin/rcar-core.c | 49 + > > drivers/media/platform/rcar-vin/rcar-csi2.c | 23 +- > > drivers/media/platform/rcar-vin/rcar-dma.c | 17 +- > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 + > > drivers/media/v4l2-core/v4l2-async.c | 83 +- > > drivers/media/v4l2-core/v4l2-ctrls.c | 8 +- > > include/linux/property.h | 5 + > > include/media/v4l2-ctrls.h | 26 +- > > 26 files changed, 3330 insertions(+), 51 deletions(-) > > create mode 100644 > Documentation/devicetree/bindings/media/i2c/imx219.yaml > > create mode 100644 arch/arm64/boot/dts/renesas/aistarvision-mipi- > adapter-2.1.dtsi > > create mode 100644 arch/arm64/boot/dts/renesas/hihope-rzg2-ex- > aistarvision-mipi-adapter-2.1.dtsi > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope- > rzg2m-ex-mipi-2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope- > rzg2n-ex-mipi-2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi- > 2.1.dts > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1-hihope- > rzg2h-ex-mipi-2.1.dts > > create mode 100644 drivers/media/i2c/imx219.c > > > > -- > > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6271): https://lists.cip-project.org/g/cip-dev/message/6271 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hello Pavel, Iwamatsu-san, > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On > Behalf Of Chris Paterson via lists.cip-project.org > Sent: 10 March 2021 10:59 > > Hello Pavel, Iwamatsu-san, > > > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On > > Behalf Of Nobuhiro Iwamatsu via lists.cip-project.org > > Sent: 10 March 2021 08:08 > > > > Hi, > > > > > -----Original Message----- > > > From: Lad Prabhakar [mailto:prabhakar.mahadev- > lad.rj@bp.renesas.com] > > > Sent: Wednesday, March 10, 2021 1:36 AM > > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 > > □SWC◯ACT) > > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > > > Cc: Biju Das <biju.das.jz@bp.renesas.com> > > > Subject: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 > > support > > > > > > Hi All, > > > > > > This patch series does the following: > > > * Drops unneeded regulator setup for OV5645 sensor > > > * Adds driver for IMX219 sensor > > > * Updates v4l2-async to accept endpoints for fwnode matching > > > * Various fixes for R-Car VIN driver > > > * Support to capture RAW format to VIN driver > > > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > > > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > > > enable VIN, CSI2 modules and OV5645, IMX219 sensors. > > > > > > > I reviewed this series, I didn't see any major problems. > > As Paval points out, the Renesas lab is now stopped. > > If this recovers and the target hardware test is okay, I would apply this. > > Sorry about the lab-cip-renesas issues. The lab will probably be offline until > next week. > I'm happy for this series to be delayed until it's tested if that's what you'd > prefer. The Renesas boards are available for testing again now :) Let me know if there is any further input required for this series. Thanks, Chris > > Kind regards, Chris > > > > Cheers, > > > Prabhakar > > > > Best regards, > > Nobuhiro > > > > > > > > > > Andrey Konovalov (1): > > > media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > > > > > Biju Das (10): > > > media: dt-bindings: media: rcar_vin: Add r8a774a1 support > > > media: rcar-vin: Enable support for r8a774a1 > > > media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > > media: rcar-csi2: Enable support for r8a774a1 > > > arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes > > > media: dt-bindings: rcar-vin: Add R8A774B1 support > > > media: rcar-vin: Enable support for R8A774B1 > > > media: dt-bindings: rcar-csi2: Add R8A774B1 support > > > media: rcar-csi2: Enable support for R8A774B1 > > > arm64: dts: renesas: r8a774b1: Add VIN and CSI-2 support > > > > > > Dafna Hirschfeld (1): > > > media: i2c: imx219: Fix a bug in imx219_enum_frame_size > > > > > > Dave Stevenson (1): > > > media: i2c: Add driver for Sony IMX219 sensor > > > > > > Fabio Estevam (1): > > > media: ov5645: Remove unneeded regulator_set_voltage() > > > > > > Hans Verkuil (2): > > > media: i2c: imx219: Selection compliance fixes > > > media: i2c: imx219: take lock in imx219_enum_mbus_code/frame_size > > > > > > Jacopo Mondi (1): > > > media: i2c: imx219: Implement get_selection > > > > > > Lad Prabhakar (16): > > > media: rcar-vin: Invalidate pipeline if conversion is not possible on > > > input formats > > > media: rcar-vin: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > > media: rcar-csi2: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 > format > > > media: i2c: imx219: Fix power sequence > > > media: i2c: imx219: Add support for RAW8 bit bayer format > > > media: i2c: imx219: Add support for cropped 640x480 resolution > > > arm64: dts: renesas: r8a774c0-cat874: Add support for AISTARVISION > > > MIPI Adapter V2.1 > > > media: dt-bindings: media: renesas,vin: Add R8A774E1 support > > > media: rcar-vin: Enable support for R8A774E1 > > > media: dt-bindings: media: renesas,csi2: Add R8A774E1 support > > > media: rcar-csi2: Enable support for R8A774E1 > > > arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes > > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro > > > for each sensor > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > HiHope RZ/G2H > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > HiHope RZ/G2M > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > HiHope RZ/G2N > > > > > > Laurent Pinchart (4): > > > media: device property: Add a function to test is a fwnode is a graph > > > endpoint > > > media: v4l2-async: Accept endpoints and devices for fwnode matching > > > media: v4l2-async: Pass notifier pointer to match functions > > > media: v4l2-async: Log message in case of heterogeneous fwnode > match > > > > > > Niklas Söderlund (2): > > > media: rcar-vin: fix wrong return value in rvin_set_channel_routing() > > > media: rcar-csi2: Update V3M and E3 start procedure > > > > > > Sakari Ailus (1): > > > media: v4l: ctrl: Provide unlocked variant of v4l2_ctrl_grab > > > > > > .../devicetree/bindings/media/i2c/imx219.yaml | 114 ++ > > > .../devicetree/bindings/media/rcar_vin.txt | 3 + > > > .../bindings/media/renesas,rcar-csi2.txt | 3 + > > > MAINTAINERS | 8 + > > > arch/arm64/boot/dts/renesas/Makefile | 10 +- > > > .../aistarvision-mipi-adapter-2.1.dtsi | 96 + > > > ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ > > > .../r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts | 29 + > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++ > > > .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts | 16 + > > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 366 ++++ > > > .../dts/renesas/r8a774c0-ek874-mipi-2.1.dts | 73 + > > > .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 + > > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 334 ++++ > > > drivers/media/i2c/Kconfig | 11 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/imx219.c | 1582 +++++++++++++++++ > > > drivers/media/i2c/ov5645.c | 28 - > > > drivers/media/platform/rcar-vin/rcar-core.c | 49 + > > > drivers/media/platform/rcar-vin/rcar-csi2.c | 23 +- > > > drivers/media/platform/rcar-vin/rcar-dma.c | 17 +- > > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 + > > > drivers/media/v4l2-core/v4l2-async.c | 83 +- > > > drivers/media/v4l2-core/v4l2-ctrls.c | 8 +- > > > include/linux/property.h | 5 + > > > include/media/v4l2-ctrls.h | 26 +- > > > 26 files changed, 3330 insertions(+), 51 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/imx219.yaml > > > create mode 100644 arch/arm64/boot/dts/renesas/aistarvision-mipi- > > adapter-2.1.dtsi > > > create mode 100644 arch/arm64/boot/dts/renesas/hihope-rzg2-ex- > > aistarvision-mipi-adapter-2.1.dtsi > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope- > > rzg2m-ex-mipi-2.1.dts > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope- > > rzg2n-ex-mipi-2.1.dts > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874- > mipi- > > 2.1.dts > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1-hihope- > > rzg2h-ex-mipi-2.1.dts > > > create mode 100644 drivers/media/i2c/imx219.c > > > > > > -- > > > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6311): https://lists.cip-project.org/g/cip-dev/message/6311 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Chris, > -----Original Message----- > From: Chris Paterson [mailto:Chris.Paterson2@renesas.com] > Sent: Tuesday, March 23, 2021 7:11 AM > To: cip-dev@lists.cip-project.org; pavel@denx.de; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Subject: RE: [cip-dev] [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support > > Hello Pavel, Iwamatsu-san, > > > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On > > Behalf Of Chris Paterson via lists.cip-project.org > > Sent: 10 March 2021 10:59 > > > > Hello Pavel, Iwamatsu-san, > > > > > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On > > > Behalf Of Nobuhiro Iwamatsu via lists.cip-project.org > > > Sent: 10 March 2021 08:08 > > > > > > Hi, > > > > > > > -----Original Message----- > > > > From: Lad Prabhakar [mailto:prabhakar.mahadev- > > lad.rj@bp.renesas.com] > > > > Sent: Wednesday, March 10, 2021 1:36 AM > > > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 > > > □SWC◯ACT) > > > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > > > > Cc: Biju Das <biju.das.jz@bp.renesas.com> > > > > Subject: [PATCH 4.19.y-cip 00/40] Renesas RZ/G2{E,H,M,N} add VIN, CSI2 > > > support > > > > > > > > Hi All, > > > > > > > > This patch series does the following: > > > > * Drops unneeded regulator setup for OV5645 sensor > > > > * Adds driver for IMX219 sensor > > > > * Updates v4l2-async to accept endpoints for fwnode matching > > > > * Various fixes for R-Car VIN driver > > > > * Support to capture RAW format to VIN driver > > > > * Support for RZ/G2{H,M,N,E} SoC's in VIN/CSI2 driver > > > > * DTS changes for HiHope RZ/G2{H,M,N} and SI Linux RZ/G2E to > > > > enable VIN, CSI2 modules and OV5645, IMX219 sensors. > > > > > > > > > > I reviewed this series, I didn't see any major problems. > > > As Paval points out, the Renesas lab is now stopped. > > > If this recovers and the target hardware test is okay, I would apply this. > > > > Sorry about the lab-cip-renesas issues. The lab will probably be offline until > > next week. > > I'm happy for this series to be delayed until it's tested if that's what you'd > > prefer. > > The Renesas boards are available for testing again now :) > > Let me know if there is any further input required for this series. I just pushed to git.kernel.org. Best regards, Nobuhiro > > Thanks, Chris > > > > > Kind regards, Chris > > > > > > Cheers, > > > > Prabhakar > > > > > > Best regards, > > > Nobuhiro > > > > > > > > > > > > > > Andrey Konovalov (1): > > > > media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > > > > > > > Biju Das (10): > > > > media: dt-bindings: media: rcar_vin: Add r8a774a1 support > > > > media: rcar-vin: Enable support for r8a774a1 > > > > media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > > > media: rcar-csi2: Enable support for r8a774a1 > > > > arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes > > > > media: dt-bindings: rcar-vin: Add R8A774B1 support > > > > media: rcar-vin: Enable support for R8A774B1 > > > > media: dt-bindings: rcar-csi2: Add R8A774B1 support > > > > media: rcar-csi2: Enable support for R8A774B1 > > > > arm64: dts: renesas: r8a774b1: Add VIN and CSI-2 support > > > > > > > > Dafna Hirschfeld (1): > > > > media: i2c: imx219: Fix a bug in imx219_enum_frame_size > > > > > > > > Dave Stevenson (1): > > > > media: i2c: Add driver for Sony IMX219 sensor > > > > > > > > Fabio Estevam (1): > > > > media: ov5645: Remove unneeded regulator_set_voltage() > > > > > > > > Hans Verkuil (2): > > > > media: i2c: imx219: Selection compliance fixes > > > > media: i2c: imx219: take lock in imx219_enum_mbus_code/frame_size > > > > > > > > Jacopo Mondi (1): > > > > media: i2c: imx219: Implement get_selection > > > > > > > > Lad Prabhakar (16): > > > > media: rcar-vin: Invalidate pipeline if conversion is not possible on > > > > input formats > > > > media: rcar-vin: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 format > > > > media: rcar-csi2: Add support for MEDIA_BUS_FMT_SRGGB8_1X8 > > format > > > > media: i2c: imx219: Fix power sequence > > > > media: i2c: imx219: Add support for RAW8 bit bayer format > > > > media: i2c: imx219: Add support for cropped 640x480 resolution > > > > arm64: dts: renesas: r8a774c0-cat874: Add support for AISTARVISION > > > > MIPI Adapter V2.1 > > > > media: dt-bindings: media: renesas,vin: Add R8A774E1 support > > > > media: rcar-vin: Enable support for R8A774E1 > > > > media: dt-bindings: media: renesas,csi2: Add R8A774E1 support > > > > media: rcar-csi2: Enable support for R8A774E1 > > > > arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes > > > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro > > > > for each sensor > > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > > HiHope RZ/G2H > > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > > HiHope RZ/G2M > > > > arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to > > > > HiHope RZ/G2N > > > > > > > > Laurent Pinchart (4): > > > > media: device property: Add a function to test is a fwnode is a graph > > > > endpoint > > > > media: v4l2-async: Accept endpoints and devices for fwnode matching > > > > media: v4l2-async: Pass notifier pointer to match functions > > > > media: v4l2-async: Log message in case of heterogeneous fwnode > > match > > > > > > > > Niklas Söderlund (2): > > > > media: rcar-vin: fix wrong return value in rvin_set_channel_routing() > > > > media: rcar-csi2: Update V3M and E3 start procedure > > > > > > > > Sakari Ailus (1): > > > > media: v4l: ctrl: Provide unlocked variant of v4l2_ctrl_grab > > > > > > > > .../devicetree/bindings/media/i2c/imx219.yaml | 114 ++ > > > > .../devicetree/bindings/media/rcar_vin.txt | 3 + > > > > .../bindings/media/renesas,rcar-csi2.txt | 3 + > > > > MAINTAINERS | 8 + > > > > arch/arm64/boot/dts/renesas/Makefile | 10 +- > > > > .../aistarvision-mipi-adapter-2.1.dtsi | 96 + > > > > ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ > > > > .../r8a774a1-hihope-rzg2m-ex-mipi-2.1.dts | 29 + > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++ > > > > .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts | 16 + > > > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 366 ++++ > > > > .../dts/renesas/r8a774c0-ek874-mipi-2.1.dts | 73 + > > > > .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 + > > > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 334 ++++ > > > > drivers/media/i2c/Kconfig | 11 + > > > > drivers/media/i2c/Makefile | 1 + > > > > drivers/media/i2c/imx219.c | 1582 +++++++++++++++++ > > > > drivers/media/i2c/ov5645.c | 28 - > > > > drivers/media/platform/rcar-vin/rcar-core.c | 49 + > > > > drivers/media/platform/rcar-vin/rcar-csi2.c | 23 +- > > > > drivers/media/platform/rcar-vin/rcar-dma.c | 17 +- > > > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 + > > > > drivers/media/v4l2-core/v4l2-async.c | 83 +- > > > > drivers/media/v4l2-core/v4l2-ctrls.c | 8 +- > > > > include/linux/property.h | 5 + > > > > include/media/v4l2-ctrls.h | 26 +- > > > > 26 files changed, 3330 insertions(+), 51 deletions(-) > > > > create mode 100644 > > > Documentation/devicetree/bindings/media/i2c/imx219.yaml > > > > create mode 100644 arch/arm64/boot/dts/renesas/aistarvision-mipi- > > > adapter-2.1.dtsi > > > > create mode 100644 arch/arm64/boot/dts/renesas/hihope-rzg2-ex- > > > aistarvision-mipi-adapter-2.1.dtsi > > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope- > > > rzg2m-ex-mipi-2.1.dts > > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope- > > > rzg2n-ex-mipi-2.1.dts > > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874- > > mipi- > > > 2.1.dts > > > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1-hihope- > > > rzg2h-ex-mipi-2.1.dts > > > > create mode 100644 drivers/media/i2c/imx219.c > > > > > > > > -- > > > > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6312): https://lists.cip-project.org/g/cip-dev/message/6312 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
> From: nobuhiro1.iwamatsu@toshiba.co.jp > <nobuhiro1.iwamatsu@toshiba.co.jp> > Sent: 23 March 2021 07:32 > > > > Sorry about the lab-cip-renesas issues. The lab will probably be offline > until > > > next week. > > > I'm happy for this series to be delayed until it's tested if that's what you'd > > > prefer. > > > > The Renesas boards are available for testing again now :) > > > > Let me know if there is any further input required for this series. > > I just pushed to git.kernel.org. Thank you! Kind regards, Chris -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6313): https://lists.cip-project.org/g/cip-dev/message/6313 Mute This Topic: https://lists.cip-project.org/mt/81205345/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-