[6.1.y-cip,0/6] Add RZ/{G2L,G2LC,V2L} MTU3 PWM support.

Message

Biju Das July 18, 2023, 2:11 p.m. UTC

This patch series aims to add support for RZ/{G2L,G2LC,V2L}
MTU3 PWM driver.

All the patches are cherry-picked from the mainline
except patch#4-patch#6. The trivial patches#4-#6 are
cherry-picked from next.

Biju Das (5):
  arm64: defconfig: Enable Renesas MTU3a counter config
  pwm: Add Renesas RZ/G2L MTU3a PWM driver
  arm64: dts: renesas: rzg2l-smarc: Add support for enabling MTU3
  arm64: dts: renesas: rzg2lc-smarc: Add support for enabling MTU3
  arm64: defconfig: Enable Renesas MTU3a PWM config

Lad Prabhakar (1):
  arm64: dts: renesas: rzg2lc-smarc: Include SoM DTSI into board DTS

 .../boot/dts/renesas/r9a07g044c2-smarc.dts    |  42 ++
 .../boot/dts/renesas/r9a07g044l2-smarc.dts    |  21 +
 .../boot/dts/renesas/r9a07g054l2-smarc.dts    |  20 +
 .../dts/renesas/rzg2l-smarc-pinfunction.dtsi  |  20 +
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |  23 +-
 .../dts/renesas/rzg2lc-smarc-pinfunction.dtsi |   9 +
 arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi |  42 +-
 arch/arm64/configs/defconfig                  |   4 +
 drivers/pwm/Kconfig                           |  11 +
 drivers/pwm/Makefile                          |   1 +
 drivers/pwm/pwm-rz-mtu3.c                     | 551 ++++++++++++++++++
 11 files changed, 712 insertions(+), 32 deletions(-)
 create mode 100644 drivers/pwm/pwm-rz-mtu3.c

Comments

Pavel Machek July 19, 2023, 2:11 p.m. UTC | #1

Hi!

> This patch series aims to add support for RZ/{G2L,G2LC,V2L}
> MTU3 PWM driver.
> 
> All the patches are cherry-picked from the mainline
> except patch#4-patch#6. The trivial patches#4-#6 are
> cherry-picked from next.

So... this is similar to 5.10, and same comments apply except that
WARN_ON. They are details that should not block merge.

But we really should not be merging patches that are not yet upstream
(because policy and because the commit numbers would change).

So I'd propose testing this and then merging all the patches that are
mainline (for both this and 5.10 series), unless there are other
comments.

Thanks and best regards,
								Pavel

Nobuhiro Iwamatsu July 20, 2023, 9:59 a.m. UTC | #2

HI all,

> -----Original Message-----
> From: Biju Das <[e-mail]>
> Sent: Tuesday, July 18, 2023 11:11 PM
> To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>; Pavel Machek
> <[e-mail]>
> Cc: Biju Das <[e-mail]>; Fabrizio Castro
> <[e-mail]>
> Subject: [PATCH 6.1.y-cip 0/6] Add RZ/{G2L,G2LC,V2L} MTU3 PWM support.
> 
> This patch series aims to add support for RZ/{G2L,G2LC,V2L}
> MTU3 PWM driver.
> 
> All the patches are cherry-picked from the mainline except patch#4-patch#6.
> The trivial patches#4-#6 are cherry-picked from next.
> 
> Biju Das (5):
>   arm64: defconfig: Enable Renesas MTU3a counter config
>   pwm: Add Renesas RZ/G2L MTU3a PWM driver
>   arm64: dts: renesas: rzg2l-smarc: Add support for enabling MTU3
>   arm64: dts: renesas: rzg2lc-smarc: Add support for enabling MTU3
>   arm64: defconfig: Enable Renesas MTU3a PWM config
> 
> Lad Prabhakar (1):
>   arm64: dts: renesas: rzg2lc-smarc: Include SoM DTSI into board DTS
> 

I reviewed this series, LGTM. I can apply if there are no comments.
Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Best regards,
  Nobuhiro

Biju Das July 20, 2023, 11:05 a.m. UTC | #3

> -----Original Message-----
> From: [e-mail]
> <[e-mail]>
> Sent: Thursday, July 20, 2023 11:00 AM
> To: Biju Das <[e-mail]>; [e-mail]-
> project.org; [e-mail]
> Cc: Fabrizio Castro <[e-mail]>
> Subject: RE: [PATCH 6.1.y-cip 0/6] Add RZ/{G2L,G2LC,V2L} MTU3 PWM
> support.
> 
> HI all,
> 
> > -----Original Message-----
> > From: Biju Das <[e-mail]>
> > Sent: Tuesday, July 18, 2023 11:11 PM
> > To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> > ＤＩＴ○ＯＳＴ) <[e-mail]>; Pavel Machek
> > <[e-mail]>
> > Cc: Biju Das <[e-mail]>; Fabrizio Castro
> > <[e-mail]>
> > Subject: [PATCH 6.1.y-cip 0/6] Add RZ/{G2L,G2LC,V2L} MTU3 PWM support.
> >
> > This patch series aims to add support for RZ/{G2L,G2LC,V2L}
> > MTU3 PWM driver.
> >
> > All the patches are cherry-picked from the mainline except patch#4-
> patch#6.
> > The trivial patches#4-#6 are cherry-picked from next.
> >
> > Biju Das (5):
> >   arm64: defconfig: Enable Renesas MTU3a counter config
> >   pwm: Add Renesas RZ/G2L MTU3a PWM driver
> >   arm64: dts: renesas: rzg2l-smarc: Add support for enabling MTU3
> >   arm64: dts: renesas: rzg2lc-smarc: Add support for enabling MTU3
> >   arm64: defconfig: Enable Renesas MTU3a PWM config
> >
> > Lad Prabhakar (1):
> >   arm64: dts: renesas: rzg2lc-smarc: Include SoM DTSI into board DTS
> >
> 
> I reviewed this series, LGTM. I can apply if there are no comments.


Thank you!

Cheers,
Biju
> Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>
> 
> Best regards,
>   Nobuhiro

Pavel Machek July 20, 2023, 11:33 a.m. UTC | #4

Hi!

> > Lad Prabhakar (1):
> >   arm64: dts: renesas: rzg2lc-smarc: Include SoM DTSI into board DTS
> > 
> 
> I reviewed this series, LGTM. I can apply if there are no comments.
> Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Thanks for review, I applied patches that are mainline and pushed
results out.

Best regards,
								Pavel