| Message ID | 20240529081434.639519-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Ethernet support for Renesas RZ/G3S SoC | expand |
Hi! > Series adds Ethernet support for Renesas RZ/G3S SoC. Ethernet driver > has been enhanced with runtime PM support. The suspend to RAM support > was also improved. I started reviewing this, and it looks okay so far. I can apply it if it passes testing and there are no other comments. Best regards, Pavel
Hi, > -----Original Message----- > From: Claudiu <claudiu.beznea@tuxon.dev> > Sent: Wednesday, May 29, 2024 5:14 PM > To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de > Cc: cip-dev@lists.cip-project.org; biju.das.jz@bp.renesas.com; > prabhakar.mahadev-lad.rj@bp.renesas.com; paul.barker.ct@bp.renesas.com > Subject: [PATCH 6.1.y-cip 00/33] Add Ethernet support for Renesas RZ/G3S > SoC > > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Hi, > > Series adds Ethernet support for Renesas RZ/G3S SoC. Ethernet driver has > been enhanced with runtime PM support. The suspend to RAM support was > also improved. > > Series is split as follows: > - patch 01: add clock and reset support for the Ethernet IPs > - patches 02-07: add pinctrl support for the Ethernet IPs > - patches 08-29: add support for suspend to RAM and runtime PM on > the Ethernet driver; in this set there are many preparatory > patches for runtime PM support (as runtime PM > enable/disables > the Ethernet module clock and this influences the Ethernet > module state leanding to registers setup being lost) > along with improvements > - patches 30-33: add device tree support > > Thank you, > Claudiu Beznea > > Biju Das (2): > ravb: Add Rx checksum offload support for GbEth > ravb: Add Tx checksum offload support for GbEth > > Claudiu Beznea (30): > clk: renesas: r9a08g045: Add clock and reset support for ETH0 and ETH1 > pinctrl: renesas: rzg2l: Move arg and index in the main function block > pinctrl: renesas: rzg2l: Add pin configuration support for pinmux > groups > pinctrl: renesas: rzg2l: Add support to select power source for > Ethernet pins > pinctrl: renesas: rzg2l: Add output enable support > pinctrl: renesas: rzg2l: Add input enable to the Ethernet pins > pinctrl: renesas: rzg2l: Fix locking in rzg2l_dt_subnode_to_map() > dt-bindings: net: renesas,etheravb: Document RZ/G3S support > net: ravb: Rely on PM domain to enable gptp_clk > net: ravb: Make reset controller support mandatory > net: ravb: Assert/de-assert reset on suspend/resume > net: ravb: Move reference clock enable/disable on runtime PM APIs > net: ravb: Move getting/requesting IRQs in the probe() method > net: ravb: Split GTI computation and set operations > net: ravb: Move delay mode set in the driver's ndo_open API > net: ravb: Move DBAT configuration to the driver's ndo_open API > net: ravb: Move PTP initialization in the driver's ndo_open API for > ccc_gac platorms > net: ravb: Set config mode in ndo_open and reset mode in ndo_close > net: ravb: Simplify ravb_suspend() > net: ravb: Simplify ravb_resume() > net: ravb: Get rid of the temporary variable irq > net: ravb: Keep the reverse order of operations in ravb_close() > net: ravb: Return cached statistics if the interface is down > net: ravb: Move the update of ndev->features to ravb_set_features() > net: ravb: Do not apply features to hardware if the interface is down > net: ravb: Add runtime PM support > arm64: dts: renesas: r9a08g045: Add Ethernet nodes > arm64: dts: renesas: rzg3s-smarc-som: Use switches' names to select > on-board functionalities > arm64: dts: renesas: rzg3s-smarc-som: Enable the Ethernet interfaces > arm64: dts: renesas: rzg3s-smarc-som: Guard Ethernet IRQ GPIO hogs > > Geert Uytterhoeven (1): > net: ravb: Fix registered interrupt names > > .../bindings/net/renesas,etheravb.yaml | 1 + > arch/arm64/boot/dts/renesas/r9a08g045.dtsi | 38 + > .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 177 +++- > drivers/clk/renesas/r9a08g045-cpg.c | 10 + > drivers/net/ethernet/renesas/Kconfig | 1 + > drivers/net/ethernet/renesas/ravb.h | 40 +- > drivers/net/ethernet/renesas/ravb_main.c | 947 > +++++++++++------- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 164 ++- > 8 files changed, 960 insertions(+), 418 deletions(-) > Thanks for your work. I reviewd this series, so I have no comments. Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Best regards, Nobuhiro
Hi! > Thanks for your work. > I reviewd this series, so I have no comments. > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Thank you, applied. Best regards, Pavel
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Hi, Series adds Ethernet support for Renesas RZ/G3S SoC. Ethernet driver has been enhanced with runtime PM support. The suspend to RAM support was also improved. Series is split as follows: - patch 01: add clock and reset support for the Ethernet IPs - patches 02-07: add pinctrl support for the Ethernet IPs - patches 08-29: add support for suspend to RAM and runtime PM on the Ethernet driver; in this set there are many preparatory patches for runtime PM support (as runtime PM enable/disables the Ethernet module clock and this influences the Ethernet module state leanding to registers setup being lost) along with improvements - patches 30-33: add device tree support Thank you, Claudiu Beznea Biju Das (2): ravb: Add Rx checksum offload support for GbEth ravb: Add Tx checksum offload support for GbEth Claudiu Beznea (30): clk: renesas: r9a08g045: Add clock and reset support for ETH0 and ETH1 pinctrl: renesas: rzg2l: Move arg and index in the main function block pinctrl: renesas: rzg2l: Add pin configuration support for pinmux groups pinctrl: renesas: rzg2l: Add support to select power source for Ethernet pins pinctrl: renesas: rzg2l: Add output enable support pinctrl: renesas: rzg2l: Add input enable to the Ethernet pins pinctrl: renesas: rzg2l: Fix locking in rzg2l_dt_subnode_to_map() dt-bindings: net: renesas,etheravb: Document RZ/G3S support net: ravb: Rely on PM domain to enable gptp_clk net: ravb: Make reset controller support mandatory net: ravb: Assert/de-assert reset on suspend/resume net: ravb: Move reference clock enable/disable on runtime PM APIs net: ravb: Move getting/requesting IRQs in the probe() method net: ravb: Split GTI computation and set operations net: ravb: Move delay mode set in the driver's ndo_open API net: ravb: Move DBAT configuration to the driver's ndo_open API net: ravb: Move PTP initialization in the driver's ndo_open API for ccc_gac platorms net: ravb: Set config mode in ndo_open and reset mode in ndo_close net: ravb: Simplify ravb_suspend() net: ravb: Simplify ravb_resume() net: ravb: Get rid of the temporary variable irq net: ravb: Keep the reverse order of operations in ravb_close() net: ravb: Return cached statistics if the interface is down net: ravb: Move the update of ndev->features to ravb_set_features() net: ravb: Do not apply features to hardware if the interface is down net: ravb: Add runtime PM support arm64: dts: renesas: r9a08g045: Add Ethernet nodes arm64: dts: renesas: rzg3s-smarc-som: Use switches' names to select on-board functionalities arm64: dts: renesas: rzg3s-smarc-som: Enable the Ethernet interfaces arm64: dts: renesas: rzg3s-smarc-som: Guard Ethernet IRQ GPIO hogs Geert Uytterhoeven (1): net: ravb: Fix registered interrupt names .../bindings/net/renesas,etheravb.yaml | 1 + arch/arm64/boot/dts/renesas/r9a08g045.dtsi | 38 + .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 177 +++- drivers/clk/renesas/r9a08g045-cpg.c | 10 + drivers/net/ethernet/renesas/Kconfig | 1 + drivers/net/ethernet/renesas/ravb.h | 40 +- drivers/net/ethernet/renesas/ravb_main.c | 947 +++++++++++------- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 164 ++- 8 files changed, 960 insertions(+), 418 deletions(-)