[6.1.y-cip,00/11] Backport ravb driver improvements

Message

Paul Barker July 24, 2024, 8 a.m. UTC

This series includes all relevant fixes, tidy-ups and other improvements
to the ravb driver present in Linux v6.10. Backporting these patches is
a prerequisite so that we can backport the GbEth performance improvement
patches which will be included in Linux v6.11 [1].

[1]: https://lore.kernel.org/all/[e-mail]/

Niklas Söderlund (7):
  ravb: Group descriptor types used in Rx ring
  ravb: Make it clear the information relates to maximum frame size
  ravb: Create helper to allocate skb and align it
  ravb: Use the max frame size from hardware info for RZ/G2L
  ravb: Move maximum Rx descriptor data usage to info struct
  ravb: Unify Rx ring maintenance code paths
  ravb: Correct buffer size to map for R-Car Rx

Paul Barker (4):
  net: ravb: Count packets instead of descriptors in GbEth RX path
  get: ravb: Count packets instead of descriptors in R-Car RX path
  net: ravb: Allow RX loop to move past DMA mapping errors
  net: ravb: Fix RX byte accounting for jumbo packets

 drivers/net/ethernet/renesas/ravb.h      |  20 +-
 drivers/net/ethernet/renesas/ravb_main.c | 290 +++++++++--------------
 2 files changed, 119 insertions(+), 191 deletions(-)

Comments

Pavel Machek July 24, 2024, 5:40 p.m. UTC | #1

Hi!

> This series includes all relevant fixes, tidy-ups and other improvements
> to the ravb driver present in Linux v6.10. Backporting these patches is
> a prerequisite so that we can backport the GbEth performance improvement
> patches which will be included in Linux v6.11 [1].

Series looks good, so I can apply it if it passes testing and there
are no other comments.

I see extra blank lines before final sign-off. That's unusual/wrong, but I
can remove them while applying.

Best regards,
								Pavel

Nobuhiro Iwamatsu July 25, 2024, 6:23 a.m. UTC | #2

Hi all,

> -----Original Message-----
> From: Paul Barker <[e-mail]>
> Sent: Wednesday, July 24, 2024 5:01 PM
> To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>; Pavel Machek
> <[e-mail]>
> Cc: Biju Das <[e-mail]>; Lad Prabhakar
> <[e-mail]>
> Subject: [PATCH 6.1.y-cip 00/11] Backport ravb driver improvements
> 
> This series includes all relevant fixes, tidy-ups and other improvements to the
> ravb driver present in Linux v6.10. Backporting these patches is a prerequisite
> so that we can backport the GbEth performance improvement patches which
> will be included in Linux v6.11 [1].
> 
> [1]:
> https://lore.kernel.org/all/[e-mail]
> s.com/
> 
> Niklas Söderlund (7):
>   ravb: Group descriptor types used in Rx ring
>   ravb: Make it clear the information relates to maximum frame size
>   ravb: Create helper to allocate skb and align it
>   ravb: Use the max frame size from hardware info for RZ/G2L
>   ravb: Move maximum Rx descriptor data usage to info struct
>   ravb: Unify Rx ring maintenance code paths
>   ravb: Correct buffer size to map for R-Car Rx
> 
> Paul Barker (4):
>   net: ravb: Count packets instead of descriptors in GbEth RX path
>   get: ravb: Count packets instead of descriptors in R-Car RX path
>   net: ravb: Allow RX loop to move past DMA mapping errors
>   net: ravb: Fix RX byte accounting for jumbo packets
> 
>  drivers/net/ethernet/renesas/ravb.h      |  20 +-
>  drivers/net/ethernet/renesas/ravb_main.c | 290
> +++++++++--------------
>  2 files changed, 119 insertions(+), 191 deletions(-)

I reviewed this series, there are no problems.
I can apply this series, if there are no other comments.

Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Best regards,
  Nobuhiro

Nobuhiro Iwamatsu July 25, 2024, 6:27 a.m. UTC | #3

Hi Pavel,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: Thursday, July 25, 2024 2:40 AM
> To: Paul Barker <[e-mail]>
> Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>; Pavel Machek
> <[e-mail]>; Biju Das <[e-mail]>; Lad Prabhakar
> <[e-mail]>
> Subject: Re: [PATCH 6.1.y-cip 00/11] Backport ravb driver improvements
> 
> Hi!
> 
> > This series includes all relevant fixes, tidy-ups and other
> > improvements to the ravb driver present in Linux v6.10. Backporting
> > these patches is a prerequisite so that we can backport the GbEth
> > performance improvement patches which will be included in Linux v6.11 [1].
> 
> Series looks good, so I can apply it if it passes testing and there are no other
> comments.
> 
> I see extra blank lines before final sign-off. That's unusual/wrong, but I can
> remove them while applying.

+1. 
Please remove blank line.

Best regards,
  Nobuhiro

Pavel Machek July 25, 2024, 8:34 a.m. UTC | #4

Hi!

> >  drivers/net/ethernet/renesas/ravb.h      |  20 +-
> >  drivers/net/ethernet/renesas/ravb_main.c | 290
> > +++++++++--------------
> >  2 files changed, 119 insertions(+), 191 deletions(-)
> 
> I reviewed this series, there are no problems.
> I can apply this series, if there are no other comments.
> 
> Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Thank you, I applied it with your Reviewed-by: tag added.

Best regards,
								Pavel