[isar-cip-core,v2,0/2] Fixing dependency of package expand-on-first-boot on cryptsetup and tss2 (tpm2) libraries when building with disk encryption enabled.

Message

Heinisch, Alexander Oct. 21, 2024, 6:53 p.m. UTC

From: Alexander Heinisch <[e-mail]>

To fix the dependencies between `expand-on-first-boot` and the `initramfs-crypt-hook`
we introduced a new variable `ADDITIONAL_DISK_ENCRYPTION_PACKAGES` to extend the 
dependencies of package expand-on-first-boot_%.bb. 

See: https://groups.google.com/g/isar-users/c/0mc0AGyP3yY

The patch got applied to next on the upstream repo and the isar-cip-core next branch already contains that fix (https://github.com/ilbers/isar/commit/8b30a4f86cb3ea3369bff3884141872c3a7d9979).

This patch series adds definitions for `ADDITIONAL_DISK_ENCRYPTION_PACKAGES` and reuses it in the crypt hook.

This patch series got tested on bookworm based builds.
Unfortunately, for disks encrypted using clevis (bullseye and buster), I'm afraid, there won't be an improvement!

Alexander Heinisch (2):
  Fixing dependency of package expand-on-first-boot on cryptsetup and
    tss2 (tpm2) libraries when building with disk encryption enabled.
    (for bookworm)
  Reuse var ADDITIONAL_DISK_ENCRYPTION_PACKAGES in package
    initramfs-crypt-hook.

 conf/distro/cip-core-common.inc                    | 13 +++++++++++++
 .../initramfs-crypt-hook_0.2.bb                    | 14 ++++++++++----
 2 files changed, 23 insertions(+), 4 deletions(-)

Comments

Jan Kiszka Oct. 21, 2024, 7:12 p.m. UTC | #1

On 21.10.24 20:53, [e-mail] wrote:
> From: Alexander Heinisch <[e-mail]>
> 
> To fix the dependencies between `expand-on-first-boot` and the `initramfs-crypt-hook`
> we introduced a new variable `ADDITIONAL_DISK_ENCRYPTION_PACKAGES` to extend the 
> dependencies of package expand-on-first-boot_%.bb. 
> 
> See: https://groups.google.com/g/isar-users/c/0mc0AGyP3yY
> 
> The patch got applied to next on the upstream repo and the isar-cip-core next branch already contains that fix (https://github.com/ilbers/isar/commit/8b30a4f86cb3ea3369bff3884141872c3a7d9979).
> 
> This patch series adds definitions for `ADDITIONAL_DISK_ENCRYPTION_PACKAGES` and reuses it in the crypt hook.
> 
> This patch series got tested on bookworm based builds.
> Unfortunately, for disks encrypted using clevis (bullseye and buster), I'm afraid, there won't be an improvement!
> 

Given that this now comes fairly late for our release cycle and also
given that open issue, I would postpone this series to post release and
possible post further discussion or even solution proposals.

Thanks,
Jan

> Alexander Heinisch (2):
>   Fixing dependency of package expand-on-first-boot on cryptsetup and
>     tss2 (tpm2) libraries when building with disk encryption enabled.
>     (for bookworm)
>   Reuse var ADDITIONAL_DISK_ENCRYPTION_PACKAGES in package
>     initramfs-crypt-hook.
> 
>  conf/distro/cip-core-common.inc                    | 13 +++++++++++++
>  .../initramfs-crypt-hook_0.2.bb                    | 14 ++++++++++----
>  2 files changed, 23 insertions(+), 4 deletions(-)
>