mbox series

[v5.10.y-cip,v2,00/16] renesas: rzg3s: backport the RTC support

Message ID 20250124090041.1401132-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive)
Headers show
Series renesas: rzg3s: backport the RTC support | expand

Message

Claudiu Jan. 24, 2025, 9 a.m. UTC 
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Hi,

Series backports the RTC support for the Renesas RZ/G3S SoC.
Along with a clock driver for the clock provided the VBATTB
is included as this is critical for the RTC to work, as it feeds
the RTC counter.

For the VBATTB clock driver the following patches were also
backported:
- clk: gate: Add devm_clk_hw_register_gate()
- clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()
- clk: fixed-factor: add fwname-based constructor functions

and adjusted accordingly, if needed.

For the same VBATTB clock driver the
devm_clk_hw_register_gate_parent_data() was backported from the upstream
commit d54c1fd4a51e ("Add clock driver for Sunplus SP7021 SoC") in
the patch "clk: Add devm_clk_hw_register_gate_parent_data()".

Thank you,
Claudiu Beznea

Changes in v2:
- adjusted the patch title and description for patch 1/1
- collected tags

Claudiu Beznea (13):
  clk: Add devm_clk_hw_register_gate_parent_data()
  clk: Add devm_clk_hw_register_gate_parent_hw()
  dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB
  clk: renesas: vbattb: Add VBATTB clock driver
  clk: renesas: r9a08g045: Add clock, reset and power domain support for
    the VBATTB IP
  dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RTCA-3 IP
  rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S
    SoC
  rtc: renesas-rtca3: Fix compilation error on RISC-V
  arm64: dts: renesas: r9a08g045: Add VBATTB node
  arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB
  arm64: dts: renesas: r9a08g045: Add RTC node
  arm64: dts: renesas: rzg3s-smarc-som: Enable RTC
  arm64: defconfig: Enable VBATTB clock and Renesas RTCA-3

Horatiu Vultur (1):
  clk: gate: Add devm_clk_hw_register_gate()

Marijn Suijten (1):
  clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

Théo Lebrun (1):
  clk: fixed-factor: add fwname-based constructor functions

 .../clock/renesas,r9a08g045-vbattb.yaml       |  84 ++
 .../bindings/rtc/renesas,rz-rtca3.yaml        |  84 ++
 MAINTAINERS                                   |   8 +
 arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  34 +
 .../boot/dts/renesas/rzg3s-smarc-som.dtsi     |  16 +
 arch/arm64/configs/defconfig                  |   2 +
 drivers/clk/clk-fixed-factor.c                |  59 +-
 drivers/clk/clk-gate.c                        |  35 +
 drivers/clk/renesas/Kconfig                   |   5 +
 drivers/clk/renesas/Makefile                  |   1 +
 drivers/clk/renesas/clk-vbattb.c              | 204 ++++
 drivers/clk/renesas/r9a08g045-cpg.c           |   3 +
 drivers/rtc/Kconfig                           |  10 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-renesas-rtca3.c               | 923 ++++++++++++++++++
 .../clock/renesas,r9a08g045-vbattb.h          |  13 +
 include/linux/clk-provider.h                  |  73 ++
 17 files changed, 1541 insertions(+), 14 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/renesas,r9a08g045-vbattb.yaml
 create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rz-rtca3.yaml
 create mode 100644 drivers/clk/renesas/clk-vbattb.c
 create mode 100644 drivers/rtc/rtc-renesas-rtca3.c
 create mode 100644 include/dt-bindings/clock/renesas,r9a08g045-vbattb.h

Comments

Pavel Machek Jan. 25, 2025, 8:08 p.m. UTC | #1 
Hi!

> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Hi,
> 
> Series backports the RTC support for the Renesas RZ/G3S SoC.
> Along with a clock driver for the clock provided the VBATTB
> is included as this is critical for the RTC to work, as it feeds
> the RTC counter.
> 
> For the VBATTB clock driver the following patches were also
> backported:
> - clk: gate: Add devm_clk_hw_register_gate()
> - clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()
> - clk: fixed-factor: add fwname-based constructor functions
> 
> and adjusted accordingly, if needed.
> 
> For the same VBATTB clock driver the
> devm_clk_hw_register_gate_parent_data() was backported from the upstream
> commit d54c1fd4a51e ("Add clock driver for Sunplus SP7021 SoC") in
> the patch "clk: Add devm_clk_hw_register_gate_parent_data()".

I have some comments for 10/ , but those should not block merge.

Series looks good to me, I can apply it if it passes testing and if
there are no other comments.

Best regards,
								Pavel
Nobuhiro Iwamatsu Jan. 27, 2025, 4:38 a.m. UTC | #2 
Hi Claudiu,

Thanks for update this series.

> -----Original Message-----
> From: Claudiu <claudiu.beznea@tuxon.dev>
> Sent: Friday, January 24, 2025 6:00 PM
> To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de
> Cc: claudiu.beznea@tuxon.dev; cip-dev@lists.cip-project.org
> Subject: [PATCH v5.10.y-cip v2 00/16] renesas: rzg3s: backport the RTC
> support
> 
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Hi,
> 
> Series backports the RTC support for the Renesas RZ/G3S SoC.
> Along with a clock driver for the clock provided the VBATTB is included as this
> is critical for the RTC to work, as it feeds the RTC counter.
> 
> For the VBATTB clock driver the following patches were also
> backported:
> - clk: gate: Add devm_clk_hw_register_gate()
> - clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()
> - clk: fixed-factor: add fwname-based constructor functions
> 
> and adjusted accordingly, if needed.
> 
> For the same VBATTB clock driver the
> devm_clk_hw_register_gate_parent_data() was backported from the upstream
> commit d54c1fd4a51e ("Add clock driver for Sunplus SP7021 SoC") in the
> patch "clk: Add devm_clk_hw_register_gate_parent_data()".
> 
> Thank you,
> Claudiu Beznea
> 
> Changes in v2:
> - adjusted the patch title and description for patch 1/1
> - collected tags
> 
> Claudiu Beznea (13):
>   clk: Add devm_clk_hw_register_gate_parent_data()
>   clk: Add devm_clk_hw_register_gate_parent_hw()
>   dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB
>   clk: renesas: vbattb: Add VBATTB clock driver
>   clk: renesas: r9a08g045: Add clock, reset and power domain support for
>     the VBATTB IP
>   dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RTCA-3 IP
>   rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S
>     SoC
>   rtc: renesas-rtca3: Fix compilation error on RISC-V
>   arm64: dts: renesas: r9a08g045: Add VBATTB node
>   arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB
>   arm64: dts: renesas: r9a08g045: Add RTC node
>   arm64: dts: renesas: rzg3s-smarc-som: Enable RTC
>   arm64: defconfig: Enable VBATTB clock and Renesas RTCA-3

Applied, thanks.

Best regards,
  Nobuhiro