diff mbox series

[4.19.y-cip,v2,56/57] arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Message ID 1566999164-27898-57-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Nobuhiro Iwamatsu
Headers show
Series Add basic RZ/G2M SoC support | expand

Commit Message

Fabrizio Castro Aug. 28, 2019, 1:32 p.m. UTC
From: Rob Herring <robh@kernel.org>

commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.

The 'arm,armv8' compatible string is only for software models. It adds
little value otherwise and is inconsistently used as a fallback on some
platforms. Remove it from those platforms.

This fixes warnings generated by the DT schema.

Reported-by: Michal Simek <michal.simek@xilinx.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Nishanth Menon <nm@ti.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Chanho Min <chanho.min@lge.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Tero Kristo <t-kristo@ti.com>
Acked-by: Wei Xu <xuwei5@hisilicon.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Acked-by: Robert Richter <rrichter@cavium.com>
Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[fab: dropped changes not related to r8a774a1.dtsi]
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Nobuhiro Iwamatsu Aug. 30, 2019, 5:32 a.m. UTC | #1
Hi,

> arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

It's not that important, but why is there a space between 'arm,' and 'armv8'
in subject?

Original subject does not have space.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=31af04cd60d3162a58213363fd740a2b0cf0a08e

The following patch have similar problem.

soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}() helpers

Best regards,
  Nobuhiro

> -----Original Message-----
> From: cip-dev-bounces@lists.cip-project.org
> [mailto:cip-dev-bounces@lists.cip-project.org] On Behalf Of Fabrizio
> Castro
> Sent: Wednesday, August 28, 2019 10:33 PM
> To: cip-dev@lists.cip-project.org
> Cc: Biju Das <biju.das@bp.renesas.com>
> Subject: [cip-dev] [PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove
> inconsistent use of 'arm, armv8' compatible string
> 
> From: Rob Herring <robh@kernel.org>
> 
> commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.
> 
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
> 
> This fixes warnings generated by the DT schema.
> 
> Reported-by: Michal Simek <michal.simek@xilinx.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Acked-by: Chanho Min <chanho.min@lge.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> Acked-by: Tero Kristo <t-kristo@ti.com>
> Acked-by: Wei Xu <xuwei5@hisilicon.com>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
> Acked-by: Robert Richter <rrichter@cavium.com>
> Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [fab: dropped changes not related to r8a774a1.dtsi]
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 1969649..a77de9e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -61,7 +61,7 @@
>  		#size-cells = <0>;
> 
>  		a57_0: cpu@0 {
> -			compatible = "arm,cortex-a57", "arm,armv8";
> +			compatible = "arm,cortex-a57";
>  			reg = <0x0>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
> @@ -71,7 +71,7 @@
>  		};
> 
>  		a57_1: cpu@1 {
> -			compatible = "arm,cortex-a57", "arm,armv8";
> +			compatible = "arm,cortex-a57";
>  			reg = <0x1>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
> @@ -81,7 +81,7 @@
>  		};
> 
>  		a53_0: cpu@100 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x100>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
> @@ -91,7 +91,7 @@
>  		};
> 
>  		a53_1: cpu@101 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x101>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
> @@ -101,7 +101,7 @@
>  		};
> 
>  		a53_2: cpu@102 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x102>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
> @@ -111,7 +111,7 @@
>  		};
> 
>  		a53_3: cpu@103 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x103>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;
> --
> 2.7.4
> 
> _______________________________________________
> cip-dev mailing list
> cip-dev@lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
Fabrizio Castro Aug. 30, 2019, 8:59 a.m. UTC | #2
Hi,

>It's not that important, but why is there a space between 'arm,' and 'armv8'
>in subject?
>Original subject does not have space.

It is actually VERY, VERY, important, as the email I have sent out doesn't contain the space.
I have even run hexdump on the patch file on my disk, it confirms there is no space.
I am replying to my own email, and as you can see, there is no space.

>The following patch have similar problem.
>soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}() helpers

Same thing here, there is no space in the email I have sent out, which means it's
probably down to patchwork? Somehow a space gets automatically added, I wonder if
this is happening with the code too?

How do we find out if the problem is with patchwork?

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 28 August 2019 14:33
> Subject: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
> 
> From: Rob Herring <robh@kernel.org>
> 
> commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.
> 
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
> 
> This fixes warnings generated by the DT schema.
> 
> Reported-by: Michal Simek <michal.simek@xilinx.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Acked-by: Chanho Min <chanho.min@lge.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> Acked-by: Tero Kristo <t-kristo@ti.com>
> Acked-by: Wei Xu <xuwei5@hisilicon.com>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
> Acked-by: Robert Richter <rrichter@cavium.com>
> Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [fab: dropped changes not related to r8a774a1.dtsi]
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 1969649..a77de9e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -61,7 +61,7 @@
>  		#size-cells = <0>;
> 
>  		a57_0: cpu@0 {
> -			compatible = "arm,cortex-a57", "arm,armv8";
> +			compatible = "arm,cortex-a57";
>  			reg = <0x0>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
> @@ -71,7 +71,7 @@
>  		};
> 
>  		a57_1: cpu@1 {
> -			compatible = "arm,cortex-a57", "arm,armv8";
> +			compatible = "arm,cortex-a57";
>  			reg = <0x1>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
> @@ -81,7 +81,7 @@
>  		};
> 
>  		a53_0: cpu@100 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x100>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
> @@ -91,7 +91,7 @@
>  		};
> 
>  		a53_1: cpu@101 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x101>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
> @@ -101,7 +101,7 @@
>  		};
> 
>  		a53_2: cpu@102 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x102>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
> @@ -111,7 +111,7 @@
>  		};
> 
>  		a53_3: cpu@103 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x103>;
>  			device_type = "cpu";
>  			power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;
> --
> 2.7.4
Pavel Machek Aug. 30, 2019, 9:09 a.m. UTC | #3
Hi!

> >It's not that important, but why is there a space between 'arm,' and 'armv8'
> >in subject?
> >Original subject does not have space.
> 
> It is actually VERY, VERY, important, as the email I have sent out doesn't contain the space.
> I have even run hexdump on the patch file on my disk, it confirms there is no space.
> I am replying to my own email, and as you can see, there is no
>space.

Can you take a look at the email, as received from the mailinglist? I
see a space in subject, between 'arm,' and 'armv8'.

Can you send the original email, as a binary attachment?

> >The following patch have similar problem.
> >soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}() helpers
> 
> Same thing here, there is no space in the email I have sent out, which means it's
> probably down to patchwork? Somehow a space gets automatically added, I wonder if
> this is happening with the code too?
> 
> How do we find out if the problem is with patchwork?

I don't think patchwork is responsible. It would have to be something
in the mailing list.

Best regards,
								Pavel
Fabrizio Castro Aug. 30, 2019, 9:34 a.m. UTC | #4
Hi Pavel,

> From: Pavel Machek <pavel@denx.de>
> Sent: 30 August 2019 10:10
> Subject: Re: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
> 
> Hi!
> 
> > >It's not that important, but why is there a space between 'arm,' and 'armv8'
> > >in subject?
> > >Original subject does not have space.
> >
> > It is actually VERY, VERY, important, as the email I have sent out doesn't contain the space.
> > I have even run hexdump on the patch file on my disk, it confirms there is no space.
> > I am replying to my own email, and as you can see, there is no
> >space.
> 
> Can you take a look at the email, as received from the mailinglist? I
> see a space in subject, between 'arm,' and 'armv8'.

Interesting...

> 
> Can you send the original email, as a binary attachment?

I use git send-email, therefore unfortunately I don't have the original email.
I have attached the email msg as received from my email client, and the patch file.
It doesn't look like there is a space there...

In both cases:
* "arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string", and
* "soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down,up}() helpers"
it seems like a space was added after the comma, like autocorrect programs would
do...

Has anybody seen this before?

Thanks,
Fab

> 
> > >The following patch have similar problem.
> > >soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}() helpers
> >
> > Same thing here, there is no space in the email I have sent out, which means it's
> > probably down to patchwork? Somehow a space gets automatically added, I wonder if
> > this is happening with the code too?
> >
> > How do we find out if the problem is with patchwork?
> 
> I don't think patchwork is responsible. It would have to be something
> in the mailing list.
> 
> Best regards,
> 								Pavel
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
From: Rob Herring <robh@kernel.org>

commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.

The 'arm,armv8' compatible string is only for software models. It adds
little value otherwise and is inconsistently used as a fallback on some
platforms. Remove it from those platforms.

This fixes warnings generated by the DT schema.

Reported-by: Michal Simek <michal.simek@xilinx.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Nishanth Menon <nm@ti.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Chanho Min <chanho.min@lge.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Tero Kristo <t-kristo@ti.com>
Acked-by: Wei Xu <xuwei5@hisilicon.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Acked-by: Robert Richter <rrichter@cavium.com>
Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[fab: dropped changes not related to r8a774a1.dtsi]
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 1969649..a77de9e 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -61,7 +61,7 @@
                #size-cells = <0>;

                a57_0: cpu@0 {
-                       compatible = "arm,cortex-a57", "arm,armv8";
+                       compatible = "arm,cortex-a57";
                        reg = <0x0>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
@@ -71,7 +71,7 @@
                };

                a57_1: cpu@1 {
-                       compatible = "arm,cortex-a57", "arm,armv8";
+                       compatible = "arm,cortex-a57";
                        reg = <0x1>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
@@ -81,7 +81,7 @@
                };

                a53_0: cpu@100 {
-                       compatible = "arm,cortex-a53", "arm,armv8";
+                       compatible = "arm,cortex-a53";
                        reg = <0x100>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
@@ -91,7 +91,7 @@
                };

                a53_1: cpu@101 {
-                       compatible = "arm,cortex-a53", "arm,armv8";
+                       compatible = "arm,cortex-a53";
                        reg = <0x101>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
@@ -101,7 +101,7 @@
                };

                a53_2: cpu@102 {
-                       compatible = "arm,cortex-a53", "arm,armv8";
+                       compatible = "arm,cortex-a53";
                        reg = <0x102>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
@@ -111,7 +111,7 @@
                };

                a53_3: cpu@103 {
-                       compatible = "arm,cortex-a53", "arm,armv8";
+                       compatible = "arm,cortex-a53";
                        reg = <0x103>;
                        device_type = "cpu";
                        power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;
--
2.7.4
Nobuhiro Iwamatsu Sept. 2, 2019, 1:46 a.m. UTC | #5
Hi Fabrizio,

> -----Original Message-----
> From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com]
> Sent: Friday, August 30, 2019 6:34 PM
> To: Pavel Machek <pavel@denx.de>
> Cc: iwamatsu nobuhiro(岩松 信洋 ○SWC□OST)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>;
> cip-dev@lists.cip-project.org
> Subject: RE: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove
> inconsistent use of 'arm,armv8' compatible string
> 
> Hi Pavel,
> 
> > From: Pavel Machek <pavel@denx.de>
> > Sent: 30 August 2019 10:10
> > Subject: Re: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove
> > inconsistent use of 'arm,armv8' compatible string
> >
> > Hi!
> >
> > > >It's not that important, but why is there a space between 'arm,'
> and 'armv8'
> > > >in subject?
> > > >Original subject does not have space.
> > >
> > > It is actually VERY, VERY, important, as the email I have sent out
> doesn't contain the space.
> > > I have even run hexdump on the patch file on my disk, it confirms
> there is no space.
> > > I am replying to my own email, and as you can see, there is no
> > >space.
> >
> > Can you take a look at the email, as received from the mailinglist?
> I
> > see a space in subject, between 'arm,' and 'armv8'.
> 
> Interesting...
> 
> >
> > Can you send the original email, as a binary attachment?
> 
> I use git send-email, therefore unfortunately I don't have the original
> email.
> I have attached the email msg as received from my email client, and the
> patch file.
> It doesn't look like there is a space there...
> 

Hmm, what do you use smtp server? There may be a problem with the SMTP server.

> In both cases:
> * "arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string",
> and
> * "soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down,up}() helpers"
> it seems like a space was added after the comma, like autocorrect programs
> would do...
> 
> Has anybody seen this before?
> 

I've easily checked.
The pinctrl patch sent last week seems to have the same problem.
e.g. https://lists.cip-project.org/pipermail/cip-dev/2019-August/002988.html

bd3eb391f0fc pinctrl: sh-pfc: r8a77995: Remove unused PINMUX_IPSR_{MSEL2, PHYS}()
f2be905d124b pinctrl: sh-pfc: rcar-gen3: Rename RTS{0, 1, 3, 4}# pin function definitions
db4bd73cbd2c pinctrl: sh-pfc: rcar-gen3: Rename SEL_ADG_{A, B, C} to SEL_ADG{A, B, C}
c50668864e27 pinctrl: sh-pfc: r8a7796: Add I2C{0, 3, 5} pins, groups and functions

> Thanks,
> Fab


Best regards,
  Nobuhiro

> 
> >
> > > >The following patch have similar problem.
> > > >soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}()
> > > >helpers
> > >
> > > Same thing here, there is no space in the email I have sent out,
> > > which means it's probably down to patchwork? Somehow a space gets
> > > automatically added, I wonder if this is happening with the code too?
> > >
> > > How do we find out if the problem is with patchwork?
> >
> > I don't think patchwork is responsible. It would have to be something
> > in the mailing list.
> >
> > Best regards,
> > 								Pavel
> >
> > --
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Fabrizio Castro Sept. 2, 2019, 8:23 a.m. UTC | #6
Hello Iwamatsu-san,

> From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp>
> Sent: 02 September 2019 02:46
> Subject: RE: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
> 
> Hi Fabrizio,
> 
> > -----Original Message-----
> > From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com]
> > Sent: Friday, August 30, 2019 6:34 PM
> > To: Pavel Machek <pavel@denx.de>
> > Cc: iwamatsu nobuhiro(岩松 信洋 ○SWC□OST)
> > <nobuhiro1.iwamatsu@toshiba.co.jp>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>;
> > cip-dev@lists.cip-project.org
> > Subject: RE: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove
> > inconsistent use of 'arm,armv8' compatible string
> >
> > Hi Pavel,
> >
> > > From: Pavel Machek <pavel@denx.de>
> > > Sent: 30 August 2019 10:10
> > > Subject: Re: [cip-dev][PATCH 4.19.y-cip v2 56/57] arm64: dts: Remove
> > > inconsistent use of 'arm,armv8' compatible string
> > >
> > > Hi!
> > >
> > > > >It's not that important, but why is there a space between 'arm,'
> > and 'armv8'
> > > > >in subject?
> > > > >Original subject does not have space.
> > > >
> > > > It is actually VERY, VERY, important, as the email I have sent out
> > doesn't contain the space.
> > > > I have even run hexdump on the patch file on my disk, it confirms
> > there is no space.
> > > > I am replying to my own email, and as you can see, there is no
> > > >space.
> > >
> > > Can you take a look at the email, as received from the mailinglist?
> > I
> > > see a space in subject, between 'arm,' and 'armv8'.
> >
> > Interesting...
> >
> > >
> > > Can you send the original email, as a binary attachment?
> >
> > I use git send-email, therefore unfortunately I don't have the original
> > email.
> > I have attached the email msg as received from my email client, and the
> > patch file.
> > It doesn't look like there is a space there...
> >
> 
> Hmm, what do you use smtp server? There may be a problem with the SMTP server.

I am using Renesas' SMTP server, I have been using the same server for the past two
years, and this is the first time I have seen this problem.

> 
> > In both cases:
> > * "arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string",
> > and
> > * "soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down,up}() helpers"
> > it seems like a space was added after the comma, like autocorrect programs
> > would do...
> >
> > Has anybody seen this before?
> >
> 
> I've easily checked.
> The pinctrl patch sent last week seems to have the same problem.
> e.g. https://lists.cip-project.org/pipermail/cip-dev/2019-August/002988.html
> 
> bd3eb391f0fc pinctrl: sh-pfc: r8a77995: Remove unused PINMUX_IPSR_{MSEL2, PHYS}()
> f2be905d124b pinctrl: sh-pfc: rcar-gen3: Rename RTS{0, 1, 3, 4}# pin function definitions
> db4bd73cbd2c pinctrl: sh-pfc: rcar-gen3: Rename SEL_ADG_{A, B, C} to SEL_ADG{A, B, C}
> c50668864e27 pinctrl: sh-pfc: r8a7796: Add I2C{0, 3, 5} pins, groups and functions

All those patches look ok in my inbox. I put myself in CC when sending out emails with
git send-email, therefore whatever I send out with git send-email reaches my inbox
before the mailing list daemon has the chance to forward the emails to my account, I
wonder if the problem is with the mailing list?

Thanks,
Fab

> 
> > Thanks,
> > Fab
> 
> 
> Best regards,
>   Nobuhiro
> 
> >
> > >
> > > > >The following patch have similar problem.
> > > > >soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down, up}()
> > > > >helpers
> > > >
> > > > Same thing here, there is no space in the email I have sent out,
> > > > which means it's probably down to patchwork? Somehow a space gets
> > > > automatically added, I wonder if this is happening with the code too?
> > > >
> > > > How do we find out if the problem is with patchwork?
> > >
> > > I don't think patchwork is responsible. It would have to be something
> > > in the mailing list.
> > >
> > > Best regards,
> > > 								Pavel
> > >
> > > --
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Pavel Machek Sept. 2, 2019, 8:32 a.m. UTC | #7
Hi!


> > Hmm, what do you use smtp server? There may be a problem with the SMTP server.
> 
> I am using Renesas' SMTP server, I have been using the same server for the past two
> years, and this is the first time I have seen this problem.
> 
> > 
> > > In both cases:
> > > * "arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string",
> > > and
> > > * "soc: renesas: rcar-sysc: Remove rcar_sysc_power_{down,up}() helpers"
> > > it seems like a space was added after the comma, like autocorrect programs
> > > would do...
> > >
> > > Has anybody seen this before?
> > >
> > 
> > I've easily checked.
> > The pinctrl patch sent last week seems to have the same problem.
> > e.g. https://lists.cip-project.org/pipermail/cip-dev/2019-August/002988.html
> > 
> > bd3eb391f0fc pinctrl: sh-pfc: r8a77995: Remove unused PINMUX_IPSR_{MSEL2, PHYS}()
> > f2be905d124b pinctrl: sh-pfc: rcar-gen3: Rename RTS{0, 1, 3, 4}# pin function definitions
> > db4bd73cbd2c pinctrl: sh-pfc: rcar-gen3: Rename SEL_ADG_{A, B, C} to SEL_ADG{A, B, C}
> > c50668864e27 pinctrl: sh-pfc: r8a7796: Add I2C{0, 3, 5} pins, groups and functions
> 
> All those patches look ok in my inbox. I put myself in CC when sending out emails with
> git send-email, therefore whatever I send out with git send-email reaches my inbox
> before the mailing list daemon has the chance to forward the emails to my account, I
> wonder if the problem is with the mailing list?

That should be easy to test. Feel free to send a test patch to a
mailing list, ccing us directly....

Best regards,
								Pavel
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 1969649..a77de9e 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -61,7 +61,7 @@ 
 		#size-cells = <0>;
 
 		a57_0: cpu@0 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x0>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
@@ -71,7 +71,7 @@ 
 		};
 
 		a57_1: cpu@1 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x1>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
@@ -81,7 +81,7 @@ 
 		};
 
 		a53_0: cpu@100 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x100>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
@@ -91,7 +91,7 @@ 
 		};
 
 		a53_1: cpu@101 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x101>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
@@ -101,7 +101,7 @@ 
 		};
 
 		a53_2: cpu@102 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x102>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
@@ -111,7 +111,7 @@ 
 		};
 
 		a53_3: cpu@103 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x103>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;