| Message ID | 1567414102-4869-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [resend] arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string | expand |
Hi Pavel, I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space? Thanks, Fab > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Sent: 02 September 2019 09:48 > Subject: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string > > From: Rob Herring <robh@kernel.org> > > commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream. > > The 'arm,armv8' compatible string is only for software models. It adds > little value otherwise and is inconsistently used as a fallback on some > platforms. Remove it from those platforms. > > This fixes warnings generated by the DT schema. > > Reported-by: Michal Simek <michal.simek@xilinx.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Acked-by: Antoine Tenart <antoine.tenart@bootlin.com> > Acked-by: Nishanth Menon <nm@ti.com> > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Acked-by: Chanho Min <chanho.min@lge.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Heiko Stuebner <heiko@sntech.de> > Acked-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Tero Kristo <t-kristo@ti.com> > Acked-by: Wei Xu <xuwei5@hisilicon.com> > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Acked-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Michal Simek <michal.simek@xilinx.com> > Acked-by: Scott Branden <scott.branden@broadcom.com> > Acked-by: Kevin Hilman <khilman@baylibre.com> > Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> > Acked-by: Robert Richter <rrichter@cavium.com> > Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > Acked-by: Dinh Nguyen <dinguyen@kernel.org> > Signed-off-by: Rob Herring <robh@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > [fab: dropped changes not related to r8a774a1.dtsi] > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > I have put the CIP maintainers in CC, to try and troubleshoot > where the mysterious spaces are coming from, please bear with me... > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index 1969649..a77de9e 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -61,7 +61,7 @@ > #size-cells = <0>; > > a57_0: cpu@0 { > - compatible = "arm,cortex-a57", "arm,armv8"; > + compatible = "arm,cortex-a57"; > reg = <0x0>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA57_CPU0>; > @@ -71,7 +71,7 @@ > }; > > a57_1: cpu@1 { > - compatible = "arm,cortex-a57", "arm,armv8"; > + compatible = "arm,cortex-a57"; > reg = <0x1>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA57_CPU1>; > @@ -81,7 +81,7 @@ > }; > > a53_0: cpu@100 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > reg = <0x100>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA53_CPU0>; > @@ -91,7 +91,7 @@ > }; > > a53_1: cpu@101 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > reg = <0x101>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA53_CPU1>; > @@ -101,7 +101,7 @@ > }; > > a53_2: cpu@102 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > reg = <0x102>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA53_CPU2>; > @@ -111,7 +111,7 @@ > }; > > a53_3: cpu@103 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > reg = <0x103>; > device_type = "cpu"; > power-domains = <&sysc R8A774A1_PD_CA53_CPU3>; > -- > 2.7.4
On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: > Hi Pavel, > > I have put you in CC (and kept the ML as recipient this time around), did you receive the patch > with or without the space? I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one. No extra space. Best regards, Pavel
Hi Pavel, Thank you for the feedback! > From: Pavel Machek <pavel@denx.de> > Sent: 02 September 2019 10:01 > Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string > > On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: > > Hi Pavel, > > > > I have put you in CC (and kept the ML as recipient this time around), did you receive the patch > > with or without the space? > > I got just one copy of email, and it does not have [cip-dev] marking, > so I assume it is the direct one. > > No extra space. Then it's down to the mailing list, somehow, this same email reached the ML, with a space... https://lists.cip-project.org/pipermail/cip-dev/2019-September/003158.html https://patchwork.kernel.org/patch/11126171/ Who is the person responsible for looking after the ML? Thanks, Fab > > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hi Fabrizio, Thanks for your test. > -----Original Message----- > From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] > Sent: Monday, September 2, 2019 6:05 PM > To: Pavel Machek <pavel@denx.de> > Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das > <biju.das@bp.renesas.com>; iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ＯＳ > Ｔ) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org > Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of > 'arm,armv8' compatible string > > Hi Pavel, > > Thank you for the feedback! > > > From: Pavel Machek <pavel@denx.de> > > Sent: 02 September 2019 10:01 > > Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of > > 'arm,armv8' compatible string > > > > On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: > > > Hi Pavel, > > > > > > I have put you in CC (and kept the ML as recipient this time > > > around), did you receive the patch with or without the space? > > > > I got just one copy of email, and it does not have [cip-dev] marking, > > so I assume it is the direct one. > > > > No extra space. > > Then it's down to the mailing list, somehow, this same email reached the > ML, with a space... > https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315 > 8.html > https://patchwork.kernel.org/patch/11126171/ > Hmmm. There may be a problem in Mailman. > Who is the person responsible for looking after the ML? > Maybe Kobayashi-san. I just talked to him about this. Please wait a minute. > Thanks, > Fab Best regards, Nobuhiro
On 03.09.19 06:45, nobuhiro1.iwamatsu@toshiba.co.jp wrote: > Hi Fabrizio, > > Thanks for your test. > >> -----Original Message----- >> From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] >> Sent: Monday, September 2, 2019 6:05 PM >> To: Pavel Machek <pavel@denx.de> >> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das >> <biju.das@bp.renesas.com>; iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ＯＳ >> Ｔ) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org >> Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of >> 'arm,armv8' compatible string >> >> Hi Pavel, >> >> Thank you for the feedback! >> >>> From: Pavel Machek <pavel@denx.de> >>> Sent: 02 September 2019 10:01 >>> Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of >>> 'arm,armv8' compatible string >>> >>> On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: >>>> Hi Pavel, >>>> >>>> I have put you in CC (and kept the ML as recipient this time >>>> around), did you receive the patch with or without the space? >>> >>> I got just one copy of email, and it does not have [cip-dev] marking, >>> so I assume it is the direct one. >>> >>> No extra space. >> >> Then it's down to the mailing list, somehow, this same email reached the >> ML, with a space... >> https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315 >> 8.html >> https://patchwork.kernel.org/patch/11126171/ >> > > Hmmm. There may be a problem in Mailman. > Comparing the original patch (https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh@kernel.org/raw) to ours: X-Mailman-Version: 2.1.21 (looks fine) X-Mailman-Version: 2.1.12 (our potentially broken version) It looks like 2.1.21 is starting the wrapped around subject line only with a single space while our version gained a tab. The latter is likely the core if the issue. I would not expect this difference to be a configuration option of mailman, rather an issue in the older version HTH, Jan >> Who is the person responsible for looking after the ML? >> > > Maybe Kobayashi-san. I just talked to him about this. > Please wait a minute. > >> Thanks, >> Fab > > Best regards, > Nobuhiro > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev >
https://patchwork.kernel.org/patch/10754905/ > -----Original Message----- > From: Jan Kiszka [mailto:jan.kiszka@siemens.com] > Sent: Tuesday, September 3, 2019 10:56 PM > To: iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ＯＳＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp>; fabrizio.castro@bp.renesas.com; > pavel@denx.de > Cc: cip-dev@lists.cip-project.org; biju.das@bp.renesas.com > Subject: Re: [cip-dev] [PATCH resend] arm64: dts: Remove inconsistent > use of 'arm, armv8' compatible string > > On 03.09.19 06:45, nobuhiro1.iwamatsu@toshiba.co.jp wrote: > > Hi Fabrizio, > > > > Thanks for your test. > > > >> -----Original Message----- > >> From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] > >> Sent: Monday, September 2, 2019 6:05 PM > >> To: Pavel Machek <pavel@denx.de> > >> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das > >> <biju.das@bp.renesas.com>; iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ > ＯＳ > >> Ｔ) <nobuhiro1.iwamatsu@toshiba.co.jp>; > cip-dev@lists.cip-project.org > >> Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of > >> 'arm,armv8' compatible string > >> > >> Hi Pavel, > >> > >> Thank you for the feedback! > >> > >>> From: Pavel Machek <pavel@denx.de> > >>> Sent: 02 September 2019 10:01 > >>> Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of > >>> 'arm,armv8' compatible string > >>> > >>> On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: > >>>> Hi Pavel, > >>>> > >>>> I have put you in CC (and kept the ML as recipient this time > >>>> around), did you receive the patch with or without the space? > >>> > >>> I got just one copy of email, and it does not have [cip-dev] > >>> marking, so I assume it is the direct one. > >>> > >>> No extra space. > >> > >> Then it's down to the mailing list, somehow, this same email reached > >> the ML, with a space... > >> > https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315 > >> 8.html > >> https://patchwork.kernel.org/patch/11126171/ > >> > > > > Hmmm. There may be a problem in Mailman. > > > > Comparing the original patch > (https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh@k > ernel.org/raw) to ours: > > X-Mailman-Version: 2.1.21 (looks fine) > X-Mailman-Version: 2.1.12 (our potentially broken version) > > It looks like 2.1.21 is starting the wrapped around subject line only > with a single space while our version gained a tab. The latter is likely > the core if the issue. I would not expect this difference to be a > configuration option of mailman, rather an issue in the older version > Thank you for information. And the original patch thread is interesting. Each subject has space issues. Please see "Thread overview" at the bottom of the page. https://lore.kernel.org/linux-amlogic/2053cd60-479a-4219-2415-ebb6a860a8e7@kernel.org/t/ > HTH, > Jan > Best regards, Nobuhiro
On 05.09.19 03:16, nobuhiro1.iwamatsu@toshiba.co.jp wrote: > https://patchwork.kernel.org/patch/10754905/ > >> -----Original Message----- >> From: Jan Kiszka [mailto:jan.kiszka@siemens.com] >> Sent: Tuesday, September 3, 2019 10:56 PM >> To: iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ＯＳＴ) >> <nobuhiro1.iwamatsu@toshiba.co.jp>; fabrizio.castro@bp.renesas.com; >> pavel@denx.de >> Cc: cip-dev@lists.cip-project.org; biju.das@bp.renesas.com >> Subject: Re: [cip-dev] [PATCH resend] arm64: dts: Remove inconsistent >> use of 'arm, armv8' compatible string >> >> On 03.09.19 06:45, nobuhiro1.iwamatsu@toshiba.co.jp wrote: >>> Hi Fabrizio, >>> >>> Thanks for your test. >>> >>>> -----Original Message----- >>>> From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] >>>> Sent: Monday, September 2, 2019 6:05 PM >>>> To: Pavel Machek <pavel@denx.de> >>>> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das >>>> <biju.das@bp.renesas.com>; iwamatsu nobuhiro(岩松 信洋 ○ＳＷＣ□ >> ＯＳ >>>> Ｔ) <nobuhiro1.iwamatsu@toshiba.co.jp>; >> cip-dev@lists.cip-project.org >>>> Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of >>>> 'arm,armv8' compatible string >>>> >>>> Hi Pavel, >>>> >>>> Thank you for the feedback! >>>> >>>>> From: Pavel Machek <pavel@denx.de> >>>>> Sent: 02 September 2019 10:01 >>>>> Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of >>>>> 'arm,armv8' compatible string >>>>> >>>>> On Mon 2019-09-02 08:51:12, Fabrizio Castro wrote: >>>>>> Hi Pavel, >>>>>> >>>>>> I have put you in CC (and kept the ML as recipient this time >>>>>> around), did you receive the patch with or without the space? >>>>> >>>>> I got just one copy of email, and it does not have [cip-dev] >>>>> marking, so I assume it is the direct one. >>>>> >>>>> No extra space. >>>> >>>> Then it's down to the mailing list, somehow, this same email reached >>>> the ML, with a space... >>>> >> https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315 >>>> 8.html >>>> https://patchwork.kernel.org/patch/11126171/ >>>> >>> >>> Hmmm. There may be a problem in Mailman. >>> >> >> Comparing the original patch >> (https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh@k >> ernel.org/raw) to ours: >> >> X-Mailman-Version: 2.1.21 (looks fine) >> X-Mailman-Version: 2.1.12 (our potentially broken version) >> >> It looks like 2.1.21 is starting the wrapped around subject line only >> with a single space while our version gained a tab. The latter is likely >> the core if the issue. I would not expect this difference to be a >> configuration option of mailman, rather an issue in the older version >> > > Thank you for information. > > And the original patch thread is interesting. > Each subject has space issues. Please see "Thread overview" at the bottom of the page. > https://lore.kernel.org/linux-amlogic/2053cd60-479a-4219-2415-ebb6a860a8e7@kernel.org/t/ > Interesting. There seem to be more mail processing tools involved that decided to wrap at the comma, although there was no space following after it. Jan
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 1969649..a77de9e 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -61,7 +61,7 @@ #size-cells = <0>; a57_0: cpu@0 { - compatible = "arm,cortex-a57", "arm,armv8"; + compatible = "arm,cortex-a57"; reg = <0x0>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA57_CPU0>; @@ -71,7 +71,7 @@ }; a57_1: cpu@1 { - compatible = "arm,cortex-a57", "arm,armv8"; + compatible = "arm,cortex-a57"; reg = <0x1>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA57_CPU1>; @@ -81,7 +81,7 @@ }; a53_0: cpu@100 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; reg = <0x100>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA53_CPU0>; @@ -91,7 +91,7 @@ }; a53_1: cpu@101 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; reg = <0x101>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA53_CPU1>; @@ -101,7 +101,7 @@ }; a53_2: cpu@102 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; reg = <0x102>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA53_CPU2>; @@ -111,7 +111,7 @@ }; a53_3: cpu@103 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; reg = <0x103>; device_type = "cpu"; power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;