[4.19.y-cip,16/23] usb: typec: hd3ss3220_irq() can be static

Commit Message

Marian-Cristian Rotariu Feb. 18, 2020, 2:05 p.m. UTC

From: kbuild test robot <[e-mail]>

commit dd3fd317e2beb899cbffcf364de049b9f9a02db5 upstream.

Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
Signed-off-by: kbuild test robot <[e-mail]>
Link: https://lore.kernel.org/r/20191005215727.qfypxoswkiyu45ak@332d0cec05f4
Signed-off-by: Greg Kroah-Hartman <[e-mail]>
Signed-off-by: Marian-Cristian Rotariu <[e-mail]>
---
 drivers/usb/typec/hd3ss3220.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavel Machek Feb. 19, 2020, 8:20 a.m. UTC | #1

Hi!

> From: kbuild test robot <[e-mail]>
> 
> commit dd3fd317e2beb899cbffcf364de049b9f9a02db5 upstream.
> 
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
> Signed-off-by: kbuild test robot <[e-mail]>

This is not your fault and we should not attempt to fix it here, but
we normally require real, human names for Signed-off-by.

Best regards,
								Pavel

Marian-Cristian Rotariu Feb. 19, 2020, 7:15 p.m. UTC | #2

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: 19 February 2020 08:21
> To: Marian-Cristian Rotariu <[e-mail]>
> Cc: [e-mail]
> Subject: Re: [cip-dev] [PATCH 4.19.y-cip 16/23] usb: typec: hd3ss3220_irq()
> can be static
> 
> Hi!
> 
> > From: kbuild test robot <[e-mail]>
> >
> > commit dd3fd317e2beb899cbffcf364de049b9f9a02db5 upstream.
> >
> > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C
> > DRP port controller")
> > Signed-off-by: kbuild test robot <[e-mail]>
> 
> This is not your fault and we should not attempt to fix it here, but we
> normally require real, human names for Signed-off-by.

I will drop this in v2.

Thanks,
Marian

Pavel Machek Feb. 19, 2020, 9:40 p.m. UTC | #3

Hi!

> > > From: kbuild test robot <[e-mail]>
> > >
> > > commit dd3fd317e2beb899cbffcf364de049b9f9a02db5 upstream.
> > >
> > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C
> > > DRP port controller")
> > > Signed-off-by: kbuild test robot <[e-mail]>
> > 
> > This is not your fault and we should not attempt to fix it here, but we
> > normally require real, human names for Signed-off-by.
> 
> I will drop this in v2.

You can merge it with the previous patch, or you can keep it as is, it
is your choice. If mainline is okay with it, it should not create
problems for us, even if it is a bit non-standard.

Best regards,
								Pavel

Patch

diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 0ece5ed..658e6aa 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -120,7 +120,7 @@  static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
 	}
 }
 
-irqreturn_t hd3ss3220_irq(struct hd3ss3220 *hd3ss3220)
+static irqreturn_t hd3ss3220_irq(struct hd3ss3220 *hd3ss3220)
 {
 	int err;