From patchwork Tue Aug 11 14:40:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 11709297 X-Patchwork-Delegate: pavel@denx.de Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 102EC14E3 for ; Tue, 11 Aug 2020 14:42:48 +0000 (UTC) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96F3A206C3 for ; Tue, 11 Aug 2020 14:42:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.cip-project.org header.i=@lists.cip-project.org header.b="Mxda0knv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F3A206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bp.renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=bounce+64572+5109+4520428+8129116@lists.cip-project.org X-Received: by 127.0.0.2 with SMTP id VZI4YY4521763x7msFzdSfQ1; Tue, 11 Aug 2020 07:42:47 -0700 X-Received: from relmlie5.idc.renesas.com (relmlie5.idc.renesas.com [210.160.252.171]) by mx.groups.io with SMTP id smtpd.web10.16438.1597156846473846667 for ; Tue, 11 Aug 2020 07:40:46 -0700 X-IronPort-AV: E=Sophos;i="5.75,461,1589209200"; d="scan'208";a="54374513" X-Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 11 Aug 2020 23:40:43 +0900 X-Received: from localhost.localdomain (unknown [172.29.52.148]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 010984005E34; Tue, 11 Aug 2020 23:40:41 +0900 (JST) From: Biju Das To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu , Pavel Machek Cc: Chris Paterson , Biju Das , Prabhakar Mahadev Lad Subject: [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set Date: Tue, 11 Aug 2020 15:40:40 +0100 Message-Id: <20200811144040.4398-1-biju.das.jz@bp.renesas.com> Precedence: Bulk List-Unsubscribe: Sender: cip-dev@lists.cip-project.org List-Id: Mailing-List: list cip-dev@lists.cip-project.org; contact cip-dev+owner@lists.cip-project.org Delivered-To: mailing list cip-dev@lists.cip-project.org Reply-To: cip-dev@lists.cip-project.org X-Gm-Message-State: 9LAQodyBwR7y2wvWF5kqQaDMx4520428AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.cip-project.org; q=dns/txt; s=20140610; t=1597156967; bh=t0/4yuFxc3tkTOiBIJ0QCwyw714Fjo0jOxqjkObNF9Q=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Mxda0knvTODUzsUO6cnMi2joHqoC5Sl7CpxrCGBRUIZ5QSObP9tf+99Ns5U33fUbM2m llrTgYDlxVmTHS188fulgpIZtCgURxn4zbyhTlmHv3O2YpqNeKNHR/vMrwAHGAAM3WMKB fD8KgjP5pbLhhA0m3sLZ4oZKAYLlkwiyP1g= From: Laurent Pinchart commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream. The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in commit 6529007522de has a fallback stub when CONFIG_OF is not set, but the stub is declared in drm_of.h without a static inline. This causes multiple definitions of the function to be linked when the CONFIG_OF option isn't set. Fix it by making the stub static inline. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Reported-by: kbuild test robot Signed-off-by: Laurent Pinchart Reviewed-by: Fabrizio Castro Reviewed-by: Chris Wilson Signed-off-by: Dave Airlie Link: https://patchwork.freedesktop.org/patch/msgid/20191219103703.8547-1-laurent.pinchart+renesas@ideasonboard.com Signed-off-by: Biju Das Reported-by: kernel test robot --- include/drm/drm_of.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 8ec7ca6d2369..b9b093add92e 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np, return -EINVAL; } -int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, - const struct device_node *port2) +static inline int +drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, + const struct device_node *port2) { return -EINVAL; }