diff mbox series

[isar-cip-core,v2,3/3] testing: Add test.yml

Message ID 20200819044201.1255803-3-nobuhiro1.iwamatsu@toshiba.co.jp
State Changes Requested
Headers show
Series None | expand

Commit Message

Nobuhiro Iwamatsu Aug. 19, 2020, 4:42 a.m. UTC
Add YAML to add the test application to each images.
The following test applications will be added.
 - ltp
 - rt-tests
 - stress-ng

And this appends '-test' to the generated image filename.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
---
 kas/opt/test.yml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 kas/opt/test.yml

Comments

Jan Kiszka Aug. 19, 2020, 6:17 a.m. UTC | #1
On 19.08.20 06:42, Nobuhiro Iwamatsu wrote:
> Add YAML to add the test application to each images.
> The following test applications will be added.
>  - ltp
>  - rt-tests
>  - stress-ng
> 
> And this appends '-test' to the generated image filename.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  kas/opt/test.yml | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 kas/opt/test.yml
> 
> diff --git a/kas/opt/test.yml b/kas/opt/test.yml
> new file mode 100644
> index 0000000..75b257d
> --- /dev/null
> +++ b/kas/opt/test.yml
> @@ -0,0 +1,20 @@
> +#
> +# Copyright (c) Siemens AG, 2019
> +# Copyright (c) Toshiba Corporation, 2020
> +#
> +# Authors:
> +#  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> +#
> +# SPDX-License-Identifier: MIT
> +#
> +
> +header:
> +  version: 8
> +
> +local_conf_header:
> +  testing: |
> +    IMAGE_INSTALL += "ltp-full"
> +    IMAGE_PREINSTALL += "rt-tests stress-ng"
> +    DESCRIPTION_append = " with test packages"
> +    IMAGE_FULLNAME_append = "-test"
> +
> 

Ah, nice solution with the _append.

Can you follow up with a patch for CI that adds the test feature at
least to some of your images? I actually wonder if we shouldn't add it
to all, or even have to in case the CI images are directly used for testing.

Jan
Nobuhiro Iwamatsu Aug. 19, 2020, 6:31 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
> Sent: Wednesday, August 19, 2020 3:18 PM
> To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org
> Subject: Re: [isar-cip-core][PATCH v2 3/3] testing: Add test.yml
> 
> On 19.08.20 06:42, Nobuhiro Iwamatsu wrote:
> > Add YAML to add the test application to each images.
> > The following test applications will be added.
> >  - ltp
> >  - rt-tests
> >  - stress-ng
> >
> > And this appends '-test' to the generated image filename.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> >  kas/opt/test.yml | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 kas/opt/test.yml
> >
> > diff --git a/kas/opt/test.yml b/kas/opt/test.yml
> > new file mode 100644
> > index 0000000..75b257d
> > --- /dev/null
> > +++ b/kas/opt/test.yml
> > @@ -0,0 +1,20 @@
> > +#
> > +# Copyright (c) Siemens AG, 2019
> > +# Copyright (c) Toshiba Corporation, 2020
> > +#
> > +# Authors:
> > +#  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > +#
> > +# SPDX-License-Identifier: MIT
> > +#
> > +
> > +header:
> > +  version: 8
> > +
> > +local_conf_header:
> > +  testing: |
> > +    IMAGE_INSTALL += "ltp-full"
> > +    IMAGE_PREINSTALL += "rt-tests stress-ng"
> > +    DESCRIPTION_append = " with test packages"
> > +    IMAGE_FULLNAME_append = "-test"
> > +
> >
> 
> Ah, nice solution with the _append.
> 
> Can you follow up with a patch for CI that adds the test feature at
> least to some of your images? I actually wonder if we shouldn't add it
> to all, or even have to in case the CI images are directly used for testing.
> 

Yes, I planned to do it after it was applied.
I will add this to v3 patch series.

> Jan
> 

Best regards,
  Nobuhiro

> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5139): https://lists.cip-project.org/g/cip-dev/message/5139
Mute This Topic: https://lists.cip-project.org/mt/76280651/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jan Kiszka Aug. 19, 2020, 6:32 a.m. UTC | #3
On 19.08.20 08:31, nobuhiro1.iwamatsu@toshiba.co.jp wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
>> Sent: Wednesday, August 19, 2020 3:18 PM
>> To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org
>> Subject: Re: [isar-cip-core][PATCH v2 3/3] testing: Add test.yml
>>
>> On 19.08.20 06:42, Nobuhiro Iwamatsu wrote:
>>> Add YAML to add the test application to each images.
>>> The following test applications will be added.
>>>  - ltp
>>>  - rt-tests
>>>  - stress-ng
>>>
>>> And this appends '-test' to the generated image filename.
>>>
>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
>>> ---
>>>  kas/opt/test.yml | 20 ++++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>  create mode 100644 kas/opt/test.yml
>>>
>>> diff --git a/kas/opt/test.yml b/kas/opt/test.yml
>>> new file mode 100644
>>> index 0000000..75b257d
>>> --- /dev/null
>>> +++ b/kas/opt/test.yml
>>> @@ -0,0 +1,20 @@
>>> +#
>>> +# Copyright (c) Siemens AG, 2019
>>> +# Copyright (c) Toshiba Corporation, 2020
>>> +#
>>> +# Authors:
>>> +#  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
>>> +#
>>> +# SPDX-License-Identifier: MIT
>>> +#
>>> +
>>> +header:
>>> +  version: 8
>>> +
>>> +local_conf_header:
>>> +  testing: |
>>> +    IMAGE_INSTALL += "ltp-full"
>>> +    IMAGE_PREINSTALL += "rt-tests stress-ng"
>>> +    DESCRIPTION_append = " with test packages"
>>> +    IMAGE_FULLNAME_append = "-test"
>>> +
>>>
>>
>> Ah, nice solution with the _append.
>>
>> Can you follow up with a patch for CI that adds the test feature at
>> least to some of your images? I actually wonder if we shouldn't add it
>> to all, or even have to in case the CI images are directly used for testing.
>>
> 
> Yes, I planned to do it after it was applied.
> I will add this to v3 patch series.

No need to resend, the patches are already in next, locally. Just add
that patch on top.

Jan
Nobuhiro Iwamatsu Aug. 20, 2020, 8:27 a.m. UTC | #4
Hi,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org [mailto:cip-dev@lists.cip-project.org] On Behalf Of Jan Kiszka
> Sent: Wednesday, August 19, 2020 3:33 PM
> To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org
> Subject: Re: [cip-dev] [isar-cip-core][PATCH v2 3/3] testing: Add test.yml
> 

<snip>

> >>
> >> Ah, nice solution with the _append.
> >>
> >> Can you follow up with a patch for CI that adds the test feature at
> >> least to some of your images? I actually wonder if we shouldn't add it
> >> to all, or even have to in case the CI images are directly used for testing.
> >>
> >
> > Yes, I planned to do it after it was applied.
> > I will add this to v3 patch series.
> 
> No need to resend, the patches are already in next, locally. Just add
> that patch on top.
> 

Okay, I send a patch for CI only.

> Jan

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5160): https://lists.cip-project.org/g/cip-dev/message/5160
Mute This Topic: https://lists.cip-project.org/mt/76280651/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
diff mbox series

Patch

diff --git a/kas/opt/test.yml b/kas/opt/test.yml
new file mode 100644
index 0000000..75b257d
--- /dev/null
+++ b/kas/opt/test.yml
@@ -0,0 +1,20 @@ 
+#
+# Copyright (c) Siemens AG, 2019
+# Copyright (c) Toshiba Corporation, 2020
+#
+# Authors:
+#  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
+#
+# SPDX-License-Identifier: MIT
+#
+
+header:
+  version: 8
+
+local_conf_header:
+  testing: |
+    IMAGE_INSTALL += "ltp-full"
+    IMAGE_PREINSTALL += "rt-tests stress-ng"
+    DESCRIPTION_append = " with test packages"
+    IMAGE_FULLNAME_append = "-test"
+