diff mbox series

[4.19.y-cip,26/26] tools: PCI: Fix fd leakage

Message ID	20201020145732.30343-27-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State	Accepted
Headers	show Return-Path: <SRS0=aaUW=D3=lists.cip-project.org=bounce+64572+5623+4520388+8129055@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A57C121D7B From: "Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [cip-dev] [PATCH 4.19.y-cip 26/26] tools: PCI: Fix fd leakage Date: Tue, 20 Oct 2020 15:57:32 +0100 Message-Id: <20201020145732.30343-27-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20201020145732.30343-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20201020145732.30343-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: Bulk Sender: cip-dev@lists.cip-project.org Mailing-List: list cip-dev@lists.cip-project.org; contact cip-dev+owner@lists.cip-project.org Reply-To: cip-dev@lists.cip-project.org Content-Type: multipart/mixed; boundary="UQgL0BFUkSgvp4i9xvp8"
Series	Fixes and extension to PCIe EPF \| expand [4.19.y-cip,00/26] Fixes and extension to PCIe EPF [4.19.y-cip,01/26] PCI: endpoint: Add new pci_epc_ops to get EPC features [4.19.y-cip,02/26] PCI: dwc: Add ->get_features() callback function to dw_pcie_ep_ops [4.19.y-cip,03/26] PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops [4.19.y-cip,04/26] PCI: pci-dra7xx: Populate ->get_features() dw_pcie_ep_ops [4.19.y-cip,05/26] PCI: rockchip: Populate ->get_features() dw_pcie_ep_ops [4.19.y-cip,06/26] PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops [4.19.y-cip,07/26] PCI: endpoint: Add helper to get first unreserved BAR [4.19.y-cip,08/26] PCI: endpoint: Fix pci_epf_alloc_space() to set correct MEM TYPE flags [4.19.y-cip,09/26] PCI: pci-epf-test: Remove setting epf_bar flags in function driver [4.19.y-cip,10/26] PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is 64Bit [4.19.y-cip,11/26] PCI: pci-epf-test: Use pci_epc_get_features() to get EPC features [4.19.y-cip,12/26] PCI: cadence: Remove pci_epf_linkup() from Cadence EP driver [4.19.y-cip,13/26] PCI: rockchip: Remove pci_epf_linkup() from Rockchip EP driver [4.19.y-cip,14/26] PCI: designware-plat: Remove setting epc->features in Designware plat EP driver [4.19.y-cip,15/26] PCI: endpoint: Remove features member in struct pci_epc [4.19.y-cip,16/26] PCI: endpoint: Fix a potential NULL pointer dereference [4.19.y-cip,17/26] PCI: endpoint: Add support to specify alignment for buffers allocated to BARs [4.19.y-cip,18/26] PCI: endpoint: Set endpoint controller pointer to NULL [4.19.y-cip,19/26] PCI: endpoint: Allocate enough space for fixed size BAR [4.19.y-cip,20/26] PCI: endpoint: Skip odd BAR when skipping 64bit BAR [4.19.y-cip,21/26] PCI: endpoint: Clear BAR before freeing its space [4.19.y-cip,22/26] PCI: endpoint: Cast the page number to phys_addr_t [4.19.y-cip,23/26] PCI: endpoint: Fix clearing start entry in configfs [4.19.y-cip,24/26] PCI: dwc: Fix dw_pcie_ep_raise_msix_irq() to get correct MSI-X table address [4.19.y-cip,25/26] tools: PCI: Exit with error code when test fails [4.19.y-cip,26/26] tools: PCI: Fix fd leakage

Commit Message

Lad Prabhakar Oct. 20, 2020, 2:57 p.m. UTC

From: Hewenliang <hewenliang4@huawei.com>

commit 3c379a59b4795d7279d38c623e74b9790345a32b upstream.

We should close fd before the return of run_test.

Fixes: 3f2ed8134834 ("tools: PCI: Add a userspace tool to test PCI endpoint")
Signed-off-by: Hewenliang <hewenliang4@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 tools/pci/pcitest.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index b7e3b6a64956..9f3d2e584ce4 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -140,6 +140,7 @@  static int run_test(struct pci_test *test)
 	}
 
 	fflush(stdout);
+	close(fd);
 	return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
 }