diff mbox series

[isar-cip-core,v2] classes/image_uuid: Generate new uuid if a new package is added

Message ID 20201125084433.1277-1-Quirin.Gylstorff@siemens.com (mailing list archive)
State Not Applicable
Headers show
Series [isar-cip-core,v2] classes/image_uuid: Generate new uuid if a new package is added | expand

Commit Message

Gylstorff Quirin Nov. 25, 2020, 8:44 a.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

BB_BASEHASH only includes the task itself and its metadata.
Dependencies are not taken into account when this hash is
generated which means updating a package will not generate a new
UUID.

BB_TASKHASH takes the changes into account.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 classes/image_uuid.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Nov. 26, 2020, 7:28 a.m. UTC | #1
On 25.11.20 09:44, Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> BB_BASEHASH only includes the task itself and its metadata.
> Dependencies are not taken into account when this hash is
> generated which means updating a package will not generate a new
> UUID.
> 
> BB_TASKHASH takes the changes into account.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  classes/image_uuid.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/image_uuid.bbclass b/classes/image_uuid.bbclass
> index d5337b8..2813ed9 100644
> --- a/classes/image_uuid.bbclass
> +++ b/classes/image_uuid.bbclass
> @@ -12,7 +12,7 @@
>  def generate_image_uuid(d):
>      import uuid
>  
> -    base_hash = d.getVar("BB_BASEHASH_task-do_rootfs_install", True)
> +    base_hash = d.getVar("BB_TASKHASH", True)
>      if base_hash is None:
>          return None
>      return str(uuid.UUID(base_hash[:32], version=4))
> 

Thanks, applied.

Jan
diff mbox series

Patch

diff --git a/classes/image_uuid.bbclass b/classes/image_uuid.bbclass
index d5337b8..2813ed9 100644
--- a/classes/image_uuid.bbclass
+++ b/classes/image_uuid.bbclass
@@ -12,7 +12,7 @@ 
 def generate_image_uuid(d):
     import uuid
 
-    base_hash = d.getVar("BB_BASEHASH_task-do_rootfs_install", True)
+    base_hash = d.getVar("BB_TASKHASH", True)
     if base_hash is None:
         return None
     return str(uuid.UUID(base_hash[:32], version=4))