| Message ID | 20201130141916.8211-8-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Nobuhiro Iwamatsu |
| Headers | show |
| Series | Renesas RZ/G1x add SoC detection support | expand |
Hi, > -----Original Message----- > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > Sent: Monday, November 30, 2020 11:19 PM > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > Cc: Biju Das <biju.das.jz@bp.renesas.com> > Subject: [PATCH 4.4.y-cip 07/11] ARM: dts: r8a7744: Add device node for PRR > > Add a device node for the Product Register, which provides SoC product > and revision information. > > Changes are already present in upstream but the PRR node is part of > initial SoC DTSI and cannot be individually backported hence this > new commit. I thought it would be good to include the relevant commit ID. For example, this should be included as 6929dfc5918049272e07653b1760b0b305f098e6, but has been removed by 605e89568fafe57c1791219b411ab0771981beea. If you accept this suggestion, please add the same comment to other similar patches. Best regards, Nobuhiro > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > arch/arm/boot/dts/r8a7744.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi > index 079f46f17049..312c9aae8a10 100644 > --- a/arch/arm/boot/dts/r8a7744.dtsi > +++ b/arch/arm/boot/dts/r8a7744.dtsi > @@ -1526,6 +1526,11 @@ > }; > }; > > + prr: chipid@ff000044 { > + compatible = "renesas,prr"; > + reg = <0 0xff000044 0 4>; > + }; > + > cmt0: timer@ffca0000 { > compatible = "renesas,cmt-48-r8a7744", > "renesas,cmt-48-gen2"; > -- > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5910): https://lists.cip-project.org/g/cip-dev/message/5910 Mute This Topic: https://lists.cip-project.org/mt/78608808/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Nobuhiro, Thank you for the review. > -----Original Message----- > From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp> > Sent: 01 December 2020 00:52 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; cip-dev@lists.cip-project.org; > pavel@denx.de > Cc: Biju Das <biju.das.jz@bp.renesas.com> > Subject: RE: [PATCH 4.4.y-cip 07/11] ARM: dts: r8a7744: Add device node for PRR > > Hi, > > > -----Original Message----- > > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > > Sent: Monday, November 30, 2020 11:19 PM > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de> > > Cc: Biju Das <biju.das.jz@bp.renesas.com> > > Subject: [PATCH 4.4.y-cip 07/11] ARM: dts: r8a7744: Add device node for PRR > > > > Add a device node for the Product Register, which provides SoC product > > and revision information. > > > > Changes are already present in upstream but the PRR node is part of > > initial SoC DTSI and cannot be individually backported hence this > > new commit. > > I thought it would be good to include the relevant commit ID. > For example, this should be included as 6929dfc5918049272e07653b1760b0b305f098e6, > but has been removed by 605e89568fafe57c1791219b411ab0771981beea. > > If you accept this suggestion, please add the same comment to other similar patches. > Agreed I will update the commit message and repost. Cheers, Prabhakar > Best regards, > Nobuhiro > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > arch/arm/boot/dts/r8a7744.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi > > index 079f46f17049..312c9aae8a10 100644 > > --- a/arch/arm/boot/dts/r8a7744.dtsi > > +++ b/arch/arm/boot/dts/r8a7744.dtsi > > @@ -1526,6 +1526,11 @@ > > }; > > }; > > > > + prr: chipid@ff000044 { > > + compatible = "renesas,prr"; > > + reg = <0 0xff000044 0 4>; > > + }; > > + > > cmt0: timer@ffca0000 { > > compatible = "renesas,cmt-48-r8a7744", > > "renesas,cmt-48-gen2"; > > -- > > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5912): https://lists.cip-project.org/g/cip-dev/message/5912 Mute This Topic: https://lists.cip-project.org/mt/78608808/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi index 079f46f17049..312c9aae8a10 100644 --- a/arch/arm/boot/dts/r8a7744.dtsi +++ b/arch/arm/boot/dts/r8a7744.dtsi @@ -1526,6 +1526,11 @@ }; }; + prr: chipid@ff000044 { + compatible = "renesas,prr"; + reg = <0 0xff000044 0 4>; + }; + cmt0: timer@ffca0000 { compatible = "renesas,cmt-48-r8a7744", "renesas,cmt-48-gen2";
Add a device node for the Product Register, which provides SoC product and revision information. Changes are already present in upstream but the PRR node is part of initial SoC DTSI and cannot be individually backported hence this new commit. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- arch/arm/boot/dts/r8a7744.dtsi | 5 +++++ 1 file changed, 5 insertions(+)