diff mbox series

[4.19.y-cip] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property

Message ID 20210104095848.7111-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Accepted
Headers show
Series [4.19.y-cip] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property | expand

Commit Message

Lad Prabhakar Jan. 4, 2021, 9:58 a.m. UTC
From: Geert Uytterhoeven <geert+renesas@glider.be>

commit f3c6c120614cfb02827ee7bbe6c4240847cc5f12 upstream.

The R-Car PCIe controller does not use interrupts when configured
for endpoint mode, hence the bindings do not document the interrupts
property.  However, all DTS files provide interrupts properties, and
thus fail to validate.

Fix this by documenting the interrupts property.

Fixes: 4c0f80920923f103 ("dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20201209101231.2206479-1-geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Pavel Machek Jan. 4, 2021, 12:22 p.m. UTC | #1
Hi!

> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> commit f3c6c120614cfb02827ee7bbe6c4240847cc5f12 upstream.
> 
> The R-Car PCIe controller does not use interrupts when configured
> for endpoint mode, hence the bindings do not document the interrupts
> property.  However, all DTS files provide interrupts properties, and
> thus fail to validate.
> 
> Fix this by documenting the interrupts property.

Looks good to me. I can apply it to 4.19-cip if there are no other
comments.

Best regards,
								Pavel

> --- a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> @@ -32,6 +32,10 @@ properties:
>        - const: memory2
>        - const: memory3
>  
> +  interrupts:
> +    minItems: 3
> +    maxItems: 3
> +
>    power-domains:
>      maxItems: 1
>  
> @@ -53,6 +57,7 @@ required:
>    - compatible
>    - reg
>    - reg-names
> +  - interrupts
>    - resets
>    - power-domains
>    - clocks
> @@ -62,6 +67,7 @@ required:
>  examples:
>    - |
>      #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>      #include <dt-bindings/power/r8a774c0-sysc.h>
>  
>       pcie0_ep: pcie-ep@fe000000 {
> @@ -73,6 +79,9 @@ examples:
>                    <0x30000000 0x8000000>,
>                    <0x38000000 0x8000000>;
>              reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3";
> +            interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
>              resets = <&cpg 319>;
>              power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
>              clocks = <&cpg CPG_MOD 319>;
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
index a059c96c294b..10e186c676ae 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
@@ -32,6 +32,10 @@  properties:
       - const: memory2
       - const: memory3
 
+  interrupts:
+    minItems: 3
+    maxItems: 3
+
   power-domains:
     maxItems: 1
 
@@ -53,6 +57,7 @@  required:
   - compatible
   - reg
   - reg-names
+  - interrupts
   - resets
   - power-domains
   - clocks
@@ -62,6 +67,7 @@  required:
 examples:
   - |
     #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/power/r8a774c0-sysc.h>
 
      pcie0_ep: pcie-ep@fe000000 {
@@ -73,6 +79,9 @@  examples:
                   <0x30000000 0x8000000>,
                   <0x38000000 0x8000000>;
             reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3";
+            interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+                         <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
+                         <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
             resets = <&cpg 319>;
             power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
             clocks = <&cpg CPG_MOD 319>;