| Message ID | 20210309163656.20944-15-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Nobuhiro Iwamatsu |
| Headers | show |
| Series | Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support | expand |
Hi! > With this commit the sensor is able to enter LP-11 mode during power up, > as expected by some CSI-2 controllers. > > [1] https://publiclab.org/system/images/photos/000/023/294/original/ > RASPBERRY_PI_CAMERA_V2_DATASHEET_IMX219PQH5_7.0.0_Datasheet_XXX.PDF > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > drivers/media/i2c/imx219.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index c67b2cf5c32c..f1ae93569542 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -1224,6 +1224,23 @@ static int imx219_probe(struct i2c_client *client) > /* Set default mode to max resolution */ > imx219->mode = &supported_modes[0]; > > + /* sensor doesn't enter LP-11 state upon power up until and unless > + * streaming is started, so upon power up switch the modes to: > + * streaming -> standby > + */ /* * Sensor... would be the usual commment style. Best regards, Pavel
Hi Pavel, Thank you for the review. > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: 09 March 2021 19:42 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek > <pavel@denx.de>; Biju Das <biju.das.jz@bp.renesas.com> > Subject: Re: [PATCH 4.19.y-cip 14/40] media: i2c: imx219: Fix power sequence > > Hi! > > > With this commit the sensor is able to enter LP-11 mode during power up, > > as expected by some CSI-2 controllers. > > > > [1] https://publiclab.org/system/images/photos/000/023/294/original/ > > RASPBERRY_PI_CAMERA_V2_DATASHEET_IMX219PQH5_7.0.0_Datasheet_XXX.PDF > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > drivers/media/i2c/imx219.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > > index c67b2cf5c32c..f1ae93569542 100644 > > --- a/drivers/media/i2c/imx219.c > > +++ b/drivers/media/i2c/imx219.c > > @@ -1224,6 +1224,23 @@ static int imx219_probe(struct i2c_client *client) > > /* Set default mode to max resolution */ > > imx219->mode = &supported_modes[0]; > > > > + /* sensor doesn't enter LP-11 state upon power up until and unless > > + * streaming is started, so upon power up switch the modes to: > > + * streaming -> standby > > + */ > > /* > * Sensor... > > would be the usual commment style. > Agreed, will have to fix up-stream. Cheers, Prabhakar > Best regards, > Pavel > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6265): https://lists.cip-project.org/g/cip-dev/message/6265 Mute This Topic: https://lists.cip-project.org/mt/81205358/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index c67b2cf5c32c..f1ae93569542 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -1224,6 +1224,23 @@ static int imx219_probe(struct i2c_client *client) /* Set default mode to max resolution */ imx219->mode = &supported_modes[0]; + /* sensor doesn't enter LP-11 state upon power up until and unless + * streaming is started, so upon power up switch the modes to: + * streaming -> standby + */ + ret = imx219_write_reg(imx219, IMX219_REG_MODE_SELECT, + IMX219_REG_VALUE_08BIT, IMX219_MODE_STREAMING); + if (ret < 0) + goto error_power_off; + usleep_range(100, 110); + + /* put sensor back to standby mode */ + ret = imx219_write_reg(imx219, IMX219_REG_MODE_SELECT, + IMX219_REG_VALUE_08BIT, IMX219_MODE_STANDBY); + if (ret < 0) + goto error_power_off; + usleep_range(100, 110); + ret = imx219_init_controls(imx219); if (ret) goto error_power_off;