| Message ID | 20210809102945.17824-1-Quirin.Gylstorff@siemens.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [isar-cip-core] swupdate-config: Remove runtime dependency efibootguard-dev | expand |
On 09.08.21 12:29, Q. Gylstorff wrote: > From: Quirin Gylstorff <quirin.gylstorff@siemens.com> > > efibootguard-dev is only a build time dependency and > not an runtime dependency. > > Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> > --- > classes/swupdate-config.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass > index dfa3579..e4879c7 100644 > --- a/classes/swupdate-config.bbclass > +++ b/classes/swupdate-config.bbclass > @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua" > > KFEATURE_efibootguard = "" > KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev" > -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev" > +KFEATURE_efibootguard[DEBIAN_DEPENDS] = "" > KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev" > KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet" > > -dev makes no sense, but don't we have any dep on libs? Or are they statically linked? Jan
On 8/9/21 2:54 PM, Jan Kiszka wrote: > On 09.08.21 12:29, Q. Gylstorff wrote: >> From: Quirin Gylstorff <quirin.gylstorff@siemens.com> >> >> efibootguard-dev is only a build time dependency and >> not an runtime dependency. >> >> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> >> --- >> classes/swupdate-config.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass >> index dfa3579..e4879c7 100644 >> --- a/classes/swupdate-config.bbclass >> +++ b/classes/swupdate-config.bbclass >> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua" >> >> KFEATURE_efibootguard = "" >> KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev" >> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev" >> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = "" >> KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev" >> KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet" >> >> > > -dev makes no sense, but don't we have any dep on libs? Or are they > statically linked? It is statically linked - efibootguard-dev contains only libebgenv.a. Quirin > > Jan > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6665): https://lists.cip-project.org/g/cip-dev/message/6665 Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
On 09.08.21 15:49, Gylstorff Quirin wrote: > > > On 8/9/21 2:54 PM, Jan Kiszka wrote: >> On 09.08.21 12:29, Q. Gylstorff wrote: >>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com> >>> >>> efibootguard-dev is only a build time dependency and >>> not an runtime dependency. >>> >>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> >>> --- >>> classes/swupdate-config.bbclass | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/classes/swupdate-config.bbclass >>> b/classes/swupdate-config.bbclass >>> index dfa3579..e4879c7 100644 >>> --- a/classes/swupdate-config.bbclass >>> +++ b/classes/swupdate-config.bbclass >>> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua" >>> KFEATURE_efibootguard = "" >>> KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev" >>> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev" >>> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = "" >>> KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev" >>> KFEATURE_efibootguard[KCONFIG_SNIPPETS] = >>> "file://swupdate_defconfig_efibootguard.snippet" >>> >> >> -dev makes no sense, but don't we have any dep on libs? Or are they >> statically linked? > > It is statically linked - efibootguard-dev contains only libebgenv.a. > Ah, yeah, part the SWUpdate's problems... Thanks, applied. Jan
> >>> efibootguard-dev is only a build time dependency and > >>> not an runtime dependency. > >>> > >>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> > >>> --- > >>> classes/swupdate-config.bbclass | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/classes/swupdate-config.bbclass > >>> b/classes/swupdate-config.bbclass > >>> index dfa3579..e4879c7 100644 > >>> --- a/classes/swupdate-config.bbclass > >>> +++ b/classes/swupdate-config.bbclass > >>> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua" > >>> KFEATURE_efibootguard = "" > >>> KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev" > >>> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev" > >>> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = "" > >>> KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev" > >>> KFEATURE_efibootguard[KCONFIG_SNIPPETS] = > >>> "file://swupdate_defconfig_efibootguard.snippet" > >>> > >> > >> -dev makes no sense, but don't we have any dep on libs? Or are they > >> statically linked? > > > > It is statically linked - efibootguard-dev contains only libebgenv.a. > > > > Ah, yeah, part the SWUpdate's problems... Well, meanwhile, this pattern has been deprecated in favor of using https://github.com/sbabic/libubootenv I guess it's about time for EFI Boot Guard to catch up.. Kind regards, Christian
diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass index dfa3579..e4879c7 100644 --- a/classes/swupdate-config.bbclass +++ b/classes/swupdate-config.bbclass @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua" KFEATURE_efibootguard = "" KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev" -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev" +KFEATURE_efibootguard[DEBIAN_DEPENDS] = "" KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev" KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"