diff mbox series

[isar-cip-core] python3-shtab: add export to the DEB_BUILD_PROFILES

Message ID 20220325083408.4080473-1-Srinuvasan_A@mentor.com (mailing list archive)
State New
Headers show
Series [isar-cip-core] python3-shtab: add export to the DEB_BUILD_PROFILES | expand

Commit Message

Srinuvasan A March 25, 2022, 8:34 a.m. UTC
From: Srinuvasan A <srinuvasan_a@mentor.com>

When we build this recipes in downstream layer the DEB_BUILD_PROFILES not
able to find by rule file hence it is not set the required build
profiles.

Here we disable the tests `PYBUILD_DISABLE=test`, but due to this
unavailability of DEB_BUILD_PROFILES in rule file it is building along
with the test hence it's getting failed like "Not able to import module
pytest"

Exported this one to access from rule file.

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 recipes-python/shtab/python3-shtab_1.4.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka March 25, 2022, 11:39 a.m. UTC | #1
On 25.03.22 09:34, Srinuvasan A wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> When we build this recipes in downstream layer the DEB_BUILD_PROFILES not
> able to find by rule file hence it is not set the required build
> profiles.
> 
> Here we disable the tests `PYBUILD_DISABLE=test`, but due to this
> unavailability of DEB_BUILD_PROFILES in rule file it is building along
> with the test hence it's getting failed like "Not able to import module
> pytest"
> 
> Exported this one to access from rule file.
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  recipes-python/shtab/python3-shtab_1.4.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-python/shtab/python3-shtab_1.4.2.bb b/recipes-python/shtab/python3-shtab_1.4.2.bb
> index ce83d6b..554afd3 100644
> --- a/recipes-python/shtab/python3-shtab_1.4.2.bb
> +++ b/recipes-python/shtab/python3-shtab_1.4.2.bb
> @@ -27,7 +27,7 @@ DEBIAN_BUILD_DEPENDS = " \
>      python3-setuptools-scm:native, \
>      "
>  
> -DEB_BUILD_PROFILES = "nocheck"
> +export DEB_BUILD_PROFILES = "nocheck"
>  
>  do_prepare_build[cleandirs] += "${S}/debian"
>  do_prepare_build() {

I lost overview: Do we need to export now (but Isar does not)? Will we
have to with upcoming sbuild? If we only had to with past Isar, this
would remain a downstream topic.

Jan
Srinuvasan Arjunan March 25, 2022, 11:53 a.m. UTC | #2
On Fri, Mar 25, 2022 at 5:09 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 25.03.22 09:34, Srinuvasan A wrote:
> > From: Srinuvasan A <srinuvasan_a@mentor.com>
> >
> > When we build this recipes in downstream layer the DEB_BUILD_PROFILES not
> > able to find by rule file hence it is not set the required build
> > profiles.
> >
> > Here we disable the tests `PYBUILD_DISABLE=test`, but due to this
> > unavailability of DEB_BUILD_PROFILES in rule file it is building along
> > with the test hence it's getting failed like "Not able to import module
> > pytest"
> >
> > Exported this one to access from rule file.
> >
> > Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> > ---
> >  recipes-python/shtab/python3-shtab_1.4.2.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-python/shtab/python3-shtab_1.4.2.bb
> b/recipes-python/shtab/python3-shtab_1.4.2.bb
> > index ce83d6b..554afd3 100644
> > --- a/recipes-python/shtab/python3-shtab_1.4.2.bb
> > +++ b/recipes-python/shtab/python3-shtab_1.4.2.bb
> > @@ -27,7 +27,7 @@ DEBIAN_BUILD_DEPENDS = " \
> >      python3-setuptools-scm:native, \
> >      "
> >
> > -DEB_BUILD_PROFILES = "nocheck"
> > +export DEB_BUILD_PROFILES = "nocheck"
> >
> >  do_prepare_build[cleandirs] += "${S}/debian"
> >  do_prepare_build() {
>
> I lost overview: Do we need to export now (but Isar does not)? Will we
> have to with upcoming sbuild? If we only had to with past Isar, this
> would remain a downstream topic.


  Thanks jan for the confirmation, yes still we were using old ISAR in our
downstream layer, let me create a patch in the downstream layer.

>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7823):
> https://lists.cip-project.org/g/cip-dev/message/7823
> Mute This Topic: https://lists.cip-project.org/mt/90018409/5367685
> Group Owner: cip-dev+owner@lists.cip-project.org
> Unsubscribe:
> https://lists.cip-project.org/g/cip-dev/leave/9347598/5367685/1965380532/xyzzy
> [srinuvasanasv@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/recipes-python/shtab/python3-shtab_1.4.2.bb b/recipes-python/shtab/python3-shtab_1.4.2.bb
index ce83d6b..554afd3 100644
--- a/recipes-python/shtab/python3-shtab_1.4.2.bb
+++ b/recipes-python/shtab/python3-shtab_1.4.2.bb
@@ -27,7 +27,7 @@  DEBIAN_BUILD_DEPENDS = " \
     python3-setuptools-scm:native, \
     "
 
-DEB_BUILD_PROFILES = "nocheck"
+export DEB_BUILD_PROFILES = "nocheck"
 
 do_prepare_build[cleandirs] += "${S}/debian"
 do_prepare_build() {