diff mbox series

[isar-cip-core,3/3] recipes-core/ltp: Disable autotest

Message ID 20220607135016.1856603-4-Vijaikumar_Kanagarajan@mentor.com (mailing list archive)
State New
Headers show
Series Update ltp | expand

Commit Message

Vijai Kumar K June 7, 2022, 1:50 p.m. UTC
Fixes the following error during cross-build.

Makefile:207: *** running tests on cross-compile build not supported.  Stop.

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 recipes-core/ltp/files/debian/rules | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jan Kiszka June 7, 2022, 3:15 p.m. UTC | #1
On 07.06.22 15:50, Vijai Kumar K wrote:
> Fixes the following error during cross-build.
> 
> Makefile:207: *** running tests on cross-compile build not supported.  Stop.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>  recipes-core/ltp/files/debian/rules | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-core/ltp/files/debian/rules b/recipes-core/ltp/files/debian/rules
> index a485615..06b9070 100755
> --- a/recipes-core/ltp/files/debian/rules
> +++ b/recipes-core/ltp/files/debian/rules
> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
>  
>  override_dh_auto_configure:
>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
> +
> +override_dh_auto_test:

Was that already the case with the previous version? If not, this should
probably be moved the front of the series, right?

Jan
Vijai Kumar K June 7, 2022, 3:23 p.m. UTC | #2
> -----Original Message-----
> From: Jan Kiszka <jan.kiszka@siemens.com>
> Sent: 07 June 2022 20:46
> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
> 
> On 07.06.22 15:50, Vijai Kumar K wrote:
> > Fixes the following error during cross-build.
> >
> > Makefile:207: *** running tests on cross-compile build not supported.
> Stop.
> >
> > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > ---
> >  recipes-core/ltp/files/debian/rules | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/recipes-core/ltp/files/debian/rules
> > b/recipes-core/ltp/files/debian/rules
> > index a485615..06b9070 100755
> > --- a/recipes-core/ltp/files/debian/rules
> > +++ b/recipes-core/ltp/files/debian/rules
> > @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
> >
> >  override_dh_auto_configure:
> >  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
> > +
> > +override_dh_auto_test:
> 
> Was that already the case with the previous version? If not, this should
> probably be moved the front of the series, right?

The previous version did not build successfully. The build was broken.
Since I was upreving, I did not dig much on why it failed.

Thanks,
Vijai Kumar K

> 
> Jan
> 
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
Jan Kiszka June 7, 2022, 3:52 p.m. UTC | #3
On 07.06.22 17:23, Kanagarajan, Vijaikumar wrote:
> 
> 
>> -----Original Message-----
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>> Sent: 07 June 2022 20:46
>> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
>> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
>> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
>>
>> On 07.06.22 15:50, Vijai Kumar K wrote:
>>> Fixes the following error during cross-build.
>>>
>>> Makefile:207: *** running tests on cross-compile build not supported.
>> Stop.
>>>
>>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
>>> ---
>>>  recipes-core/ltp/files/debian/rules | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/recipes-core/ltp/files/debian/rules
>>> b/recipes-core/ltp/files/debian/rules
>>> index a485615..06b9070 100755
>>> --- a/recipes-core/ltp/files/debian/rules
>>> +++ b/recipes-core/ltp/files/debian/rules
>>> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
>>>
>>>  override_dh_auto_configure:
>>>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
>>> +
>>> +override_dh_auto_test:
>>
>> Was that already the case with the previous version? If not, this should
>> probably be moved the front of the series, right?
> 
> The previous version did not build successfully. The build was broken.
> Since I was upreving, I did not dig much on why it failed.
> 

OK, then we can keep the ordering.

Jan
Jan Kiszka June 7, 2022, 4:14 p.m. UTC | #4
On 07.06.22 17:52, Jan Kiszka wrote:
> On 07.06.22 17:23, Kanagarajan, Vijaikumar wrote:
>>
>>
>>> -----Original Message-----
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>> Sent: 07 June 2022 20:46
>>> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
>>> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
>>> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
>>>
>>> On 07.06.22 15:50, Vijai Kumar K wrote:
>>>> Fixes the following error during cross-build.
>>>>
>>>> Makefile:207: *** running tests on cross-compile build not supported.
>>> Stop.
>>>>
>>>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
>>>> ---
>>>>  recipes-core/ltp/files/debian/rules | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/recipes-core/ltp/files/debian/rules
>>>> b/recipes-core/ltp/files/debian/rules
>>>> index a485615..06b9070 100755
>>>> --- a/recipes-core/ltp/files/debian/rules
>>>> +++ b/recipes-core/ltp/files/debian/rules
>>>> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
>>>>
>>>>  override_dh_auto_configure:
>>>>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
>>>> +
>>>> +override_dh_auto_test:
>>>
>>> Was that already the case with the previous version? If not, this should
>>> probably be moved the front of the series, right?
>>
>> The previous version did not build successfully. The build was broken.
>> Since I was upreving, I did not dig much on why it failed.
>>
> 
> OK, then we can keep the ordering.
> 

Hmm, just realized that we are not testing this recipe in CI. We should
probably enable kas/opt/test.yml for some representative target(s) to
close this gap.

Jan
Jan Kiszka June 7, 2022, 4:18 p.m. UTC | #5
On 07.06.22 18:14, Jan Kiszka wrote:
> On 07.06.22 17:52, Jan Kiszka wrote:
>> On 07.06.22 17:23, Kanagarajan, Vijaikumar wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>> Sent: 07 June 2022 20:46
>>>> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
>>>> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
>>>> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
>>>>
>>>> On 07.06.22 15:50, Vijai Kumar K wrote:
>>>>> Fixes the following error during cross-build.
>>>>>
>>>>> Makefile:207: *** running tests on cross-compile build not supported.
>>>> Stop.
>>>>>
>>>>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
>>>>> ---
>>>>>  recipes-core/ltp/files/debian/rules | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/recipes-core/ltp/files/debian/rules
>>>>> b/recipes-core/ltp/files/debian/rules
>>>>> index a485615..06b9070 100755
>>>>> --- a/recipes-core/ltp/files/debian/rules
>>>>> +++ b/recipes-core/ltp/files/debian/rules
>>>>> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
>>>>>
>>>>>  override_dh_auto_configure:
>>>>>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
>>>>> +
>>>>> +override_dh_auto_test:
>>>>
>>>> Was that already the case with the previous version? If not, this should
>>>> probably be moved the front of the series, right?
>>>
>>> The previous version did not build successfully. The build was broken.
>>> Since I was upreving, I did not dig much on why it failed.
>>>
>>
>> OK, then we can keep the ordering.
>>
> 
> Hmm, just realized that we are not testing this recipe in CI. We should
> probably enable kas/opt/test.yml for some representative target(s) to
> close this gap.
> 

Err, no, we are building that ("extension: test", see e.g.
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/2554473964). Now
I'm confused, specifically as I've seen build issues locally as well.

Jan
Jan Kiszka June 7, 2022, 5:38 p.m. UTC | #6
On 07.06.22 18:18, Jan Kiszka wrote:
> On 07.06.22 18:14, Jan Kiszka wrote:
>> On 07.06.22 17:52, Jan Kiszka wrote:
>>> On 07.06.22 17:23, Kanagarajan, Vijaikumar wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>> Sent: 07 June 2022 20:46
>>>>> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
>>>>> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
>>>>> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
>>>>>
>>>>> On 07.06.22 15:50, Vijai Kumar K wrote:
>>>>>> Fixes the following error during cross-build.
>>>>>>
>>>>>> Makefile:207: *** running tests on cross-compile build not supported.
>>>>> Stop.
>>>>>>
>>>>>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
>>>>>> ---
>>>>>>  recipes-core/ltp/files/debian/rules | 2 ++
>>>>>>  1 file changed, 2 insertions(+)
>>>>>>
>>>>>> diff --git a/recipes-core/ltp/files/debian/rules
>>>>>> b/recipes-core/ltp/files/debian/rules
>>>>>> index a485615..06b9070 100755
>>>>>> --- a/recipes-core/ltp/files/debian/rules
>>>>>> +++ b/recipes-core/ltp/files/debian/rules
>>>>>> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
>>>>>>
>>>>>>  override_dh_auto_configure:
>>>>>>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
>>>>>> +
>>>>>> +override_dh_auto_test:
>>>>>
>>>>> Was that already the case with the previous version? If not, this should
>>>>> probably be moved the front of the series, right?
>>>>
>>>> The previous version did not build successfully. The build was broken.
>>>> Since I was upreving, I did not dig much on why it failed.
>>>>
>>>
>>> OK, then we can keep the ordering.
>>>
>>
>> Hmm, just realized that we are not testing this recipe in CI. We should
>> probably enable kas/opt/test.yml for some representative target(s) to
>> close this gap.
>>
> 
> Err, no, we are building that ("extension: test", see e.g.
> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/2554473964). Now
> I'm confused, specifically as I've seen build issues locally as well.
> 

buster vs. bullseye: the former worked (as tested in CI), the latter was
broken.

As suspected, patch 3 needed to go before patch 1 - or folded into it. I
did the latter while merging.

Thanks,
Jan
Vijai Kumar K June 7, 2022, 6:10 p.m. UTC | #7
> -----Original Message-----
> From: Jan Kiszka <jan.kiszka@siemens.com>
> Sent: 07 June 2022 23:08
> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable autotest
> 
> On 07.06.22 18:18, Jan Kiszka wrote:
> > On 07.06.22 18:14, Jan Kiszka wrote:
> >> On 07.06.22 17:52, Jan Kiszka wrote:
> >>> On 07.06.22 17:23, Kanagarajan, Vijaikumar wrote:
> >>>>
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>> Sent: 07 June 2022 20:46
> >>>>> To: Kanagarajan, Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>;
> >>>>> quirin.gylstorff@siemens.com; cip-dev@lists.cip-project.org
> >>>>> Subject: Re: [isar-cip-core][PATCH 3/3] recipes-core/ltp: Disable
> >>>>> autotest
> >>>>>
> >>>>> On 07.06.22 15:50, Vijai Kumar K wrote:
> >>>>>> Fixes the following error during cross-build.
> >>>>>>
> >>>>>> Makefile:207: *** running tests on cross-compile build not
> supported.
> >>>>> Stop.
> >>>>>>
> >>>>>> Signed-off-by: Vijai Kumar K
> <Vijaikumar_Kanagarajan@mentor.com>
> >>>>>> ---
> >>>>>>  recipes-core/ltp/files/debian/rules | 2 ++
> >>>>>>  1 file changed, 2 insertions(+)
> >>>>>>
> >>>>>> diff --git a/recipes-core/ltp/files/debian/rules
> >>>>>> b/recipes-core/ltp/files/debian/rules
> >>>>>> index a485615..06b9070 100755
> >>>>>> --- a/recipes-core/ltp/files/debian/rules
> >>>>>> +++ b/recipes-core/ltp/files/debian/rules
> >>>>>> @@ -8,3 +8,5 @@ LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
> >>>>>>
> >>>>>>  override_dh_auto_configure:
> >>>>>>  	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
> >>>>>> +
> >>>>>> +override_dh_auto_test:
> >>>>>
> >>>>> Was that already the case with the previous version? If not, this
> >>>>> should probably be moved the front of the series, right?
> >>>>
> >>>> The previous version did not build successfully. The build was broken.
> >>>> Since I was upreving, I did not dig much on why it failed.
> >>>>
> >>>
> >>> OK, then we can keep the ordering.
> >>>
> >>
> >> Hmm, just realized that we are not testing this recipe in CI. We
> >> should probably enable kas/opt/test.yml for some representative
> >> target(s) to close this gap.
> >>
> >
> > Err, no, we are building that ("extension: test", see e.g.
> > https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/255447396
> > 4). Now I'm confused, specifically as I've seen build issues locally as well.
> >
> 
> buster vs. bullseye: the former worked (as tested in CI), the latter was
> broken.
> 
> As suspected, patch 3 needed to go before patch 1 - or folded into it. I did the
> latter while merging.

Thanks Jan.

Best,
Vijai Kumar K

> 
> Thanks,
> Jan
> 
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
diff mbox series

Patch

diff --git a/recipes-core/ltp/files/debian/rules b/recipes-core/ltp/files/debian/rules
index a485615..06b9070 100755
--- a/recipes-core/ltp/files/debian/rules
+++ b/recipes-core/ltp/files/debian/rules
@@ -8,3 +8,5 @@  LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
 
 override_dh_auto_configure:
 	dh_auto_configure -- $(LTP_CONFIGURE_FLAGS)
+
+override_dh_auto_test: