diff mbox series

[isar-cip-core] bbb_defconfig: Add missing SDHCI Drivers

Message ID 20220804125437.715852-1-Quirin.Gylstorff@siemens.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [isar-cip-core] bbb_defconfig: Add missing SDHCI Drivers | expand

Commit Message

Gylstorff Quirin Aug. 4, 2022, 12:54 p.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

To boot from SD/MMC wit kernel 5.10. new config option need to
be enabled.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 recipes-kernel/linux/files/bbb_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Jan Kiszka Aug. 4, 2022, 1:29 p.m. UTC | #1
On 04.08.22 14:54, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> To boot from SD/MMC wit kernel 5.10. new config option need to
> be enabled.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  recipes-kernel/linux/files/bbb_defconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/recipes-kernel/linux/files/bbb_defconfig b/recipes-kernel/linux/files/bbb_defconfig
> index 31e15e6..8f8f1aa 100644
> --- a/recipes-kernel/linux/files/bbb_defconfig
> +++ b/recipes-kernel/linux/files/bbb_defconfig
> @@ -374,6 +374,9 @@ CONFIG_USB_CONFIGFS_F_HID=y
>  CONFIG_USB_ZERO=m
>  CONFIG_USB_G_NOKIA=m
>  CONFIG_MMC=y
> +CONFIG_PWRSEQ_EMMC=y
> +CONFIG_MMC_BLOCK=y
> +CONFIG_MMC_BLOCK_MINORS=256
>  CONFIG_SDIO_UART=y
>  CONFIG_MMC_OMAP=y
>  CONFIG_MMC_OMAP_HS=y
> @@ -453,3 +456,8 @@ CONFIG_LIBCRC32C=y
>  CONFIG_FONTS=y
>  CONFIG_FONT_8x8=y
>  CONFIG_FONT_8x16=y
> +CONFIG_MMC_SDHCI=m
> +CONFIG_MMC_SDHCI_IO_ACCESSORS=y
> +CONFIG_MMC_SDHCI_PCI=m
> +CONFIG_MMC_SDHCI_OMAP=m
> +CONFIG_MMC_SDHCI_PLTFM=m

Thanks for tracking this down. But why still massaging this config? We
rather want to switch to cip-kernel-config and fix any remaining issues
there.

Jan
Gylstorff Quirin Aug. 4, 2022, 1:58 p.m. UTC | #2
On 8/4/22 15:29, Jan Kiszka wrote:
> On 04.08.22 14:54, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> To boot from SD/MMC wit kernel 5.10. new config option need to
>> be enabled.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   recipes-kernel/linux/files/bbb_defconfig | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/recipes-kernel/linux/files/bbb_defconfig b/recipes-kernel/linux/files/bbb_defconfig
>> index 31e15e6..8f8f1aa 100644
>> --- a/recipes-kernel/linux/files/bbb_defconfig
>> +++ b/recipes-kernel/linux/files/bbb_defconfig
>> @@ -374,6 +374,9 @@ CONFIG_USB_CONFIGFS_F_HID=y
>>   CONFIG_USB_ZERO=m
>>   CONFIG_USB_G_NOKIA=m
>>   CONFIG_MMC=y
>> +CONFIG_PWRSEQ_EMMC=y
>> +CONFIG_MMC_BLOCK=y
>> +CONFIG_MMC_BLOCK_MINORS=256
>>   CONFIG_SDIO_UART=y
>>   CONFIG_MMC_OMAP=y
>>   CONFIG_MMC_OMAP_HS=y
>> @@ -453,3 +456,8 @@ CONFIG_LIBCRC32C=y
>>   CONFIG_FONTS=y
>>   CONFIG_FONT_8x8=y
>>   CONFIG_FONT_8x16=y
>> +CONFIG_MMC_SDHCI=m
>> +CONFIG_MMC_SDHCI_IO_ACCESSORS=y
>> +CONFIG_MMC_SDHCI_PCI=m
>> +CONFIG_MMC_SDHCI_OMAP=m
>> +CONFIG_MMC_SDHCI_PLTFM=m
> 
> Thanks for tracking this down. But why still massaging this config? We
> rather want to switch to cip-kernel-config and fix any remaining issues
> there.

I am on it, until I find a fix for cip-kernel-config this can stay.


> 
> Jan
>
Quirin
Jan Kiszka Aug. 8, 2022, 12:47 p.m. UTC | #3
On 04.08.22 14:54, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> To boot from SD/MMC wit kernel 5.10. new config option need to
> be enabled.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  recipes-kernel/linux/files/bbb_defconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/recipes-kernel/linux/files/bbb_defconfig b/recipes-kernel/linux/files/bbb_defconfig
> index 31e15e6..8f8f1aa 100644
> --- a/recipes-kernel/linux/files/bbb_defconfig
> +++ b/recipes-kernel/linux/files/bbb_defconfig
> @@ -374,6 +374,9 @@ CONFIG_USB_CONFIGFS_F_HID=y
>  CONFIG_USB_ZERO=m
>  CONFIG_USB_G_NOKIA=m
>  CONFIG_MMC=y
> +CONFIG_PWRSEQ_EMMC=y

Not needed.

> +CONFIG_MMC_BLOCK=y

This can become m.

> +CONFIG_MMC_BLOCK_MINORS=256

Not needed for our setups.

>  CONFIG_SDIO_UART=y
>  CONFIG_MMC_OMAP=y
>  CONFIG_MMC_OMAP_HS=y
> @@ -453,3 +456,8 @@ CONFIG_LIBCRC32C=y
>  CONFIG_FONTS=y
>  CONFIG_FONT_8x8=y
>  CONFIG_FONT_8x16=y
> +CONFIG_MMC_SDHCI=m
> +CONFIG_MMC_SDHCI_IO_ACCESSORS=y
> +CONFIG_MMC_SDHCI_PCI=m

Those two are not needed.

> +CONFIG_MMC_SDHCI_OMAP=m
> +CONFIG_MMC_SDHCI_PLTFM=m

I'll submit the required changes to cip-kernel-config for 5.10.

Thanks,
Jan
diff mbox series

Patch

diff --git a/recipes-kernel/linux/files/bbb_defconfig b/recipes-kernel/linux/files/bbb_defconfig
index 31e15e6..8f8f1aa 100644
--- a/recipes-kernel/linux/files/bbb_defconfig
+++ b/recipes-kernel/linux/files/bbb_defconfig
@@ -374,6 +374,9 @@  CONFIG_USB_CONFIGFS_F_HID=y
 CONFIG_USB_ZERO=m
 CONFIG_USB_G_NOKIA=m
 CONFIG_MMC=y
+CONFIG_PWRSEQ_EMMC=y
+CONFIG_MMC_BLOCK=y
+CONFIG_MMC_BLOCK_MINORS=256
 CONFIG_SDIO_UART=y
 CONFIG_MMC_OMAP=y
 CONFIG_MMC_OMAP_HS=y
@@ -453,3 +456,8 @@  CONFIG_LIBCRC32C=y
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
+CONFIG_MMC_SDHCI=m
+CONFIG_MMC_SDHCI_IO_ACCESSORS=y
+CONFIG_MMC_SDHCI_PCI=m
+CONFIG_MMC_SDHCI_OMAP=m
+CONFIG_MMC_SDHCI_PLTFM=m