| Message ID | 20221012111919.8911-1-ubely@ilbers.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [isar-cip-core] Fix mount options passed to systemd unit | expand |
On 12.10.22 13:19, Uladzimir Bely wrote: > Mount unit template used wrong variable name for mount options. > This resulted in empty `Options` value used for /tmp mounting. > > Signed-off-by: Uladzimir Bely <ubely@ilbers.de> > --- > recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl > index fcb2f3e..be5e663 100644 > --- a/recipes-core/tmp-fs/files/tmp.mount.tmpl > +++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl > @@ -5,7 +5,7 @@ Description=Create /tmp > What=tmpfs > Where=/tmp > Type=tmpfs > -Options=${TMP_OPTIONS} > +Options=${TMP_FS_OPTIONS} > > [Install] > WantedBy=local-fs.target Thanks, applied. Jan
On 12.10.22 13:34, Jan Kiszka wrote: > On 12.10.22 13:19, Uladzimir Bely wrote: >> Mount unit template used wrong variable name for mount options. >> This resulted in empty `Options` value used for /tmp mounting. >> >> Signed-off-by: Uladzimir Bely <ubely@ilbers.de> >> --- >> recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl >> index fcb2f3e..be5e663 100644 >> --- a/recipes-core/tmp-fs/files/tmp.mount.tmpl >> +++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl >> @@ -5,7 +5,7 @@ Description=Create /tmp >> What=tmpfs >> Where=/tmp >> Type=tmpfs >> -Options=${TMP_OPTIONS} >> +Options=${TMP_FS_OPTIONS} >> >> [Install] >> WantedBy=local-fs.target > > Thanks, applied. > > Jan > Need to drop it again for now as the current value of TMP_FS_OPTIONS in the recipe is not ready for use. See also https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/44. We need a working default. And likely also a weak assigning of that. Jan
diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl index fcb2f3e..be5e663 100644 --- a/recipes-core/tmp-fs/files/tmp.mount.tmpl +++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl @@ -5,7 +5,7 @@ Description=Create /tmp What=tmpfs Where=/tmp Type=tmpfs -Options=${TMP_OPTIONS} +Options=${TMP_FS_OPTIONS} [Install] WantedBy=local-fs.target
Mount unit template used wrong variable name for mount options. This resulted in empty `Options` value used for /tmp mounting. Signed-off-by: Uladzimir Bely <ubely@ilbers.de> --- recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)