diff mbox series

[isar-cip-core] classes/swupdate: remove image_do_mounts

Message ID 20230522101734.1700221-1-srinuvasan_a@mentor.com (mailing list archive)
State Accepted
Headers show
Series [isar-cip-core] classes/swupdate: remove image_do_mounts | expand

Commit Message

Srinuvasan Arjunan May 22, 2023, 10:17 a.m. UTC 
From: Srinuvasan A <srinuvasan.a@siemens.com>

When we hookup the IMAGE_CMD:* for image generation,
image_do_mounts is inserted automatically, hence remove the duplication
here.

Ref: https://github.com/ilbers/isar/commit/f792fd0deed1ae1d9deb3ee28b1a1add96ecdf14

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 classes/swupdate.bbclass | 2 --
 1 file changed, 2 deletions(-)

Comments

Jan Kiszka May 27, 2023, 10:15 a.m. UTC | #1 
On 22.05.23 12:17, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> When we hookup the IMAGE_CMD:* for image generation,
> image_do_mounts is inserted automatically, hence remove the duplication
> here.
> 
> Ref: https://github.com/ilbers/isar/commit/f792fd0deed1ae1d9deb3ee28b1a1add96ecdf14
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  classes/swupdate.bbclass | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/classes/swupdate.bbclass b/classes/swupdate.bbclass
> index 9a4d509..9f34760 100644
> --- a/classes/swupdate.bbclass
> +++ b/classes/swupdate.bbclass
> @@ -97,8 +97,6 @@ IMAGE_CMD:swu() {
>          fi
>      done
>  
> -    image_do_mounts
> -
>      # Prepare for signing
>      export sign='${@'x' if bb.utils.to_boolean(d.getVar('SWU_SIGNED')) else ''}'
>      if [ -n "$sign" ]; then

Good catch.

Thanks, applied.

Jan
diff mbox series

Patch

diff --git a/classes/swupdate.bbclass b/classes/swupdate.bbclass
index 9a4d509..9f34760 100644
--- a/classes/swupdate.bbclass
+++ b/classes/swupdate.bbclass
@@ -97,8 +97,6 @@  IMAGE_CMD:swu() {
         fi
     done
 
-    image_do_mounts
-
     # Prepare for signing
     export sign='${@'x' if bb.utils.to_boolean(d.getVar('SWU_SIGNED')) else ''}'
     if [ -n "$sign" ]; then