| Message ID | 20230926164021.30185-3-venkata.pyla@toshiba-tsip.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add dosfstools recipe | expand |
On 26.09.23 18:40, venkata.pyla@toshiba-tsip.com wrote: > From: venkata pyla <venkata.pyla@toshiba-tsip.com> > > custom dosfstools is included with fix that will help create DOS images > reproducibly. > > Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com> > --- > conf/distro/cip-core-common.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/conf/distro/cip-core-common.inc b/conf/distro/cip-core-common.inc > index 5d3ce10..5a158f2 100644 > --- a/conf/distro/cip-core-common.inc > +++ b/conf/distro/cip-core-common.inc > @@ -14,3 +14,4 @@ KERNEL_NAME ?= "cip" > WKS_FILE ?= "${MACHINE}.wks" > > CIP_IMAGE_OPTIONS ?= "" > +IMAGER_BUILD_DEPS ?= "dosfstools" Unfortunately, the patch does not apply to the buster version of dosfstools, see e.g. https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/5172706817. We either need an adjusted patch for that release or need to skip buster. Jan
> -----Original Message----- > From: Jan Kiszka <jan.kiszka@siemens.com> > Sent: Wednesday, September 27, 2023 12:34 PM > To: pyla venkata(ＴＳＩＰ TMIEC ODG Porting) <Venkata.Pyla@toshiba- > tsip.com>; cip-dev@lists.cip-project.org > Cc: dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba- > tsip.com>; hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) > <kazuhiro3.hayashi@toshiba.co.jp> > Subject: Re: [isar-cip-core v3 2/2] conf/distro/cip-core-common.inc: Set > dosfstools as build dependency > > On 26.09.23 18:40, venkata.pyla@toshiba-tsip.com wrote: > > From: venkata pyla <venkata.pyla@toshiba-tsip.com> > > > > custom dosfstools is included with fix that will help create DOS > > images reproducibly. > > > > Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com> > > --- > > conf/distro/cip-core-common.inc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/conf/distro/cip-core-common.inc > > b/conf/distro/cip-core-common.inc index 5d3ce10..5a158f2 100644 > > --- a/conf/distro/cip-core-common.inc > > +++ b/conf/distro/cip-core-common.inc > > @@ -14,3 +14,4 @@ KERNEL_NAME ?= "cip" > > WKS_FILE ?= "${MACHINE}.wks" > > > > CIP_IMAGE_OPTIONS ?= "" > > +IMAGER_BUILD_DEPS ?= "dosfstools" > > Unfortunately, the patch does not apply to the buster version of dosfstools, > see e.g. > https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/5172706817. > We either need an adjusted patch for that release or need to skip buster. sorry I didn't check this in buster before sending this patch, I think it is better to skip for buster, as reproducible builds are not achievable in buster and so it is not important. Let me skip this in v4. > > Jan > > -- > Siemens AG, Technology > Linux Expert Center
diff --git a/conf/distro/cip-core-common.inc b/conf/distro/cip-core-common.inc index 5d3ce10..5a158f2 100644 --- a/conf/distro/cip-core-common.inc +++ b/conf/distro/cip-core-common.inc @@ -14,3 +14,4 @@ KERNEL_NAME ?= "cip" WKS_FILE ?= "${MACHINE}.wks" CIP_IMAGE_OPTIONS ?= "" +IMAGER_BUILD_DEPS ?= "dosfstools"