[1/1] clk: Fix best_parent_rate after moving code into a separate function

Commit Message

Kazuhiro Hayashi Jan. 31, 2024, 1:56 p.m. UTC

From: Marek Szyprowski <[e-mail]>

commit be8fa5fd0a48fd2decc4de81ffe72bb3ceacecd9 upstream.

best_parent_rate entry is still being used in the code and needs to be
always updated regardless of the CLK_SET_RATE_NO_REPARENT flag.

Fixes: 1b4e99fda73f ("clk: Move no reparent case into a separate function")
Signed-off-by: Marek Szyprowski <[e-mail]>
Link: https://lore.kernel.org/r/[e-mail]
Acked-by: Maxime Ripard <[e-mail]>
Signed-off-by: Stephen Boyd <[e-mail]>
Reported-by: Yuki Saito <[e-mail]>
Reviewed-by: Kazuhiro Hayashi <[e-mail]>
---
 drivers/clk/clk.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pavel Machek Jan. 31, 2024, 11:17 a.m. UTC | #1

Hi!

Is there something wrong with the time here?

Date: Wed, 31 Jan 2024 22:56:04 +0900
From: Kazuhiro Hayashi <[e-mail]>
On Wed 2024-01-31 22:56:04, Kazuhiro Hayashi wrote:

pavel@duo:~$ date
Wed 31 Jan 2024 12:15:57 PM CET

This will "fix" itself in two hours, but I wonder what went wrong
there.

Best regards,
								Pavel

Kazuhiro Hayashi Feb. 1, 2024, 4:51 a.m. UTC | #2

Hello Pavel,

> Is there something wrong with the time here?

Thanks for pointing this out.
Yes, the time in my environment was wrong due to recent setting changes...
Let me resend the patch just in case.

Best regards,
Kazu

> -----Original Message-----
> From: [e-mail] <[e-mail]> On Behalf Of Pavel Machek
> Sent: Wednesday, January 31, 2024 8:17 PM
> To: hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) <[e-mail]>
> Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <[e-mail]>; [e-mail]; [e-mail]; saito yuki(齊藤 優貴 ＤＭＥ ○Ｄ
> ＩＧ□ＥＡＳ○ＥＡ３) <[e-mail]>
> Subject: Re: [cip-dev] [PATCH 1/1] clk: Fix best_parent_rate after moving code into a separate function
> 
> Hi!
> 
> Is there something wrong with the time here?
> 
> Date: Wed, 31 Jan 2024 22:56:04 +0900
> From: Kazuhiro Hayashi <[e-mail]>
> On Wed 2024-01-31 22:56:04, Kazuhiro Hayashi wrote:
> 
> pavel@duo:~$ date
> Wed 31 Jan 2024 12:15:57 PM CET
> 
> This will "fix" itself in two hours, but I wonder what went wrong
> there.
> 
> Best regards,
> 								Pavel
> --
> DENX Software Engineering GmbH,        Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index fe61fdc7c025..c048c6b1b8c3 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -614,6 +614,7 @@  clk_core_determine_rate_no_reparent(struct clk_hw *hw,
 		best = clk_core_get_rate_nolock(core);
 	}
 
+	req->best_parent_rate = best;
 	req->rate = best;
 
 	return 0;