diff mbox series

[isar-cip-core,RFC,v1,3/6] swupdate: Enable Delta handler in swupdate

Message ID 20240307074612.1996609-4-Adithya.Balakumar@toshiba-tsip.com (mailing list archive)
State Changes Requested
Headers show
Series Integrate Delta Update with rdiff_image and delta handler | expand

Commit Message

Adithya Balakumar March 7, 2024, 7:46 a.m. UTC
Enable delta handler in swupdate for bookworm and disable cross compile
for arm and arm64 on bookworm to avoid build issues

Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
---
 recipes-core/swupdate/swupdate_2023.05.bb | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jan Kiszka March 8, 2024, 11:35 a.m. UTC | #1
On 07.03.24 08:46, Adithya Balakumar wrote:
> Enable delta handler in swupdate for bookworm and disable cross compile
> for arm and arm64 on bookworm to avoid build issues
> 
> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
> ---
>  recipes-core/swupdate/swupdate_2023.05.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-core/swupdate/swupdate_2023.05.bb b/recipes-core/swupdate/swupdate_2023.05.bb
> index d1fe1fa..7a22947 100644
> --- a/recipes-core/swupdate/swupdate_2023.05.bb
> +++ b/recipes-core/swupdate/swupdate_2023.05.bb
> @@ -36,10 +36,13 @@ SRC_URI:append:bullseye = " file://0004-d-swupdate-www.install-Fix-path-for-debi
>  DEB_BUILD_PROFILES += "pkg.swupdate.suricattalua"
>  # add suricatta wfx
>  DEB_BUILD_PROFILES += "pkg.swupdate.suricattawfx"
> +# add delta update build profile for bookworm
> +DEB_BUILD_PROFILES:append:bookworm = " pkg.swupdate.delta"
>  

What about sid?

>  # Disable cross for arm and arm64 on bullseye
>  # with cross compile we have a unsat-dependency to dh-nodejs on arm/arm64
>  ISAR_CROSS_COMPILE:bullseye = "0"
> +ISAR_CROSS_COMPILE:bookworm = "0"

This is unfortunate. Why that?

>  
>  # use backport build profile for bullseye
>  DEB_BUILD_PROFILES:append:bullseye = " pkg.swupdate.bpo"

Jan
Adithya Balakumar March 13, 2024, 9:32 a.m. UTC | #2
-----Original Message-----
From: Jan Kiszka <jan.kiszka@siemens.com> 
Sent: Friday, March 8, 2024 5:06 PM
To: balakumar adithya(TSIP TEUR) <Adithya.Balakumar@toshiba-tsip.com>; cip-dev@lists.cip-project.org
Cc: kunijadar shivanand(TSIP TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(TSIP) <Sai.Sathujoda@toshiba-tsip.com>; dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4) <kazuhiro3.hayashi@toshiba.co.jp>
Subject: Re: [isar-cip-core][RFC v1 3/6] swupdate: Enable Delta handler in swupdate

On 07.03.24 08:46, Adithya Balakumar wrote:
> Enable delta handler in swupdate for bookworm and disable cross 
> compile for arm and arm64 on bookworm to avoid build issues
> 
> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
> ---
>  recipes-core/swupdate/swupdate_2023.05.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-core/swupdate/swupdate_2023.05.bb 
> b/recipes-core/swupdate/swupdate_2023.05.bb
> index d1fe1fa..7a22947 100644
> --- a/recipes-core/swupdate/swupdate_2023.05.bb
> +++ b/recipes-core/swupdate/swupdate_2023.05.bb
> @@ -36,10 +36,13 @@ SRC_URI:append:bullseye = " 
> file://0004-d-swupdate-www.install-Fix-path-for-debi
>  DEB_BUILD_PROFILES += "pkg.swupdate.suricattalua"
>  # add suricatta wfx
>  DEB_BUILD_PROFILES += "pkg.swupdate.suricattawfx"
> +# add delta update build profile for bookworm 
> +DEB_BUILD_PROFILES:append:bookworm = " pkg.swupdate.delta"
>  

What about sid?

[Adithya Balakumar]
Hi Jan,
Apologies, Will handle this in v2. 

>  # Disable cross for arm and arm64 on bullseye  # with cross compile 
> we have a unsat-dependency to dh-nodejs on arm/arm64  
> ISAR_CROSS_COMPILE:bullseye = "0"
> +ISAR_CROSS_COMPILE:bookworm = "0"

This is unfortunate. Why that?

[Adithya Balakumar]
This is because of build failures of swupdate with delta handler enabled in arm64/arm architectures due to dependency on libzck-dev package.
Have also raised this as an issue in isar-cip-core: https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/93

Thanks and Regards,
Adithya

>  
>  # use backport build profile for bullseye  
> DEB_BUILD_PROFILES:append:bullseye = " pkg.swupdate.bpo"

>Jan

--
>Siemens AG, Technology
>Linux Expert Center
Gylstorff Quirin March 14, 2024, 6:56 a.m. UTC | #3
On 3/8/24 12:36 PM, Jan Kiszka via lists.cip-project.org wrote:
> On 07.03.24 08:46, Adithya Balakumar wrote:
>> Enable delta handler in swupdate for bookworm and disable cross compile
>> for arm and arm64 on bookworm to avoid build issues
>>
>> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
>> ---
>>   recipes-core/swupdate/swupdate_2023.05.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/recipes-core/swupdate/swupdate_2023.05.bb b/recipes-core/swupdate/swupdate_2023.05.bb
>> index d1fe1fa..7a22947 100644
>> --- a/recipes-core/swupdate/swupdate_2023.05.bb
>> +++ b/recipes-core/swupdate/swupdate_2023.05.bb
>> @@ -36,10 +36,13 @@ SRC_URI:append:bullseye = " file://0004-d-swupdate-www.install-Fix-path-for-debi
>>   DEB_BUILD_PROFILES += "pkg.swupdate.suricattalua"
>>   # add suricatta wfx
>>   DEB_BUILD_PROFILES += "pkg.swupdate.suricattawfx"
>> +# add delta update build profile for bookworm
>> +DEB_BUILD_PROFILES:append:bookworm = " pkg.swupdate.delta"
>>   
> 
> What about sid?
> 
>>   # Disable cross for arm and arm64 on bullseye
>>   # with cross compile we have a unsat-dependency to dh-nodejs on arm/arm64
>>   ISAR_CROSS_COMPILE:bullseye = "0"
>> +ISAR_CROSS_COMPILE:bookworm = "0"
> 
> This is unfortunate. Why that?
> 

I tested swupdate 2023.05 on bookworm with armhf and arm64 it currently 
needs no backports.

My two cents are this is an issue with backports.

Quirin

>>   
>>   # use backport build profile for bullseye
>>   DEB_BUILD_PROFILES:append:bullseye = " pkg.swupdate.bpo"
> 
> Jan
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15265): https://lists.cip-project.org/g/cip-dev/message/15265
> Mute This Topic: https://lists.cip-project.org/mt/104783337/1753640
> Group Owner: cip-dev+owner@lists.cip-project.org
> Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129121/1753640/1405269326/xyzzy [quirin.gylstorff@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Adithya Balakumar March 14, 2024, 7:51 a.m. UTC | #4
-----Original Message-----
From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Quirin Gylstorff via lists.cip-project.org
Sent: Thursday, March 14, 2024 12:27 PM
To: cip-dev@lists.cip-project.org; balakumar adithya(TSIP TEUR) <Adithya.Balakumar@toshiba-tsip.com>
Cc: kunijadar shivanand(TSIP TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(TSIP) <Sai.Sathujoda@toshiba-tsip.com>; dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4) <kazuhiro3.hayashi@toshiba.co.jp>
Subject: Re: [cip-dev] [isar-cip-core][RFC v1 3/6] swupdate: Enable Delta handler in swupdate



On 3/8/24 12:36 PM, Jan Kiszka via lists.cip-project.org wrote:
> On 07.03.24 08:46, Adithya Balakumar wrote:
>> Enable delta handler in swupdate for bookworm and disable cross 
>> compile for arm and arm64 on bookworm to avoid build issues
>>
>> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
>> ---
>>   recipes-core/swupdate/swupdate_2023.05.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/recipes-core/swupdate/swupdate_2023.05.bb 
>> b/recipes-core/swupdate/swupdate_2023.05.bb
>> index d1fe1fa..7a22947 100644
>> --- a/recipes-core/swupdate/swupdate_2023.05.bb
>> +++ b/recipes-core/swupdate/swupdate_2023.05.bb
>> @@ -36,10 +36,13 @@ SRC_URI:append:bullseye = " file://0004-d-swupdate-www.install-Fix-path-for-debi
>>   DEB_BUILD_PROFILES += "pkg.swupdate.suricattalua"
>>   # add suricatta wfx
>>   DEB_BUILD_PROFILES += "pkg.swupdate.suricattawfx"
>> +# add delta update build profile for bookworm 
>> +DEB_BUILD_PROFILES:append:bookworm = " pkg.swupdate.delta"
>>   
> 
> What about sid?
> 
>>   # Disable cross for arm and arm64 on bullseye
>>   # with cross compile we have a unsat-dependency to dh-nodejs on arm/arm64
>>   ISAR_CROSS_COMPILE:bullseye = "0"
>> +ISAR_CROSS_COMPILE:bookworm = "0"
> 
> This is unfortunate. Why that?
> 

I tested swupdate 2023.05 on bookworm with armhf and arm64 it currently needs no backports.

My two cents are this is an issue with backports.

Quirin

[Adithya Balakumar] 
Hi Quirin,

This was because of build failures of swupdate with delta handler enabled in arm64/arm architectures due to dependency on libzck-dev package (a backported package).
Have also raised this as an issue in isar-cip-core: https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/93

Regards,
Adithya

>>   
>>   # use backport build profile for bullseye
>>   DEB_BUILD_PROFILES:append:bullseye = " pkg.swupdate.bpo"
> 
> Jan
> 
> 
> 
> 
>
diff mbox series

Patch

diff --git a/recipes-core/swupdate/swupdate_2023.05.bb b/recipes-core/swupdate/swupdate_2023.05.bb
index d1fe1fa..7a22947 100644
--- a/recipes-core/swupdate/swupdate_2023.05.bb
+++ b/recipes-core/swupdate/swupdate_2023.05.bb
@@ -36,10 +36,13 @@  SRC_URI:append:bullseye = " file://0004-d-swupdate-www.install-Fix-path-for-debi
 DEB_BUILD_PROFILES += "pkg.swupdate.suricattalua"
 # add suricatta wfx
 DEB_BUILD_PROFILES += "pkg.swupdate.suricattawfx"
+# add delta update build profile for bookworm
+DEB_BUILD_PROFILES:append:bookworm = " pkg.swupdate.delta"
 
 # Disable cross for arm and arm64 on bullseye
 # with cross compile we have a unsat-dependency to dh-nodejs on arm/arm64
 ISAR_CROSS_COMPILE:bullseye = "0"
+ISAR_CROSS_COMPILE:bookworm = "0"
 
 # use backport build profile for bullseye
 DEB_BUILD_PROFILES:append:bullseye = " pkg.swupdate.bpo"