diff mbox series

[5.10.y-cip,10/31] rtc: da9063: Simplify bool comparison

Message ID	20240716082255.56551-11-biju.das.jz@bp.renesas.com (mailing list archive)
State	New
Headers	show Return-Path: <biju.das.jz@bp.renesas.com> ip: 210.160.252.172, mailfrom: biju.das.jz@bp.renesas.com) From: Biju Das <biju.das.jz@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [PATCH 5.10.y-cip 10/31] rtc: da9063: Simplify bool comparison Date: Tue, 16 Jul 2024 09:22:21 +0100 Message-ID: <20240716082255.56551-11-biju.das.jz@bp.renesas.com> In-Reply-To: <20240716082255.56551-1-biju.das.jz@bp.renesas.com> References: <20240716082255.56551-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Add PMIC DA9062 support \| expand [5.10.y-cip,00/31] Add PMIC DA9062 support [5.10.y-cip,01/31] mfd: core: Delete corresponding OF node entries from list on MFD removal [5.10.y-cip,02/31] mfd: da9xxx-core: Constify static struct resource [5.10.y-cip,03/31] mfd: da9062: Drop of_match_ptr from of_device_id table [5.10.y-cip,04/31] mfd: da9062: Simplify getting of_device_id match data [5.10.y-cip,05/31] mfd: da9062: Support SMBus and I2C mode [5.10.y-cip,06/31] mfd: da9061: Fix Failed to set Two-Wire Bus Mode. [5.10.y-cip,07/31] mfd: da9062: Use MFD_CELL_OF macro [5.10.y-cip,08/31] mfd: da9062: Remove IRQ requirement [5.10.y-cip,09/31] mfd: da9062: Simplify obtaining I2C match data [5.10.y-cip,10/31] rtc: da9063: Simplify bool comparison [5.10.y-cip,11/31] rtc: da9063: add as wakeup source [5.10.y-cip,12/31] rtc: da9063: Mark the alarm IRQ as a wake IRQ [5.10.y-cip,13/31] rtc: da9063: Make IRQ as optional [5.10.y-cip,14/31] rtc: da9063: Use device_get_match_data() [5.10.y-cip,15/31] rtc: da9063: Use dev_err_probe() [5.10.y-cip,16/31] pinctrl: Propagate firmware node from a parent device [5.10.y-cip,17/31] pinctrl: da9062: Add OF table [5.10.y-cip,18/31] Input: da9063 - add wakeup support [5.10.y-cip,19/31] Input: da9063 - simplify obtaining OF match data [5.10.y-cip,20/31] Input: da9063 - drop redundant prints in probe() [5.10.y-cip,21/31] Input: da9063 - use dev_err_probe() [5.10.y-cip,22/31] dt-bindings: mfd: Convert da9063 to yaml [5.10.y-cip,23/31] dt-bindings: watchdog: da9062-wdt: convert txt to yaml [5.10.y-cip,24/31] dt-bindings: mfd: da9062: Update watchdog description [5.10.y-cip,25/31] dt-bindings: mfd: dlg,da9063: Update watchdog child node [5.10.y-cip,26/31] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema [5.10.y-cip,27/31] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema [5.10.y-cip,28/31] dt-bindings: mfd: dlg,da9063: Sort child devices [5.10.y-cip,29/31] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema [5.10.y-cip,30/31] arm64: dts: renesas: rzg2ul-smarc: Enable PMIC and built-in RTC, GPIO and ONKEY [5.10.y-cip,31/31] arm64: defconfig: Enable Renesas DA9062 PMIC

Commit Message

Biju Das July 16, 2024, 8:22 a.m. UTC

From: Kaixu Xia <kaixuxia@tencent.com>

commit a48c6224ae07bed02893c58073ca2942acb5c3d5 upstream.

Fix the following coccicheck warning:

./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1604649637-1014-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/rtc/rtc-da9063.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index 046b1d4c3dae..6f0a3a711135 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -243,7 +243,7 @@  static int da9063_rtc_read_time(struct device *dev, struct rtc_time *tm)
 	al_secs = rtc_tm_to_time64(&rtc->alarm_time);
 
 	/* handle the rtc synchronisation delay */
-	if (rtc->rtc_sync == true && al_secs - tm_secs == 1)
+	if (rtc->rtc_sync && al_secs - tm_secs == 1)
 		memcpy(tm, &rtc->alarm_time, sizeof(struct rtc_time));
 	else
 		rtc->rtc_sync = false;