mbox series

[0/3] service: Minor address_updated Changes

Message ID 20231116030912.636756-1-gerickson@nuovations.com (mailing list archive)
Headers show
Series service: Minor address_updated Changes | expand

Message

Grant Erickson Nov. 16, 2023, 3:09 a.m. UTC 
This makes some minor changes to 'address_updated':

    1. Leverage 'connman_service_is_default'.
    2. Add 'DBG' statement.
    3. Add documentation.

Grant Erickson (3):
  service: Leverage 'connman_service_is_default'.
  service: Add DBG statement to 'address_updated'.
  service: Add documentation to 'address_updated'.

 src/service.c | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

Comments

Marcel Holtmann Nov. 23, 2023, 11:22 a.m. UTC | #1 
Hi Grant,

> This makes some minor changes to 'address_updated':
> 
>    1. Leverage 'connman_service_is_default'.
>    2. Add 'DBG' statement.
>    3. Add documentation.
> 
> Grant Erickson (3):
>  service: Leverage 'connman_service_is_default'.
>  service: Add DBG statement to 'address_updated'.
>  service: Add documentation to 'address_updated'.
> 
> src/service.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)

sadly this doesnt apply cleanly anymore.

Regards

Marcel
Grant Erickson Nov. 24, 2023, 5:57 p.m. UTC | #2 
On Nov 23, 2023, at 3:22 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
>> This makes some minor changes to 'address_updated':
>> 
>>   1. Leverage 'connman_service_is_default'.
>>   2. Add 'DBG' statement.
>>   3. Add documentation.
>> 
>> Grant Erickson (3):
>> service: Leverage 'connman_service_is_default'.
>> service: Add DBG statement to 'address_updated'.
>> service: Add documentation to 'address_updated'.
>> 
>> src/service.c | 35 ++++++++++++++++++++++++++++++++++-
>> 1 file changed, 34 insertions(+), 1 deletion(-)
> 
> sadly this doesnt apply cleanly anymore.

Thanks; resubmitted as v2.

Best,

Grant