diff mbox series

[30/90] connection: Change return type of 'set_default_gateway'.

Message ID 20231206235056.322578-31-gerickson@nuovations.com (mailing list archive)
State Not Applicable, archived
Headers show
Series Add Gateway Low-priority Default Routes for Non-default Services | expand

Commit Message

Grant Erickson Dec. 6, 2023, 11:49 p.m. UTC 
From: Grant Erickson <erick205@umn.edu>

This changes the return signature of 'set_default_gateway' from
'void' to 'int' such that its status can be leveraged for conditional
execution where it is called.
---
 src/connection.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/src/connection.c b/src/connection.c
index 702e08dbe37c..2a21e476bc53 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -1371,12 +1371,15 @@  done:
  *                            which the call to this function should
  *                            be attributed.
  *
+ * @returns
+ *   0 if successful; otherwise, < 0 on error.
+ *
  *  @sa mutate_default_gateway
  *  @sa set_ipv4_high_priority_default_gateway
  *  @sa set_ipv6_high_priority_default_gateway
  *
  */
-static void set_default_gateway(struct gateway_data *data,
+static int set_default_gateway(struct gateway_data *data,
 				enum connman_ipconfig_type type,
 				const char *function)
 {
@@ -1390,9 +1393,12 @@  static void set_default_gateway(struct gateway_data *data,
 
 	status = mutate_default_gateway(data, type, &ops, __func__);
 	if (status < 0)
-		return;
+		goto done;
 
 	__connman_service_indicate_default(data->service);
+
+done:
+	return status;
 }
 
 static int unset_ipv4_high_priority_default_gateway(