diff mbox series

ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG.

Message ID 20231221070849.2354559-1-gerickson@nuovations.com (mailing list archive)
State Not Applicable, archived
Headers show
Series ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG. | expand

Commit Message

Grant Erickson Dec. 21, 2023, 7:08 a.m. UTC 
With the "continuous" online check mode, logs can become dominated by
Linux Routing Netlink (rtnl) 'RTM_{ADD,DEL}ROUTE' entries every time
WISPr adds/deletes a host route for the online check.

This demotes those log invocations from 'connman_info' to 'DBG'.
---
 src/ipconfig.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marcel Holtmann Dec. 23, 2023, 12:21 p.m. UTC | #1 
Hi Grant,

> With the "continuous" online check mode, logs can become dominated by
> Linux Routing Netlink (rtnl) 'RTM_{ADD,DEL}ROUTE' entries every time
> WISPr adds/deletes a host route for the online check.
> 
> This demotes those log invocations from 'connman_info' to 'DBG'.
> ---
> src/ipconfig.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied.

Regards

Marcel
diff mbox series

Patch

diff --git a/src/ipconfig.c b/src/ipconfig.c
index 5ec619fa7e6b..c2d7d2bc02b8 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1102,7 +1102,7 @@  void __connman_ipconfig_newroute(int index, int family, unsigned char scope,
 		}
 	}
 
-	connman_info("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
+	DBG("%s {add} route %s/%u gw %s scope %u <%s> table %u <%s> "
 		"metric %u",
 		ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
 		table_id, __connman_inet_table2string(table_id), metric);
@@ -1174,7 +1174,7 @@  void __connman_ipconfig_delroute(int index, int family, unsigned char scope,
 		}
 	}
 
-	connman_info("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
+	DBG("%s {del} route %s/%u gw %s scope %u <%s> table %u <%s> "
 		"metric %u",
 		ifname, dst, dst_prefixlen, gateway, scope, scope2str(scope),
 		table_id, __connman_inet_table2string(table_id), metric);