mbox series

[v5,0/6] CXL core reorganization

Message ID 162792537312.368511.15862521152871631343.stgit@dwillia2-desk3.amr.corp.intel.com
Headers show
Series CXL core reorganization | expand

Message

Dan Williams Aug. 2, 2021, 5:29 p.m. UTC
Changes since v4 [1]:
- Fix ARCH=um compile errors reported by 0day caused by header
  filename collisions with "mem.h", moved to "cxlmem.h"

- Improve kdoc note for @fops attribute of 'struct
  cdevm_file_operations' (Jonathan)

- Include core.h in memdev.c to fix "no prior declaration" warnings
  (kbuild robot)

- Collect reviewed-by's from Jonathan

[1]: https://lore.kernel.org/r/162774927110.4094313.9743731504096769799.stgit@dwillia2-desk3.amr.corp.intel.com

---

Original Cover from Ben:

The main motivation of the patch series is to establish the cxl_core driver in
its own directory and modularize it. Specifically, the patch series aims to
achieve three things:
1. Move existing core functionality to a new directory.
2. Split existing core functionality into multiple files.
3. Migrate memdev functionality into core.

#1 is trivially accomplished with git mv. The file itself is renamed back to
bus.c since the goal is to break up core functionality into multiple files, and
so the name core.c doesn't make sense in that context.

#2 is also trivially accomplished via cut/paste.

#3 is slightly invasive in that it has certain functional changes to improve the
existing interfaces and make them more generic. The rest of the change is
cut/paste. This is also the only part of the series which has runtime functional
change in that some interfaces are removed from cxl_pci, moved into cxl_core,
and exported for other drivers to use.

---

Ben Widawsky (3):
      cxl: Move cxl_core to new directory
      cxl/core: Improve CXL core kernel docs
      cxl/core: Move memdev management to core

Dan Williams (3):
      cxl/core: Move pmem functionality
      cxl/core: Move register mapping infrastructure
      cxl/pci: Introduce cdevm_file_operations


 Documentation/driver-api/cxl/memory-devices.rst |    8 
 drivers/cxl/Makefile                            |    4 
 drivers/cxl/core/Makefile                       |    8 
 drivers/cxl/core/bus.c                          |  464 +----------------------
 drivers/cxl/core/core.h                         |   20 +
 drivers/cxl/core/memdev.c                       |  246 ++++++++++++
 drivers/cxl/core/pmem.c                         |  204 ++++++++++
 drivers/cxl/core/regs.c                         |  235 ++++++++++++
 drivers/cxl/cxlmem.h                            |   26 +
 drivers/cxl/pci.c                               |  259 +------------
 drivers/cxl/pmem.c                              |    2 
 11 files changed, 795 insertions(+), 681 deletions(-)
 create mode 100644 drivers/cxl/core/Makefile
 rename drivers/cxl/{core.c => core/bus.c} (58%)
 create mode 100644 drivers/cxl/core/core.h
 create mode 100644 drivers/cxl/core/memdev.c
 create mode 100644 drivers/cxl/core/pmem.c
 create mode 100644 drivers/cxl/core/regs.c
 rename drivers/cxl/{mem.h => cxlmem.h} (76%)

base-commit: ff1176468d368232b684f75e82563369208bc371