[0/2] hw/cxl: Two CXL emulation fixes.

Message

Jonathan Cameron Aug. 8, 2022, 12:20 p.m. UTC

Peter Maydell reported both these issues, having looked into Coverity
identified issues. The memory leak was straight forward, but testing the
second patch identified a bug in the Linux kernel.

This bug has been fixed in the series
https://lore.kernel.org/linux-cxl/[e-mail]/T/#t
and is now available in the cxl.git pending branch.

Another clear example of why QEMU emulation is useful for kernel development.

Jonathan Cameron (2):
  hw/cxl: Fix memory leak in error paths
  hw/cxl: Fix wrong query of target ports

 hw/cxl/cxl-host.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

Comments

Jonathan Cameron Aug. 17, 2022, 11:45 a.m. UTC | #1

On Mon, 8 Aug 2022 13:20:49 +0100
Jonathan Cameron <[e-mail]> wrote:

> Peter Maydell reported both these issues, having looked into Coverity
> identified issues. The memory leak was straight forward, but testing the
> second patch identified a bug in the Linux kernel.
> 
> This bug has been fixed in the series
> https://lore.kernel.org/linux-cxl/[e-mail]/T/#t
> and is now available in the cxl.git pending branch.
> 
> Another clear example of why QEMU emulation is useful for kernel development.

Hi,

Any feedback on these two fixes?

Along with a two more fixes to follow in a few mins these are needed for the region code
in Linux 6.0-rc1 to work (there is a kernel fix as well that came from testing against
QEMU).

For full support we need one more feature (serial number provisioning) but without that
we get regions working as long as you create them fresh on each boot.

Thanks,

Jonathan

> 
> Jonathan Cameron (2):
>   hw/cxl: Fix memory leak in error paths
>   hw/cxl: Fix wrong query of target ports
> 
>  hw/cxl/cxl-host.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>