From patchwork Fri Feb 17 18:18:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13145126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC803C05027 for ; Fri, 17 Feb 2023 18:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbjBQSSI (ORCPT ); Fri, 17 Feb 2023 13:18:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjBQSSH (ORCPT ); Fri, 17 Feb 2023 13:18:07 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 600DD12079 for ; Fri, 17 Feb 2023 10:18:05 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PJKgR5mmrz6J682; Sat, 18 Feb 2023 02:13:23 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 17 Feb 2023 18:18:02 +0000 From: Jonathan Cameron To: , Michael Tsirkin CC: Ben Widawsky , , , Ira Weiny , Gregory Price , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Mike Maslenkin , Markus Armbruster , Dave Jiang , Subject: [PATCH 0/6] hw/cxl: Poison get, inject, clear Date: Fri, 17 Feb 2023 18:18:06 +0000 Message-ID: <20230217181812.26995-1-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org Note Alison has stated the kernel series will be post 6.3 material so this one isn't quite as urgent as the patches it is based on. However I think this series in a good state (plus I have lots more queued behind it) hence promoting it from RFC. Changes since RFC v2: Thanks to Markus for review. - Improve documentation for QMP interface - Add better description of baseline series - Include precursor refactors around ret_code / CXLRetCode as this is now the first series in suggeste merge order to rely on those. - Include Ira's cxl_device_get_timestamp() function as it was better than the equivalent in the RFC. Based on following series (in order) 1. [PATCH v4 00/10] hw/cxl: CXL emulation cleanups and minor fixes for upstream 2. [PATCH v4 0/8] hw/cxl: RAS error emulation and injection 3. [PATCH 0/2] hw/cxl: Passthrough HDM decoder emulation 4. [PATCH v2 0/2] hw/mem: CXL Type-3 Volatile Memory Support Based on: Message-Id: 20230206172816.8201-1-Jonathan.Cameron@huawei.com Based-on: Message-id: 20230217172924.25239-1-Jonathan.Cameron@huawei.com Based-on: Message-id: 20230125152703.9928-1-Jonathan.Cameron@huawei.com Based-on: Message-id: 20230217175657.26632-1-Jonathan.Cameron@huawei.com The series supports: 1) Injection of variable length poison regions via QMP (to fake real memory corruption and ensure we deal with odd overflow corner cases such as clearing the middle of a large region making the list overflow as we go from one long entry to two smaller entries. 2) Read of poison list via the CXL mailbox. 3) Injection via the poison injection mailbox command (limited to 64 byte entries) 4) Clearing of poison injected via either method. The implementation is meant to be a valid combination of impdef choices based on what the spec allowed. There are a number of places where it could be made more sophisticated that we might consider in future: * Fusing adjacent poison entries if the types match. * Separate injection list and main poison list, to test out limits on injected poison list being smaller than the main list. * Poison list overflow event (needs event log support in general) * Connecting up to the poison list error record generation (rather complex and not needed for currently kernel handling testing). As the kernel code is currently fairly simple, it is likely that the above does not yet matter but who knows what will turn up in future! Kernel patches: [PATCH v6 0/6] CXL Poison List Retrieval & Tracing Message-id: cover.1675983077.git.alison.schofield@intel.com [PATCH v2 0/6] cxl: CXL Inject & Clear Poison cover.1674101475.git.alison.schofield@intel.com Ira Weiny (1): hw/cxl: Introduce cxl_device_get_timestamp() utility function Jonathan Cameron (5): hw/cxl: Move enum ret_code definition to cxl_device.h hw/cxl: rename mailbox return code type from ret_code to CXLRetCode hw/cxl: QMP based poison injection support hw/cxl: Add poison injection via the mailbox. hw/cxl: Add clear poison mailbox command support. hw/cxl/cxl-device-utils.c | 15 ++ hw/cxl/cxl-mailbox-utils.c | 300 +++++++++++++++++++++++++++--------- hw/mem/cxl_type3.c | 92 +++++++++++ hw/mem/cxl_type3_stubs.c | 3 + hw/mem/meson.build | 2 + include/hw/cxl/cxl_device.h | 51 ++++++ qapi/cxl.json | 16 ++ 7 files changed, 410 insertions(+), 69 deletions(-)