mbox series

[v2,0/4] acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors

Message ID 20240109034755.100555-1-Smita.KoralahalliChannabasappa@amd.com
Headers show
Series acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors | expand

Message

Smita Koralahalli Jan. 9, 2024, 3:47 a.m. UTC
This patchset adds trace event support for FW-First Protocol Errors.

This series depends on:
https://lore.kernel.org/linux-cxl/20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com

Link to v1:
https://lore.kernel.org/all/20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com

Smita Koralahalli (4):
  acpi/ghes, cxl: Create a common CXL struct to handle different CXL
    CPER records
  efi/cper, cxl: Make definitions and structures global
  acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
  acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors

 drivers/acpi/apei/ghes.c        | 22 ++++++++-
 drivers/cxl/core/pci.c          | 29 ++++++++++++
 drivers/cxl/cxlpci.h            |  3 ++
 drivers/cxl/pci.c               | 13 ++++--
 drivers/firmware/efi/cper_cxl.c | 79 ++++++++++++++++++++++++++++-----
 drivers/firmware/efi/cper_cxl.h |  7 +--
 include/linux/cper.h            |  4 ++
 include/linux/cxl-event.h       | 31 ++++++++++++-
 8 files changed, 166 insertions(+), 22 deletions(-)

Comments

Fabio M. De Francesco May 7, 2024, 9:35 a.m. UTC | #1
On Tuesday, January 9, 2024 4:47:51 AM GMT+2 Smita Koralahalli wrote:
> This patchset adds trace event support for FW-First Protocol Errors.
> 
> This series depends on:
> https://lore.kernel.org/linux-cxl/20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.
> com
> 
Hello Smita,

I'm working on a small series of enhancement and additions to kernel logs and 
trace events in extlog_print() (ELOG). I'm interested to reuse from ELOG the 
infrastructure which you made to trace the CXL Protocol Errors.

I'm aware that this series depends on an old one from Ira which has been 
superseded by a different implementation and, furthermore, that this needs to 
be reworked   because the execution of this code may sleep while in atomic 
context. 

I'd like to ask if you plan to fix and rebase this series to a current cxl 
branch. If so, I'll wait for the next version to integrate in ELOG.

Otherwise, if you are not anymore actively working on this series, please 
notice that I'd be glad to help by making the necessary changes and by porting 
your code to a current cxl branch (of course, retaining your authorship).

Thanks,

Fabio M. De Francesco
>
> Link to v1:
> https://lore.kernel.org/all/20240102150933.161009-1-Smita.KoralahalliChannab
> asappa@amd.com
> 
> Smita Koralahalli (4):
>   acpi/ghes, cxl: Create a common CXL struct to handle different CXL
>     CPER records
>   efi/cper, cxl: Make definitions and structures global
>   acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
>   acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors
> 
>  drivers/acpi/apei/ghes.c        | 22 ++++++++-
>  drivers/cxl/core/pci.c          | 29 ++++++++++++
>  drivers/cxl/cxlpci.h            |  3 ++
>  drivers/cxl/pci.c               | 13 ++++--
>  drivers/firmware/efi/cper_cxl.c | 79 ++++++++++++++++++++++++++++-----
>  drivers/firmware/efi/cper_cxl.h |  7 +--
>  include/linux/cper.h            |  4 ++
>  include/linux/cxl-event.h       | 31 ++++++++++++-
>  8 files changed, 166 insertions(+), 22 deletions(-)
Smita Koralahalli May 16, 2024, 5:59 p.m. UTC | #2
Hi Fabio,

On 5/7/2024 2:35 AM, Fabio M. De Francesco wrote:
> On Tuesday, January 9, 2024 4:47:51 AM GMT+2 Smita Koralahalli wrote:
>> This patchset adds trace event support for FW-First Protocol Errors.
>>
>> This series depends on:
>> https://lore.kernel.org/linux-cxl/20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.
>> com
>>
> Hello Smita,
> 
> I'm working on a small series of enhancement and additions to kernel logs and
> trace events in extlog_print() (ELOG). I'm interested to reuse from ELOG the
> infrastructure which you made to trace the CXL Protocol Errors.
> 
> I'm aware that this series depends on an old one from Ira which has been
> superseded by a different implementation and, furthermore, that this needs to
> be reworked   because the execution of this code may sleep while in atomic
> context.
> 
> I'd like to ask if you plan to fix and rebase this series to a current cxl
> branch. If so, I'll wait for the next version to integrate in ELOG.
> 
> Otherwise, if you are not anymore actively working on this series, please
> notice that I'd be glad to help by making the necessary changes and by porting
> your code to a current cxl branch (of course, retaining your authorship).
> 
> Thanks,
> 
> Fabio M. De Francesco

Sorry missed your message on my inbox. Yes, I will get back working on 
v3 on this early next week. Couldn't get a chance to continue due to 
other pcie work. Hopefully, I can get something out next week.

Thanks
Smita

>>
>> Link to v1:
>> https://lore.kernel.org/all/20240102150933.161009-1-Smita.KoralahalliChannab
>> asappa@amd.com
>>
>> Smita Koralahalli (4):
>>    acpi/ghes, cxl: Create a common CXL struct to handle different CXL
>>      CPER records
>>    efi/cper, cxl: Make definitions and structures global
>>    acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
>>    acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors
>>
>>   drivers/acpi/apei/ghes.c        | 22 ++++++++-
>>   drivers/cxl/core/pci.c          | 29 ++++++++++++
>>   drivers/cxl/cxlpci.h            |  3 ++
>>   drivers/cxl/pci.c               | 13 ++++--
>>   drivers/firmware/efi/cper_cxl.c | 79 ++++++++++++++++++++++++++++-----
>>   drivers/firmware/efi/cper_cxl.h |  7 +--
>>   include/linux/cper.h            |  4 ++
>>   include/linux/cxl-event.h       | 31 ++++++++++++-
>>   8 files changed, 166 insertions(+), 22 deletions(-)
> 
> 
> 
>